talkatu/talkatu

Clean up some issues found in review

2020-04-26, Gary Kramlich
be6fa83442f7
Parents b55f80536e48
Children a0e74479c2ab
Clean up some issues found in review
1 files changed, 12 insertions(+), 15 deletions(-)
  • +12 -15
    talkatu/talkatutypinglabel.c
    • --- a/talkatu/talkatutypinglabel.c Thu Apr 23 22:36:57 2020 -0500
    +++ b/talkatu/talkatutypinglabel.c Sun Apr 26 02:34:14 2020 -0500
    @@ -120,9 +120,7 @@
    }
    n_typers = g_list_length(typers);
    - if(n_typers == 0) {
    - gtk_label_set_text(GTK_LABEL(label), "");
    - } else if(n_typers > 3) {
    + if(n_typers > 3) {
    gtk_label_set_text(GTK_LABEL(label),
    _("Several people are typing..."));
    } else {
    @@ -192,16 +190,15 @@
    signals[SIG_CHANGED] = g_signal_new(
    "changed",
    G_TYPE_FROM_CLASS(klass),
    - G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
    - G_STRUCT_OFFSET(TalkatuTypingLabelClass, changed),
    - NULL,
    - NULL,
    - NULL,
    - G_TYPE_NONE,
    - 1,
    - G_TYPE_POINTER
    - );
    -
    + G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
    + G_STRUCT_OFFSET(TalkatuTypingLabelClass, changed),
    + NULL,
    + NULL,
    + NULL,
    + G_TYPE_NONE,
    + 1,
    + G_TYPE_POINTER
    + );
    }
    /******************************************************************************
    @@ -211,7 +208,7 @@
    /**
    * talkatu_typing_label_new:
    *
    - * Creates a new #TalkatuTypingLabel that displays whos is typing.
    + * Creates a new #TalkatuTypingLabel that displays who is typing.
    *
    * Returns: (transfer full): The new #TalkatuTypingLabel instance.
    */
    @@ -256,7 +253,7 @@
    value = GUINT_TO_POINTER(timeout_id);
    - if(!g_hash_table_replace(priv->typers, typing_data->who, value)) {
    + if(g_hash_table_replace(priv->typers, typing_data->who, value)) {
    /* the user wasn't in the list so we need to emit our changed signal */
    GList *typers = g_hash_table_get_keys(priv->typers);