Fix Finch clang scan-build warnings
--- a/gntbox.c Sun Feb 23 01:23:52 2014 +0530
+++ b/gntbox.c Thu Apr 03 18:45:27 2014 +0200
@@ -731,6 +731,11 @@
+ if (G_UNLIKELY(w == NULL)) { if (GNT_WIDGET_IS_FLAG_SET(w, GNT_WIDGET_INVISIBLE))
@@ -819,6 +824,12 @@
for (iter = box->list; iter; iter = iter->next)
GntWidget *w = iter->data;
+ if (G_UNLIKELY(w == NULL)) { gnt_box_readjust(GNT_BOX(w));
--- a/gntmenu.c Sun Feb 23 01:23:52 2014 +0530
+++ b/gntmenu.c Thu Apr 03 18:45:27 2014 +0200
@@ -121,6 +121,8 @@
char trigger[4] = "\0 )\0";
+ g_return_if_fail(item != NULL); if ((trigger[1] = gnt_menuitem_get_trigger(item)) && trigger[1] != ' ')
--- a/gnttextview.c Sun Feb 23 01:23:52 2014 +0530
+++ b/gnttextview.c Thu Apr 03 18:45:27 2014 +0200
@@ -335,6 +335,9 @@
GntTextView *view = GNT_TEXT_VIEW(widget);
if (text_view_contains(view, select_start)) {
+ g_return_val_if_fail(select_start != NULL, TRUE); select_end = gnt_text_view_get_p(view, x - widget->priv.x, y - widget->priv.y);
if (select_end < select_start) {
@@ -758,6 +761,12 @@
GntTextLine *line = iter->data;
for (segs = line->segments; segs; segs = snext) {
GntTextSegment *seg = segs->data;
--- a/gnttree.c Sun Feb 23 01:23:52 2014 +0530
+++ b/gnttree.c Thu Apr 03 18:45:27 2014 +0200
@@ -1314,7 +1314,8 @@
- s->prev = row; /* s cannot be NULL */
+ g_return_if_fail(s != NULL); /* s cannot be NULL */ newp = g_list_index(tree->list, s) - 1;
--- a/gntwm.c Sun Feb 23 01:23:52 2014 +0530
+++ b/gntwm.c Thu Apr 03 18:45:27 2014 +0200
@@ -2251,8 +2251,14 @@
void gnt_wm_raise_window(GntWM *wm, GntWidget *widget)
GntWS *ws = gnt_wm_widget_find_workspace(wm, widget);
+ g_return_if_fail(wm != NULL); gnt_wm_switch_workspace(wm, g_list_index(wm->workspaces, ws));
+ g_return_if_fail(wm->cws != NULL); if (widget != wm->cws->ordered->data) {
GntWidget *wid = wm->cws->ordered->data;
wm->cws->ordered = g_list_bring_to_front(wm->cws->ordered, widget);
--- a/wms/irssi.c Sun Feb 23 01:23:52 2014 +0530
+++ b/wms/irssi.c Thu Apr 03 18:45:27 2014 +0200
@@ -155,6 +155,9 @@
+ g_return_if_fail(win != NULL); + g_return_if_fail(wm != NULL); name = gnt_widget_get_name(win);
if (!name || !strstr(name, "conversation-window")) {
if (!GNT_IS_MENU(win) && !GNT_WIDGET_IS_FLAG_SET(win, GNT_WIDGET_TRANSIENT)) {
--- a/wms/s.c Sun Feb 23 01:23:52 2014 +0530
+++ b/wms/s.c Thu Apr 03 18:45:27 2014 +0200
@@ -84,6 +84,9 @@
+ g_return_if_fail(win != NULL); + g_return_if_fail(wm != NULL); getmaxyx(stdscr, maxy, maxx);