qulogic/libgnt

Fix some CWE-252 coverity warnings
release-2.x.y
2014-05-06, Tomasz Wasilczyk
8798257b5e37
Parents 5eb75f6413f5
Children d2943ae9fe18
Fix some CWE-252 coverity warnings
7 files changed, 10 insertions(+), 8 deletions(-)
  • +2 -2
    gntbox.c
  • +1 -1
    gntcheckbox.c
  • +1 -1
    gntcombobox.c
  • +1 -1
    gntentry.c
  • +1 -1
    gnttextview.c
  • +3 -1
    gntwm.c
  • +1 -1
    wms/irssi.c
    • --- a/gntbox.c Tue May 06 15:17:11 2014 +0200
    +++ b/gntbox.c Tue May 06 19:38:50 2014 +0200
    @@ -232,8 +232,8 @@
    h = maxh;
    }
    - gnt_widget_confirm_size(wid, w, h);
    - gnt_widget_set_size(wid, w, h);
    + if (gnt_widget_confirm_size(wid, w, h))
    + gnt_widget_set_size(wid, w, h);
    }
    reposition_children(widget);
    --- a/gntcheckbox.c Tue May 06 15:17:11 2014 +0200
    +++ b/gntcheckbox.c Tue May 06 19:38:50 2014 +0200
    @@ -52,7 +52,7 @@
    wbkgdset(widget->window, '\0' | gnt_color_pair(GNT_COLOR_NORMAL));
    mvwaddstr(widget->window, 0, 4, C_(GNT_BUTTON(cb)->priv->text));
    - wmove(widget->window, 0, 1);
    + (void)wmove(widget->window, 0, 1);
    GNTDEBUG;
    }
    --- a/gntcombobox.c Tue May 06 15:17:11 2014 +0200
    +++ b/gntcombobox.c Tue May 06 19:38:50 2014 +0200
    @@ -96,7 +96,7 @@
    whline(widget->window, ' ' | gnt_color_pair(type), widget->priv.width - 4 - len);
    mvwaddch(widget->window, 1, widget->priv.width - 3, ACS_VLINE | gnt_color_pair(GNT_COLOR_NORMAL));
    mvwaddch(widget->window, 1, widget->priv.width - 2, ACS_DARROW | gnt_color_pair(GNT_COLOR_NORMAL));
    - wmove(widget->window, 1, 1);
    + (void)wmove(widget->window, 1, 1);
    g_free(text);
    GNTDEBUG;
    --- a/gntentry.c Tue May 06 15:17:11 2014 +0200
    +++ b/gntentry.c Tue May 06 19:38:50 2014 +0200
    @@ -299,7 +299,7 @@
    curpos = gnt_util_onscreen_width(entry->scroll, entry->cursor);
    if (focus)
    mvwchgat(widget->window, 0, curpos, 1, A_REVERSE, GNT_COLOR_TEXT_NORMAL, NULL);
    - wmove(widget->window, 0, curpos);
    + (void)wmove(widget->window, 0, curpos);
    GNTDEBUG;
    }
    --- a/gnttextview.c Tue May 06 15:17:11 2014 +0200
    +++ b/gnttextview.c Tue May 06 19:38:50 2014 +0200
    @@ -106,7 +106,7 @@
    GList *iter;
    GntTextLine *line = lines->data;
    - wmove(widget->window, widget->priv.height - 1 - i - comp, 0);
    + (void)wmove(widget->window, widget->priv.height - 1 - i - comp, 0);
    for (iter = line->segments; iter; iter = iter->next)
    {
    --- a/gntwm.c Tue May 06 15:17:11 2014 +0200
    +++ b/gntwm.c Tue May 06 19:38:50 2014 +0200
    @@ -148,7 +148,7 @@
    int curx = active->priv.x + getcurx(active->window);
    int cury = active->priv.y + getcury(active->window);
    if (wmove(node->window, cury - widget->priv.y, curx - widget->priv.x) != OK)
    - wmove(node->window, 0, 0);
    + (void)wmove(node->window, 0, 0);
    }
    }
    }
    @@ -1850,6 +1850,8 @@
    maxx = getmaxx(stdscr);
    maxy = getmaxy(stdscr) - 1; /* room for the taskbar */
    + maxx = MAX(0, maxx);
    + maxy = MAX(0, maxy);
    x = MAX(0, x);
    y = MAX(0, y);
    --- a/wms/irssi.c Tue May 06 15:17:11 2014 +0200
    +++ b/wms/irssi.c Tue May 06 19:38:50 2014 +0200
    @@ -215,7 +215,7 @@
    getyx(node->window, y, x);
    wbkgdset(node->window, '\0' | COLOR_PAIR(gnt_widget_has_focus(node->me) ? GNT_COLOR_TITLE : GNT_COLOR_TITLE_D));
    mvwaddstr(node->window, 0, 0, title);
    - wmove(node->window, y, x);
    + (void)wmove(node->window, y, x);
    if (!gnt_is_refugee()) {
    update_panels();
    doupdate();