qulogic/gplugin

Replace all other uses for gplugin_manager_free_plugin_list with g_slist_free_full
feature/remove-gplugin_manager_free_plugin_list
2020-02-22, Gary Kramlich
fa06a06a8aa5
Parents 207a4982ca78
Children 788d3d29af14
Replace all other uses for gplugin_manager_free_plugin_list with g_slist_free_full
5 files changed, 3 insertions(+), 29 deletions(-)
  • +1 -1
    gplugin-gtk/gplugin-gtk-store.c
  • +0 -25
    gplugin/gplugin-manager.c
  • +0 -1
    gplugin/gplugin-manager.h
  • +1 -1
    gplugin/gplugin-query.c
  • +1 -1
    gplugin/tests/test-id-collision.c
    • --- a/gplugin-gtk/gplugin-gtk-store.c Sat Feb 22 05:12:54 2020 -0600
    +++ b/gplugin-gtk/gplugin-gtk-store.c Sat Feb 22 05:16:05 2020 -0600
    @@ -107,7 +107,7 @@
    plugins = gplugin_manager_find_plugins(id);
    for(l = plugins; l; l = l->next)
    gplugin_gtk_store_add_plugin(store, GPLUGIN_PLUGIN(l->data));
    - gplugin_manager_free_plugin_list(plugins);
    + g_slist_free_full(plugins, g_object_unref);
    }
    static gboolean
    --- a/gplugin/gplugin-manager.c Sat Feb 22 05:12:54 2020 -0600
    +++ b/gplugin/gplugin-manager.c Sat Feb 22 05:16:05 2020 -0600
    @@ -1367,31 +1367,6 @@
    }
    /**
    - * gplugin_manager_free_plugin_list:
    - * @plugins_list: (element-type GPlugin.Plugin) (nullable): Returned value from
    - * plugin_manager_find_plugins().
    - *
    - * Frees the returned value of gplugin_manager_find_plugins().
    - */
    -void
    -gplugin_manager_free_plugin_list(GSList *plugins_list) {
    - GSList *l = NULL;
    -
    - for(l = plugins_list; l; l = l->next) {
    - GPluginPlugin *plugin = NULL;
    -
    - if(l->data == NULL)
    - continue;
    -
    - plugin = GPLUGIN_PLUGIN(l->data);
    -
    - g_object_unref(G_OBJECT(plugin));
    - }
    -
    - g_slist_free(plugins_list);
    -}
    -
    -/**
    * gplugin_manager_find_plugin:
    * @id: The id of the plugin to find.
    *
    --- a/gplugin/gplugin-manager.h Sat Feb 22 05:12:54 2020 -0600
    +++ b/gplugin/gplugin-manager.h Sat Feb 22 05:16:05 2020 -0600
    @@ -46,7 +46,6 @@
    GSList *gplugin_manager_find_plugins(const gchar *id);
    GSList *gplugin_manager_find_plugins_with_version(const gchar *id, const gchar *op, const gchar *version);
    -void gplugin_manager_free_plugin_list(GSList *plugins_list);
    GPluginPlugin *gplugin_manager_find_plugin(const gchar *id);
    --- a/gplugin/gplugin-query.c Sat Feb 22 05:12:54 2020 -0600
    +++ b/gplugin/gplugin-query.c Sat Feb 22 05:16:05 2020 -0600
    @@ -219,7 +219,7 @@
    first = FALSE;
    }
    - gplugin_manager_free_plugin_list(plugins);
    + g_slist_free_full(plugins, g_object_unref);
    return TRUE;
    }
    --- a/gplugin/tests/test-id-collision.c Sat Feb 22 05:12:54 2020 -0600
    +++ b/gplugin/tests/test-id-collision.c Sat Feb 22 05:16:05 2020 -0600
    @@ -39,7 +39,7 @@
    g_assert_cmpuint(g_slist_length(plugins), ==, 2);
    - gplugin_manager_free_plugin_list(plugins);
    + g_slist_free_full(plugins, g_object_unref);
    }
    /******************************************************************************