pidgin/pidgin

Don't set some PurpleBuddy properties at construction time

2022-03-22, Elliott Sales de Andrade
f33f4713508b
Parents 84e92cf6f64a
Children 53e4815ef254
Don't set some PurpleBuddy properties at construction time

These properties don't appear to be read at construction time, and in fact
their setter accesses `priv->account`, which is not yet set, causing some
critical warnings.

Testing Done:
Ran with demo prpl and no longer have this critical:

```
(pidgin3:1123375): Purple-CRITICAL **: 02:45:40.007: purple_conversation_manager_find_im: assertion 'PURPLE_IS_ACCOUNT(account)' failed
```

Reviewed at https://reviews.imfreedom.org/r/1361/
1 files changed, 2 insertions(+), 2 deletions(-)
  • +2 -2
    libpurple/buddy.c
    • --- a/libpurple/buddy.c Mon Mar 21 20:33:13 2022 -0500
    +++ b/libpurple/buddy.c Tue Mar 22 03:53:15 2022 -0500
    @@ -247,13 +247,13 @@
    "name", "Name",
    "The name of the buddy.",
    NULL,
    - G_PARAM_READWRITE | G_PARAM_CONSTRUCT | G_PARAM_STATIC_STRINGS);
    + G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
    properties[PROP_LOCAL_ALIAS] = g_param_spec_string(
    "local-alias", "Local alias",
    "Local alias of thee buddy.",
    NULL,
    - G_PARAM_READWRITE | G_PARAM_CONSTRUCT | G_PARAM_STATIC_STRINGS);
    + G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
    properties[PROP_SERVER_ALIAS] = g_param_spec_string(
    "server-alias", "Server alias",