pidgin/pidgin

Fix a logic error in jabber that caused a user after free
release-2.x.y
2021-06-01, Gary Kramlich
f25ce9376564
Parents de9b3386381b
Children f1ffe1b5a9d8
Fix a logic error in jabber that caused a user after free

Testing Done:
Verified that scanbuild no longer detected the error.

Reviewed at https://reviews.imfreedom.org/r/693/
1 files changed, 1 insertions(+), 1 deletions(-)
  • +1 -1
    libpurple/protocols/jabber/message.c
    • --- a/libpurple/protocols/jabber/message.c Tue Jun 01 16:51:13 2021 -0500
    +++ b/libpurple/protocols/jabber/message.c Tue Jun 01 17:34:45 2021 -0500
    @@ -203,7 +203,7 @@
    if(jbr->thread_id)
    g_free(jbr->thread_id);
    - jbr->thread_id = g_strdup(jbr->thread_id);
    + jbr->thread_id = g_strdup(jm->thread_id);
    }
    serv_got_im(gc, jm->from, body->str, 0, jm->sent);