pidgin/pidgin

Remove some old work arounds for coverity.

2021-01-02, Gary Kramlich
da66e75a4221
Parents 50284e37698c
Children 8f1d8122f07e
Remove some old work arounds for coverity.

Testing Done:
Compiled locally.

Reviewed at https://reviews.imfreedom.org/r/321/
2 files changed, 0 insertions(+), 11 deletions(-)
  • +0 -8
    libpurple/internal.h
  • +0 -3
    libpurple/prefs.c
    • --- a/libpurple/internal.h Fri Jan 01 02:39:09 2021 -0600
    +++ b/libpurple/internal.h Sat Jan 02 00:37:22 2021 -0600
    @@ -126,12 +126,4 @@
    #include <glib-object.h>
    -#ifdef __COVERITY__
    -
    -/* avoid TAINTED_SCALAR warning */
    -#undef g_utf8_next_char
    -#define g_utf8_next_char(p) (char *)((p) + 1)
    -
    -#endif
    -
    #endif /* PURPLE_INTERNAL_H */
    --- a/libpurple/prefs.c Fri Jan 01 02:39:09 2021 -0600
    +++ b/libpurple/prefs.c Sat Jan 02 00:37:22 2021 -0600
    @@ -439,11 +439,8 @@
    error = NULL;
    -#ifndef __COVERITY__
    - /* coverity dead_error_line false positive */
    if (sysconfdir == NULL)
    sysconfdir = "";
    -#endif
    filename = g_build_filename(sysconfdir, "purple", "prefs.xml", NULL);
    purple_debug_info("prefs", "Reading %s\n", filename);