pidgin/pidgin

Fix a use after free scanbuild found in buddyicon.c
release-2.x.y
2021-06-01, Gary Kramlich
c997d298cd4c
Parents f2cec5958ed7
Children 8aafbbfc4f42
Fix a use after free scanbuild found in buddyicon.c

Testing Done:
Verified scanbuild no longer detected the error.

Reviewed at https://reviews.imfreedom.org/r/698/
1 files changed, 3 insertions(+), 2 deletions(-)
  • +3 -2
    libpurple/buddyicon.c
    • --- a/libpurple/buddyicon.c Tue Jun 01 20:13:19 2021 -0500
    +++ b/libpurple/buddyicon.c Tue Jun 01 20:13:53 2021 -0500
    @@ -1045,18 +1045,19 @@
    return;
    }
    - g_free(path);
    -
    new_filename = purple_util_get_image_filename(icon_data, icon_len);
    if (new_filename == NULL)
    {
    purple_debug_error("buddyicon",
    "New icon filename is NULL. This should never happen! "
    "The old filename was: %s\n", path);
    + g_free(path);
    delete_buddy_icon_settings(node, setting_name);
    +
    g_return_if_reached();
    }
    + g_free(path);
    path = g_build_filename(dirname, new_filename, NULL);
    if ((file = g_fopen(path, "wb")) != NULL)
    {