pidgin/pidgin

Fix some issues scanbuild found in the irc protocol plugin
release-2.x.y
2021-06-02, Gary Kramlich
8924ad9e86c4
Parents 40211e37a935
Children a0e7e3b8e834
Fix some issues scanbuild found in the irc protocol plugin

Testing Done:
Verified that scanbuild no longer detected the errors.

Reviewed at https://reviews.imfreedom.org/r/713/
1 files changed, 5 insertions(+), 2 deletions(-)
  • +5 -2
    libpurple/protocols/irc/msgs.c
    • --- a/libpurple/protocols/irc/msgs.c Wed Jun 02 02:59:43 2021 -0500
    +++ b/libpurple/protocols/irc/msgs.c Wed Jun 02 03:00:13 2021 -0500
    @@ -1494,7 +1494,10 @@
    } else {
    secprops.max_ssf = 0;
    secprops.maxbufsize = 0;
    - plaintext = TRUE;
    + /* this isn't checked anywhere else, but I'm going to guess it's because
    + * something is incomplete?.
    + */
    + /* plaintext = TRUE; */
    }
    secprops.property_names = 0;
    @@ -1592,7 +1595,7 @@
    return;
    }
    - if ((ret = sasl_client_init(NULL)) != SASL_OK) {
    + if (sasl_client_init(NULL) != SASL_OK) {
    const char *tmp = _("SASL authentication failed: Initializing SASL failed.");
    purple_connection_error_reason (gc,
    PURPLE_CONNECTION_ERROR_OTHER_ERROR, tmp);