Mark unused parameters as such for all of the purple plugins
Testing Done:
Turned the warning level up to 2, compiled, and verified the warnings were gone.
Reviewed at https://reviews.imfreedom.org/r/2253/
--- a/libpurple/plugins/autoaccept/autoaccept.c Wed Feb 22 22:19:01 2023 -0600
+++ b/libpurple/plugins/autoaccept/autoaccept.c Wed Feb 22 22:19:57 2023 -0600
@@ -96,7 +96,7 @@
-file_recv_request_cb(PurpleXfer *xfer, gpointer handle)
+file_recv_request_cb(PurpleXfer *xfer, G_GNUC_UNUSED gpointer data) GSettings *settings = NULL;
@@ -252,7 +252,7 @@
static GPluginPluginInfo *
-auto_accept_query(GError **error)
+auto_accept_query(G_GNUC_UNUSED GError **error) const gchar * const authors[] = PLUGIN_AUTHORS;
@@ -272,7 +272,7 @@
-auto_accept_load(GPluginPlugin *plugin, GError **error)
+auto_accept_load(GPluginPlugin *plugin, G_GNUC_UNUSED GError **error) GSettings *settings = NULL;
@@ -306,7 +306,9 @@
-auto_accept_unload(GPluginPlugin *plugin, gboolean shutdown, GError **error)
+auto_accept_unload(G_GNUC_UNUSED GPluginPlugin *plugin, + G_GNUC_UNUSED gboolean shutdown, + G_GNUC_UNUSED GError **error) --- a/libpurple/plugins/buddynote/buddynote.c Wed Feb 22 22:19:01 2023 -0600
+++ b/libpurple/plugins/buddynote/buddynote.c Wed Feb 22 22:19:57 2023 -0600
@@ -24,7 +24,8 @@
-dont_do_it_cb(PurpleBlistNode *node, const char *note)
+dont_do_it_cb(G_GNUC_UNUSED PurpleBlistNode *node, + G_GNUC_UNUSED const char *note) @@ -35,7 +36,7 @@
-buddynote_edit_cb(PurpleBlistNode *node, gpointer data)
+buddynote_edit_cb(PurpleBlistNode *node, G_GNUC_UNUSED gpointer data) @@ -64,7 +65,7 @@
static GPluginPluginInfo *
-buddy_note_query(GError **error)
+buddy_note_query(G_GNUC_UNUSED GError **error) const gchar * const authors[] = {
"Stu Tomlinson <stu@nosnilmot.com>",
@@ -87,7 +88,7 @@
-buddy_note_load(GPluginPlugin *plugin, GError **error)
+buddy_note_load(GPluginPlugin *plugin, G_GNUC_UNUSED GError **error) purple_signal_connect(purple_blist_get_handle(), "blist-node-extended-menu",
@@ -97,7 +98,9 @@
-buddy_note_unload(GPluginPlugin *plugin, gboolean shutdown, GError **error)
+buddy_note_unload(G_GNUC_UNUSED GPluginPlugin *plugin, + G_GNUC_UNUSED gboolean shutdown, + G_GNUC_UNUSED GError **error) --- a/libpurple/plugins/idle/idle.c Wed Feb 22 22:19:01 2023 -0600
+++ b/libpurple/plugins/idle/idle.c Wed Feb 22 22:19:57 2023 -0600
@@ -83,7 +83,7 @@
-idle_action_ok(void *ignored, PurpleRequestFields *fields)
+idle_action_ok(G_GNUC_UNUSED gpointer data, PurpleRequestFields *fields) PurpleAccount *acct = purple_request_fields_get_account(fields, "acct");
PurpleContactInfo *info = PURPLE_CONTACT_INFO(acct);
@@ -100,7 +100,7 @@
-idle_all_action_ok(void *ignored, PurpleRequestFields *fields)
+idle_all_action_ok(G_GNUC_UNUSED gpointer data, PurpleRequestFields *fields) PurpleAccountManager *manager = NULL;
PurpleAccount *acct = NULL;
@@ -129,7 +129,7 @@
-unidle_action_ok(void *ignored, PurpleRequestFields *fields)
+unidle_action_ok(G_GNUC_UNUSED gpointer data, PurpleRequestFields *fields) PurpleAccount *acct = purple_request_fields_get_account(fields, "acct");
@@ -140,7 +140,7 @@
-signing_off_cb(PurpleConnection *gc, void *data)
+signing_off_cb(PurpleConnection *gc, G_GNUC_UNUSED gpointer data) @@ -263,7 +263,7 @@
*****************************************************************************/
static GPluginPluginInfo *
-idle_query(GError **error)
+idle_query(G_GNUC_UNUSED GError **error) GSimpleActionGroup *group = NULL;
GActionEntry entries[] = {
@@ -319,7 +319,7 @@
-idle_load(GPluginPlugin *plugin, GError **error)
+idle_load(GPluginPlugin *plugin, G_GNUC_UNUSED GError **error) purple_signal_connect(purple_connections_get_handle(), "signing-off",
@@ -329,7 +329,9 @@
-idle_unload(GPluginPlugin *plugin, gboolean shutdown, GError **error)
+idle_unload(G_GNUC_UNUSED GPluginPlugin *plugin, + G_GNUC_UNUSED gboolean shutdown, + G_GNUC_UNUSED GError **error) purple_idle_unset_all_accounts_idle_time(NULL, NULL, NULL);
--- a/libpurple/plugins/joinpart/joinpart.c Wed Feb 22 22:19:01 2023 -0600
+++ b/libpurple/plugins/joinpart/joinpart.c Wed Feb 22 22:19:57 2023 -0600
@@ -122,22 +122,25 @@
-static gboolean chat_user_leaving_cb(PurpleConversation *conv, const char *name,
- const char *reason, GHashTable *users)
+chat_user_leaving_cb(PurpleConversation *conv, const char *name, + G_GNUC_UNUSED const char *reason, GHashTable *users) return should_hide_notice(conv, name, users);
-static gboolean chat_user_joining_cb(PurpleConversation *conv, const char *name,
- PurpleChatUserFlags flags,
+chat_user_joining_cb(PurpleConversation *conv, const char *name, + G_GNUC_UNUSED PurpleChatUserFlags flags, return should_hide_notice(conv, name, users);
-static void received_chat_msg_cb(PurpleAccount *account, char *sender,
- char *message, PurpleConversation *conv,
- PurpleMessageFlags flags, GHashTable *users)
+received_chat_msg_cb(G_GNUC_UNUSED PurpleAccount *account, char *sender, + G_GNUC_UNUSED char *message, PurpleConversation *conv, + G_GNUC_UNUSED PurpleMessageFlags flags, GHashTable *users) @@ -190,7 +193,7 @@
static GPluginPluginInfo *
-join_part_query(GError **error)
+join_part_query(G_GNUC_UNUSED GError **error) const gchar * const authors[] = {
"Richard Laager <rlaager@pidgin.im>",
@@ -215,7 +218,7 @@
-join_part_load(GPluginPlugin *plugin, GError **error)
+join_part_load(GPluginPlugin *plugin, G_GNUC_UNUSED GError **error) @@ -244,7 +247,9 @@
-join_part_unload(GPluginPlugin *plugin, gboolean shutdown, GError **error)
+join_part_unload(GPluginPlugin *plugin, + G_GNUC_UNUSED gboolean shutdown, + G_GNUC_UNUSED GError **error) /* Destroy the hash table. The core plugin code will
* disconnect the signals, and since Purple is single-threaded,
--- a/libpurple/plugins/kwallet/purplekwallet.cpp Wed Feb 22 22:19:01 2023 -0600
+++ b/libpurple/plugins/kwallet/purplekwallet.cpp Wed Feb 22 22:19:57 2023 -0600
@@ -396,7 +396,7 @@
-purple_kwallet_read_password_finish(PurpleCredentialProvider *provider,
+purple_kwallet_read_password_finish(G_GNUC_UNUSED PurpleCredentialProvider *provider, GAsyncResult *result, GError **error)
return (gchar *)g_task_propagate_pointer(G_TASK(result), error);
@@ -428,7 +428,7 @@
-purple_kwallet_write_password_finish(PurpleCredentialProvider *provider,
+purple_kwallet_write_password_finish(G_GNUC_UNUSED PurpleCredentialProvider *provider, GAsyncResult *result, GError **error)
return g_task_propagate_boolean(G_TASK(result), error);
@@ -459,7 +459,7 @@
-purple_kwallet_clear_password_finish(PurpleCredentialProvider *provider,
+purple_kwallet_clear_password_finish(G_GNUC_UNUSED PurpleCredentialProvider *provider, GAsyncResult *result, GError **error)
return g_task_propagate_boolean(G_TASK(result), error);
@@ -519,7 +519,7 @@
-purple_kwallet_provider_class_finalize(PurpleKWalletProviderClass *klass) {
+purple_kwallet_provider_class_finalize(G_GNUC_UNUSED PurpleKWalletProviderClass *klass) { /******************************************************************************
--- a/libpurple/plugins/libsecret/libsecret.c Wed Feb 22 22:19:01 2023 -0600
+++ b/libpurple/plugins/libsecret/libsecret.c Wed Feb 22 22:19:57 2023 -0600
@@ -77,8 +77,8 @@
*****************************************************************************/
-purple_libsecret_read_password_callback(GObject *obj, GAsyncResult *result,
+purple_libsecret_read_password_callback(G_GNUC_UNUSED GObject *obj, + GAsyncResult *result, gpointer data) GTask *task = G_TASK(data);
@@ -96,8 +96,8 @@
-purple_libsecret_write_password_callback(GObject *obj, GAsyncResult *result,
+purple_libsecret_write_password_callback(G_GNUC_UNUSED GObject *obj, + GAsyncResult *result, gpointer data) GTask *task = G_TASK(data);
@@ -115,8 +115,8 @@
-purple_libsecret_clear_password_callback(GObject *obj, GAsyncResult *result,
+purple_libsecret_clear_password_callback(G_GNUC_UNUSED GObject *obj, + GAsyncResult *result, gpointer data) GTask *task = G_TASK(data);
@@ -238,7 +238,7 @@
*****************************************************************************/
-purple_libsecret_init(PurpleLibSecret *libsecret) {
+purple_libsecret_init(G_GNUC_UNUSED PurpleLibSecret *libsecret) { @@ -261,7 +261,7 @@
-purple_libsecret_class_finalize(PurpleLibSecretClass *klass) {
+purple_libsecret_class_finalize(G_GNUC_UNUSED PurpleLibSecretClass *klass) { /******************************************************************************
--- a/libpurple/plugins/notification-sound/notification-sound.c Wed Feb 22 22:19:01 2023 -0600
+++ b/libpurple/plugins/notification-sound/notification-sound.c Wed Feb 22 22:19:57 2023 -0600
@@ -126,23 +126,23 @@
*****************************************************************************/
-purple_notification_sound_im_message_received(PurpleAccount *account,
- PurpleConversation *conv,
- PurpleMessageFlags flags,
+purple_notification_sound_im_message_received(G_GNUC_UNUSED PurpleAccount *account, + G_GNUC_UNUSED const gchar *sender, + G_GNUC_UNUSED const gchar *message, + G_GNUC_UNUSED PurpleConversation *conv, + G_GNUC_UNUSED PurpleMessageFlags flags, + G_GNUC_UNUSED gpointer data) purple_notification_sound_play("message-new-instant");
-purple_notification_sound_chat_message_received(PurpleAccount *account,
- PurpleConversation *conv,
- PurpleMessageFlags flags,
+purple_notification_sound_chat_message_received(G_GNUC_UNUSED PurpleAccount *account, + G_GNUC_UNUSED gchar *sender, + G_GNUC_UNUSED gchar *message, + G_GNUC_UNUSED PurpleConversation *conv, + G_GNUC_UNUSED PurpleMessageFlags flags, + G_GNUC_UNUSED gpointer data) purple_notification_sound_play("message-new-instant");
--- a/libpurple/plugins/psychic/psychic.c Wed Feb 22 22:19:01 2023 -0600
+++ b/libpurple/plugins/psychic/psychic.c Wed Feb 22 22:19:57 2023 -0600
@@ -39,7 +39,9 @@
-buddy_typing_cb(PurpleAccount *acct, const char *name, void *data) {
+buddy_typing_cb(PurpleAccount *acct, const char *name, + G_GNUC_UNUSED gpointer data) GSettings *settings = NULL;
PurpleConversationManager *manager;
@@ -92,7 +94,7 @@
static GPluginPluginInfo *
-psychic_query(GError **error) {
+psychic_query(G_GNUC_UNUSED GError **error) { const gchar * const authors[] = PLUGIN_AUTHORS;
return purple_plugin_info_new(
@@ -112,7 +114,7 @@
-psychic_load(GPluginPlugin *plugin, GError **error) {
+psychic_load(GPluginPlugin *plugin, G_GNUC_UNUSED GError **error) { @@ -126,8 +128,10 @@
-psychic_unload(GPluginPlugin *plugin, gboolean shutdown, GError **error) {
+psychic_unload(G_GNUC_UNUSED GPluginPlugin *plugin, + G_GNUC_UNUSED gboolean shutdown, + G_GNUC_UNUSED GError **error) --- a/libpurple/plugins/purple-toast/purple-toast.c Wed Feb 22 22:19:01 2023 -0600
+++ b/libpurple/plugins/purple-toast/purple-toast.c Wed Feb 22 22:19:57 2023 -0600
@@ -74,7 +74,7 @@
purple_toast_find_icon(PurpleAccount *account,
+ G_GNUC_UNUSED const gchar *sender) @@ -126,9 +126,9 @@
purple_toast_im_message_received(PurpleAccount *account,
- PurpleConversation *conv,
- PurpleMessageFlags flags,
+ G_GNUC_UNUSED PurpleConversation *conv, + G_GNUC_UNUSED PurpleMessageFlags flags, + G_GNUC_UNUSED gpointer data) PurpleBuddy *buddy = NULL;
@@ -150,8 +150,8 @@
PurpleConversation *conv,
- PurpleMessageFlags flags,
+ G_GNUC_UNUSED PurpleMessageFlags flags, + G_GNUC_UNUSED gpointer data) PurpleBuddy *buddy = NULL;
--- a/libpurple/plugins/statenotify/statenotify.c Wed Feb 22 22:19:01 2023 -0600
+++ b/libpurple/plugins/statenotify/statenotify.c Wed Feb 22 22:19:57 2023 -0600
@@ -61,7 +61,7 @@
buddy_status_changed_cb(PurpleBuddy *buddy, PurpleStatus *old_status,
- PurpleStatus *status, void *data)
+ PurpleStatus *status, G_GNUC_UNUSED gpointer data) GSettings *settings = NULL;
gboolean available, old_available;
@@ -89,7 +89,7 @@
buddy_idle_changed_cb(PurpleBuddy *buddy, gboolean old_idle, gboolean idle,
+ G_GNUC_UNUSED gpointer data) GSettings *settings = NULL;
@@ -106,7 +106,7 @@
-buddy_signon_cb(PurpleBuddy *buddy, void *data)
+buddy_signon_cb(PurpleBuddy *buddy, G_GNUC_UNUSED gpointer data) GSettings *settings = NULL;
@@ -119,7 +119,7 @@
-buddy_signoff_cb(PurpleBuddy *buddy, void *data)
+buddy_signoff_cb(PurpleBuddy *buddy, G_GNUC_UNUSED gpointer data) GSettings *settings = NULL;
@@ -132,7 +132,7 @@
static GPluginPluginInfo *
-state_notify_query(GError **error)
+state_notify_query(G_GNUC_UNUSED GError **error) const gchar * const authors[] = {
"Christian Hammond <chipx86@gnupdate.org>",
@@ -157,7 +157,7 @@
-state_notify_load(GPluginPlugin *plugin, GError **error)
+state_notify_load(GPluginPlugin *plugin, G_GNUC_UNUSED GError **error) void *blist_handle = purple_blist_get_handle();
@@ -174,7 +174,9 @@
-state_notify_unload(GPluginPlugin *plugin, gboolean shutdown, GError **error)
+state_notify_unload(G_GNUC_UNUSED GPluginPlugin *plugin, + G_GNUC_UNUSED gboolean shutdown, + G_GNUC_UNUSED GError **error)