pidgin/pidgin

facebook: Store sent message id in lastmid, to deduplicate echoed messages

2016-10-22, dequis
6d85d309f8e4
Parents 671723ed2a42
Children 69b44723d52c
facebook: Store sent message id in lastmid, to deduplicate echoed messages

This is crappy and error prone, just like the rest of the duplicate
message handling code. It works, but it's going to get some echoes now
and then, particularly in quick moving groupchats.

I'm pretty sure this is a bug in the server, but the official clients
have much more elaborate deduplication built-in, so they won't notice.
1 files changed, 1 insertions(+), 0 deletions(-)
  • +1 -0
    libpurple/protocols/facebook/api.c
    • --- a/libpurple/protocols/facebook/api.c Wed Oct 19 18:50:39 2016 +0000
    +++ b/libpurple/protocols/facebook/api.c Sat Oct 22 02:16:30 2016 -0300
    @@ -2174,6 +2174,7 @@
    JsonBuilder *bldr;
    mid = FB_API_MSGID(g_get_real_time() / 1000, g_random_int());
    + priv->lastmid = mid;
    if (msg->tid != 0) {
    tpfx = "tfbid_";