pidgin/pidgin

Small bug fix to the wording of add buddy requests.

2014-06-17, Mark Doliner
638471098869
Parents 747e73eab859
Children faba3b092f55
Small bug fix to the wording of add buddy requests.

The text looks like this:
whoever@example.com (John Doe) wants to add you (yourname@example.com) to his or her buddy list: I'm your biggest fan--please let me add you!

The message at the end is optional and we attempt to intelligently show a
colon or a period based on whether the message exists. However, our logic was
wrong and we were keying off the alias field rather than the message field.

Seems like this bug has probably been around for a while, which surprised me.
And I haven't committed anything in a while, so I'm feeling unsure of myself.
1 files changed, 1 insertions(+), 1 deletions(-)
  • +1 -1
    pidgin/gtkaccount.c
    • --- a/pidgin/gtkaccount.c Tue Jun 17 01:56:59 2014 +0200
    +++ b/pidgin/gtkaccount.c Tue Jun 17 21:51:48 2014 -0700
    @@ -2888,7 +2888,7 @@
    escaped_alias,
    (have_valid_alias ? ")" : ""),
    escaped_our_name,
    - (have_valid_alias ? ": " : "."),
    + (*escaped_message ? ": " : "."),
    escaped_message);
    g_free(escaped_remote_user);