pidgin/pidgin

Fix leaks in dynamic menus

14 months ago, Elliott Sales de Andrade
33ed4a2a7593
Parents 0601c6f60bff
Children 08966165974c
Fix leaks in dynamic menus

Fixes two leaks:
```
10,463 (48 direct, 10,415 indirect) bytes in 1 blocks are definitely lost in loss record 34,138 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x1CA978CF: purple_demo_protocol_get_menu (purpledemoprotocolactions.c:750)
by 0x4D2DB1F: purple_protocol_actions_get_menu (purpleprotocolactions.c:110)
by 0x489F74C: pidgin_accounts_enabled_menu_get_item_links (pidginaccountsenabledmenu.c:279)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
```
and
```
2,051 (144 direct, 1,907 indirect) bytes in 3 blocks are definitely lost in loss record 33,018 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x581E9EE: g_menu_item_new_section (gmenu.c:1256)
by 0x48B465F: pidgin_plugins_menu_get_item_links (pidginpluginsmenu.c:204)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
by 0x5124B78: gtk_menu_tracker_add_items (gtkmenutracker.c:313)
```

Testing Done:
Ran in `valgrind --leak-check=full` and confirmed that the leak was gone.

Reviewed at https://reviews.imfreedom.org/r/2298/
2 files changed, 2 insertions(+), 0 deletions(-)
  • +1 -0
    pidgin/pidginaccountsenabledmenu.c
  • +1 -0
    pidgin/pidginpluginsmenu.c
    • --- a/pidgin/pidginaccountsenabledmenu.c Tue Feb 28 03:20:33 2023 -0600
    +++ b/pidgin/pidginaccountsenabledmenu.c Tue Feb 28 03:21:35 2023 -0600
    @@ -280,6 +280,7 @@
    if(G_IS_MENU(protocol_menu)) {
    g_menu_insert_section(submenu, 1, NULL,
    G_MENU_MODEL(protocol_menu));
    + g_object_unref(protocol_menu);
    }
    }
    --- a/pidgin/pidginpluginsmenu.c Tue Feb 28 03:20:33 2023 -0600
    +++ b/pidgin/pidginpluginsmenu.c Tue Feb 28 03:21:35 2023 -0600
    @@ -205,6 +205,7 @@
    g_menu_item_set_attribute(section, G_MENU_ATTRIBUTE_ACTION_NAMESPACE,
    "s", gplugin_plugin_info_get_id(info));
    g_menu_append_item(menu, section);
    + g_object_unref(section);
    g_hash_table_insert(*links, G_MENU_LINK_SUBMENU, menu);
    }