pidgin/pidgin

Fix a use after free scanbuild found in buddyicon.c
release-2.x.y
2021-06-01, Gary Kramlich
c997d298cd4c
Fix a use after free scanbuild found in buddyicon.c

Testing Done:
Verified scanbuild no longer detected the error.

Reviewed at https://reviews.imfreedom.org/r/698/
For information on writing a plugin for Purple, Pidgin or Finch, go
http://developer.pidgin.im and click on API. From there, see the
HOWTOs in the "Related Pages" section.
You can also generate this documentation locally by installing
doxygen and graphviz dot, then running "make docs" in the
source tree. The documentation will be in the docs/html directory.