pidgin/pidgin

Fix a use after free scanbuild found in buddyicon.c
release-2.x.y
2021-06-01, Gary Kramlich
c997d298cd4c
Fix a use after free scanbuild found in buddyicon.c

Testing Done:
Verified scanbuild no longer detected the error.

Reviewed at https://reviews.imfreedom.org/r/698/
REVIEWBOARD_URL = "https://reviews.imfreedom.org/"
REPOSITORY = "pidgin/pidgin"
REPOSITORY_TYPE = "mercurial"
BRANCH = "release-2.x.y"
LAND_DEST_BRANCH = "release-2.x.y"
LAND_PUSH = False