pidgin/pidgin

facebook: Store sent message id in lastmid, to deduplicate echoed messages

2016-10-22, dequis
6d85d309f8e4
facebook: Store sent message id in lastmid, to deduplicate echoed messages

This is crappy and error prone, just like the rest of the duplicate
message handling code. It works, but it's going to get some echoes now
and then, particularly in quick moving groupchats.

I'm pretty sure this is a bug in the server, but the official clients
have much more elaborate deduplication built-in, so they won't notice.
/*
* SoundThemeLoader for libpurple
*
* Pidgin is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#include "internal.h"
#include "sound-theme-loader.h"
#include "sound-theme.h"
#include "util.h"
#include "xmlnode.h"
#include "debug.h"
/*****************************************************************************
* Sound Theme Builder
*****************************************************************************/
static PurpleTheme *
purple_sound_loader_build(const gchar *theme_dir)
{
PurpleXmlNode *root_node = NULL, *sub_node;
gchar *dir, *filename_full, *data = NULL;
PurpleSoundTheme *theme = NULL;
const gchar *name;
/* Find the theme file */
g_return_val_if_fail(theme_dir != NULL, NULL);
dir = g_build_filename(theme_dir, "purple", "sound", NULL);
filename_full = g_build_filename(dir, "theme.xml", NULL);
if (g_file_test(filename_full, G_FILE_TEST_IS_REGULAR))
root_node = purple_xmlnode_from_file(dir, "theme.xml", "sound themes", "sound-theme-loader");
g_free(filename_full);
if (root_node == NULL) {
g_free(dir);
return NULL;
}
name = purple_xmlnode_get_attrib(root_node, "name");
if (name && purple_strequal(purple_xmlnode_get_attrib(root_node, "type"), "sound")) {
/* Parse the tree */
sub_node = purple_xmlnode_get_child(root_node, "description");
data = purple_xmlnode_get_data(sub_node);
if (purple_xmlnode_get_attrib(root_node, "name") != NULL) {
theme = g_object_new(PURPLE_TYPE_SOUND_THEME,
"type", "sound",
"name", name,
"author", purple_xmlnode_get_attrib(root_node, "author"),
"image", purple_xmlnode_get_attrib(root_node, "image"),
"directory", dir,
"description", data, NULL);
sub_node = purple_xmlnode_get_child(root_node, "event");
while (sub_node) {
purple_sound_theme_set_file(theme,
purple_xmlnode_get_attrib(sub_node, "name"),
purple_xmlnode_get_attrib(sub_node, "file"));
sub_node = purple_xmlnode_get_next_twin(sub_node);
}
}
} else purple_debug_warning("sound-theme-loader", "Missing attribute or problem with the root element\n");
purple_xmlnode_free(root_node);
g_free(data);
g_free(dir);
return PURPLE_THEME(theme);
}
/******************************************************************************
* GObject Stuff
*****************************************************************************/
static void
purple_sound_theme_loader_class_init(PurpleSoundThemeLoaderClass *klass)
{
PurpleThemeLoaderClass *loader_klass = PURPLE_THEME_LOADER_CLASS(klass);
loader_klass->purple_theme_loader_build = purple_sound_loader_build;
}
GType
purple_sound_theme_loader_get_type(void)
{
static GType type = 0;
if (type == 0) {
static const GTypeInfo info = {
sizeof(PurpleSoundThemeLoaderClass),
NULL, /* base_init */
NULL, /* base_finalize */
(GClassInitFunc)purple_sound_theme_loader_class_init, /* class_init */
NULL, /* class_finalize */
NULL, /* class_data */
sizeof(PurpleSoundThemeLoader),
0, /* n_preallocs */
NULL, /* instance_init */
NULL, /* value table */
};
type = g_type_register_static(PURPLE_TYPE_THEME_LOADER,
"PurpleSoundThemeLoader", &info, 0);
}
return type;
}