pidgin/pidgin

Fix leaks in dynamic menus

16 months ago, Elliott Sales de Andrade
33ed4a2a7593
Fix leaks in dynamic menus

Fixes two leaks:
```
10,463 (48 direct, 10,415 indirect) bytes in 1 blocks are definitely lost in loss record 34,138 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x1CA978CF: purple_demo_protocol_get_menu (purpledemoprotocolactions.c:750)
by 0x4D2DB1F: purple_protocol_actions_get_menu (purpleprotocolactions.c:110)
by 0x489F74C: pidgin_accounts_enabled_menu_get_item_links (pidginaccountsenabledmenu.c:279)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
```
and
```
2,051 (144 direct, 1,907 indirect) bytes in 3 blocks are definitely lost in loss record 33,018 of 34,479
at 0x484386F: malloc (vg_replace_malloc.c:393)
by 0x4980168: g_malloc (gmem.c:130)
by 0x4997AB5: g_slice_alloc (gslice.c:1074)
by 0x49980EC: g_slice_alloc0 (gslice.c:1100)
by 0x4DDF04B: g_type_create_instance (gtype.c:1913)
by 0x4DC4C1F: g_object_new_internal (gobject.c:2228)
by 0x4DC6247: g_object_new_with_properties (gobject.c:2391)
by 0x4DC6FF0: g_object_new (gobject.c:2037)
by 0x581E9EE: g_menu_item_new_section (gmenu.c:1256)
by 0x48B465F: pidgin_plugins_menu_get_item_links (pidginpluginsmenu.c:204)
by 0x5817C3F: g_menu_model_real_get_item_link (gmenumodel.c:397)
by 0x5124B78: gtk_menu_tracker_add_items (gtkmenutracker.c:313)
```

Testing Done:
Ran in `valgrind --leak-check=full` and confirmed that the leak was gone.

Reviewed at https://reviews.imfreedom.org/r/2298/
/* purple
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* Rewritten from scratch during Google Summer of Code 2012
* by Tomek Wasilczyk (http://www.wasilczyk.pl).
*
* Previously implemented by:
* - Arkadiusz Miskiewicz <misiek@pld.org.pl> - first implementation (2001);
* - Bartosz Oler <bartosz@bzimage.us> - reimplemented during GSoC 2005;
* - Krzysztof Klinikowski <grommasher@gmail.com> - some parts (2009-2011).
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#include "purplew.h"
#include "tcpsocket.h"
#include <glib/gi18n-lib.h>
guint ggp_purplew_http_input_add(struct gg_http *http_req,
PurpleInputFunction func, gpointer user_data)
{
if (purple_debug_is_verbose()) {
purple_debug_misc("gg", "ggp_purplew_http_input_add: "
"[req=%p, fd=%d, cond=%d]\n",
http_req, http_req->fd, http_req->check);
}
return purple_input_add(http_req->fd,
ggp_tcpsocket_inputcond_gg_to_purple(http_req->check),
func, user_data);
}
static void
ggp_purplew_request_processing_cancel(ggp_purplew_request_processing_handle *handle,
G_GNUC_UNUSED gint id)
{
handle->cancel_cb(handle->gc, handle->user_data);
g_free(handle);
}
ggp_purplew_request_processing_handle * ggp_purplew_request_processing(
PurpleConnection *gc, const gchar *msg, void *user_data,
ggp_purplew_request_processing_cancel_cb cancel_cb)
{
ggp_purplew_request_processing_handle *handle =
g_new(ggp_purplew_request_processing_handle, 1);
handle->gc = gc;
handle->cancel_cb = cancel_cb;
handle->user_data = user_data;
handle->request_handle = purple_request_action(gc, _("Please wait..."),
(msg ? msg : _("Please wait...")), NULL,
PURPLE_DEFAULT_ACTION_NONE,
purple_request_cpar_from_connection(gc), handle, 1,
_("Cancel"), G_CALLBACK(ggp_purplew_request_processing_cancel));
return handle;
}
void ggp_purplew_request_processing_done(
ggp_purplew_request_processing_handle *handle)
{
purple_request_close(PURPLE_REQUEST_ACTION, handle->request_handle);
g_free(handle);
}
PurpleGroup * ggp_purplew_buddy_get_group_only(PurpleBuddy *buddy)
{
PurpleGroup *group = purple_buddy_get_group(buddy);
if (!group)
return NULL;
if (0 == g_strcmp0(PURPLE_BLIST_DEFAULT_GROUP_NAME,
purple_group_get_name(group)))
{
return NULL;
}
if (0 == g_strcmp0("Buddies", purple_group_get_name(group)))
return NULL;
return group;
}
GList * ggp_purplew_group_get_buddies(PurpleGroup *group, PurpleAccount *account)
{
GList *buddies = NULL;
PurpleBlistNode *gnode, *cnode, *bnode;
g_return_val_if_fail(group != NULL, NULL);
gnode = PURPLE_BLIST_NODE(group);
for (cnode = gnode->child; cnode; cnode = cnode->next) {
if (!PURPLE_IS_META_CONTACT(cnode))
continue;
for (bnode = cnode->child; bnode; bnode = bnode->next) {
PurpleBuddy *buddy;
if (!PURPLE_IS_BUDDY(bnode))
continue;
buddy = PURPLE_BUDDY(bnode);
if (account == NULL ||
purple_buddy_get_account(buddy) == account)
{
buddies = g_list_append(buddies, buddy);
}
}
}
return buddies;
}
GList * ggp_purplew_account_get_groups(PurpleAccount *account, gboolean exclusive)
{
PurpleBlistNode *bnode;
GList *groups = NULL;
for (bnode = purple_blist_get_default_root(); bnode;
bnode = bnode->next) {
PurpleGroup *group;
GSList *accounts;
gboolean have_specified = FALSE, have_others = FALSE;
if (!PURPLE_IS_GROUP(bnode))
continue;
group = PURPLE_GROUP(bnode);
for (accounts = purple_group_get_accounts(group); accounts;
accounts = g_slist_delete_link(accounts, accounts))
{
if (accounts->data == account)
have_specified = TRUE;
else
have_others = TRUE;
}
if (have_specified && (!exclusive || !have_others))
groups = g_list_append(groups, group);
}
return groups;
}