libgnt/libgnt

fix SIGSEGV when choosing Sounds from Actions menu in Finch
release-2.x.y
2021-07-09, ivanhoe
bb7e6a14ff05
Parents e53e6ee83424
Children b98bfe7c5397
fix SIGSEGV when choosing Sounds from Actions menu in Finch

Testing Done:
Opened Sounds window in Finch.
There's another location in Finch where 'gnt_combo_box_get_dropdown' is called, which I would've liked to test, but I couldn't reach it. It's 'update_selected_account' in gntrequest.c which is triggered by some signal. The signal connection is established when username and accountlist fields are requested in 'finch_request_fields', but I didn't find a window in Finch where that's done (which doesn't mean it doesn't exist, just that I'm too unfamiliar with Finch to know where to look).

Reviewed at https://reviews.imfreedom.org/r/793/
1 files changed, 1 insertions(+), 1 deletions(-)
  • +1 -1
    gntcombobox.c
    • --- a/gntcombobox.c Thu Feb 04 21:45:26 2021 -0600
    +++ b/gntcombobox.c Fri Jul 09 23:08:14 2021 -0500
    @@ -360,7 +360,7 @@
    GntWidget *
    gnt_combo_box_get_dropdown(GntComboBox *box)
    {
    - g_return_val_if_fail(GNT_IS_BOX(box), NULL);
    + g_return_val_if_fail(GNT_IS_COMBO_BOX(box), NULL);
    return box->dropdown;
    }