adium/adium

Improve the speed of fast enumeration by not using the property, as it -copies these ivars.
adium-1.5.4
2012-09-18, Thijs Alkemade
9178c6fa3e1e
Parents f27be96d5839
Children 816c7d80c0e52f86166a0e51
Improve the speed of fast enumeration by not using the property, as it -copies these ivars.

This also fixes a crash with ARC.
3 files changed, 3 insertions(+), 3 deletions(-)
  • +1 -1
    Frameworks/Adium Framework/Source/AIChat.m
  • +1 -1
    Frameworks/Adium Framework/Source/AIListGroup.m
  • +1 -1
    Frameworks/Adium Framework/Source/AIMetaContact.m
    • --- a/Frameworks/Adium Framework/Source/AIChat.m Sat Sep 15 17:32:10 2012 -0400
    +++ b/Frameworks/Adium Framework/Source/AIChat.m Tue Sep 18 12:38:50 2012 +0200
    @@ -1069,7 +1069,7 @@
    - (NSUInteger)countByEnumeratingWithState:(NSFastEnumerationState *)state objects:(id *)stackbuf count:(NSUInteger)len
    {
    - return [self.containedObjects countByEnumeratingWithState:state objects:stackbuf count:len];
    + return [participatingContacts countByEnumeratingWithState:state objects:stackbuf count:len];
    }
    - (BOOL) canContainObject:(id)obj
    --- a/Frameworks/Adium Framework/Source/AIListGroup.m Sat Sep 15 17:32:10 2012 -0400
    +++ b/Frameworks/Adium Framework/Source/AIListGroup.m Tue Sep 18 12:38:50 2012 +0200
    @@ -360,7 +360,7 @@
    - (NSUInteger)countByEnumeratingWithState:(NSFastEnumerationState *)state objects:(id *)stackbuf count:(NSUInteger)len
    {
    - return [self.containedObjects countByEnumeratingWithState:state objects:stackbuf count:len];
    + return [_containedObjects countByEnumeratingWithState:state objects:stackbuf count:len];
    }
    #pragma mark Applescript
    --- a/Frameworks/Adium Framework/Source/AIMetaContact.m Sat Sep 15 17:32:10 2012 -0400
    +++ b/Frameworks/Adium Framework/Source/AIMetaContact.m Tue Sep 18 12:38:50 2012 +0200
    @@ -1038,7 +1038,7 @@
    - (NSUInteger)countByEnumeratingWithState:(NSFastEnumerationState *)state objects:(id *)stackbuf count:(NSUInteger)len
    {
    - return [self.containedObjects countByEnumeratingWithState:state objects:stackbuf count:len];
    + return [_containedObjects countByEnumeratingWithState:state objects:stackbuf count:len];
    }
    #pragma mark Contained Contact sorting