talkatu/talkatu

288e07a83040
Parents 17d112a00a96
Children 69369ead9170
Reorder a g_object_get to not break pidgin.

`g_object_get` will stop at the first error. Pidgin hadn't yet been updated for
the author-name-color property which lead to the timestamp not being filled out
by `g_object_get` and thus broke all messages in Pidgin 3.

Testing Done:
I tested this in the Pidgin tree and then rebuilt it in the talkatu tree.

Reviewed at https://reviews.imfreedom.org/r/753/
--- a/talkatu/talkatuhistoryrow.c Mon Jun 14 04:01:12 2021 -0500
+++ b/talkatu/talkatuhistoryrow.c Mon Jun 14 22:08:14 2021 -0500
@@ -82,14 +82,19 @@
gchar *author = NULL, *contents = NULL, *datetime = NULL;
gboolean edited = FALSE;
+ /* g_object_get will stop getting properties at the first error. So when
+ * a new property is added, it needs to be appended to the end so that
+ * we don't break implementations that haven't added the latest
+ * properties yet.
+ */
g_object_get(
G_OBJECT(row->message),
"author", &author,
- "author-name-color", &author_name_color,
"content-type", &content_type,
"contents", &contents,
"edited", &edited,
"timestamp", &timestamp,
+ "author-name-color", &author_name_color,
NULL
);