qulogic/talkatu

Avoiding doing a switch when we don't need to

2018-09-11, Gary Kramlich
73a756a72f63
Parents 18d1a7dcb04f
Children cb3c17ee2146
Avoiding doing a switch when we don't need to
1 files changed, 34 insertions(+), 32 deletions(-)
  • +34 -32
    talkatu/talkatumarkup.c
    • --- a/talkatu/talkatumarkup.c Tue Sep 11 21:19:36 2018 -0500
    +++ b/talkatu/talkatumarkup.c Tue Sep 11 22:47:30 2018 -0500
    @@ -46,38 +46,40 @@
    start_pos = gtk_text_iter_get_offset(pos);
    - switch(node->v.element.tag) {
    - case GUMBO_TAG_B:
    - tag_name = TALKATU_TAG_BOLD;
    - break;
    - case GUMBO_TAG_CODE:
    - tag_name = TALKATU_TAG_CODE;
    - break;
    - case GUMBO_TAG_I:
    - tag_name = TALKATU_TAG_ITALIC;
    - break;
    - case GUMBO_TAG_U:
    - tag_name = TALKATU_TAG_UNDERLINE;
    - break;
    - case GUMBO_TAG_EM:
    - break;
    - case GUMBO_TAG_STRIKE:
    - tag_name = TALKATU_TAG_STRIKETHROUGH;
    - break;
    - case GUMBO_TAG_SUB:
    - tag_name = TALKATU_TAG_SUBSCRIPT;
    - break;
    - case GUMBO_TAG_SUP:
    - tag_name = TALKATU_TAG_SUPERSCRIPT;
    - break;
    - case GUMBO_TAG_PRE:
    - tag_name = TALKATU_TAG_PRE;
    - break;
    - case GUMBO_TAG_BR:
    - talkatu_buffer_insert_markup(TALKATU_BUFFER(buffer), pos, "\n", -1);
    - break;
    - default:
    - break;
    + if(node->type == GUMBO_NODE_ELEMENT) {
    + switch(node->v.element.tag) {
    + case GUMBO_TAG_B:
    + tag_name = TALKATU_TAG_BOLD;
    + break;
    + case GUMBO_TAG_CODE:
    + tag_name = TALKATU_TAG_CODE;
    + break;
    + case GUMBO_TAG_I:
    + tag_name = TALKATU_TAG_ITALIC;
    + break;
    + case GUMBO_TAG_U:
    + tag_name = TALKATU_TAG_UNDERLINE;
    + break;
    + case GUMBO_TAG_EM:
    + break;
    + case GUMBO_TAG_STRIKE:
    + tag_name = TALKATU_TAG_STRIKETHROUGH;
    + break;
    + case GUMBO_TAG_SUB:
    + tag_name = TALKATU_TAG_SUBSCRIPT;
    + break;
    + case GUMBO_TAG_SUP:
    + tag_name = TALKATU_TAG_SUPERSCRIPT;
    + break;
    + case GUMBO_TAG_PRE:
    + tag_name = TALKATU_TAG_PRE;
    + break;
    + case GUMBO_TAG_BR:
    + talkatu_buffer_insert_markup(TALKATU_BUFFER(buffer), pos, "\n", -1);
    + break;
    + default:
    + break;
    + }
    }
    if(tag_name != NULL) {