HGKeeper

qulogic/pidgin

Only include headers when they're necessary for header files

3 months ago, Gary Kramlich

e868bfcc092a

Parents d2088215e302
Children 05f7fd3db190

Only include headers when they're necessary for header files

This only covers libpurple.

Testing Done:
Ran a clean build

Reviewed at https://reviews.imfreedom.org/r/2898/

33 files changed, 37 insertions(+), 23 deletions(-)

+2 -0

libpurple/accounts.c

+0 -1

libpurple/accounts.h

+0 -2

libpurple/buddyicon.h

+1 -0

libpurple/contact.c

+2 -1

libpurple/conversations.c

+0 -3

libpurple/group.h

+1 -0

libpurple/media.h

+1 -0

libpurple/mediamanager.c

+2 -0

libpurple/plugins.c

+3 -0

libpurple/protocols.c

+1 -0

libpurple/proxy.c

+0 -1

libpurple/proxy.h

+0 -1

libpurple/purpleaccount.h

+1 -0

libpurple/purpleaccountpresence.c

+2 -0

libpurple/purplebuddypresence.c

+1 -1

libpurple/purplebuddypresence.h

+2 -0

libpurple/purplechatconversation.c

+1 -0

libpurple/purpleconversation.c

+1 -0

libpurple/purplecredentialmanager.c

+1 -0

libpurple/purplegio.c

+1 -0

libpurple/purpleimconversation.c

+2 -0

libpurple/purpleprotocol.c

+0 -5

libpurple/purpleprotocol.h

+1 -0

libpurple/purpleprotocolchat.h

+2 -0

libpurple/purpleprotocolclient.c

+2 -1

libpurple/purpleprotocolclient.h

+1 -0

libpurple/savedstatuses.c

+1 -0

+1 -3

+1 -0

+1 -4

+1 -0

+1 -0

~~--- a/libpurple/accounts.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/accounts.c Sun Dec 31 21:56:51 2023 -0600

@@ -25,6 +25,8 @@

#include "core.h"

#include "debug.h"

#include "network.h"

+#include "notify.h"

+#include "prefs.h"

#include "purpleaccountmanager.h"

#include "purpleconversationmanager.h"

#include "purplecredentialmanager.h"

~~--- a/libpurple/accounts.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/accounts.h Sun Dec 31 21:56:51 2023 -0600

@@ -28,7 +28,6 @@

#include "purpleaccount.h"

#include "purpleversion.h"

~~-#include "status.h"~~

G_BEGIN_DECLS

~~--- a/libpurple/buddyicon.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/buddyicon.h Sun Dec 31 21:56:51 2023 -0600

@@ -47,10 +47,8 @@

typedef struct _PurpleBuddyIconSpec PurpleBuddyIconSpec;

~~-#include "blistnode.h"~~

#include "buddylist.h"

#include "image.h"

~~-#include "protocols.h"~~

#include "purpleaccount.h"

#include "purpleversion.h"

#include "util.h"

~~--- a/libpurple/contact.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/contact.c Sun Dec 31 21:56:51 2023 -0600

@@ -22,6 +22,7 @@

#include "contact.h"

+#include "prefs.h"

#include "purplebuddypresence.h"

#include "purpleconversationmanager.h"

#include "purpleprivate.h"

~~--- a/libpurple/conversations.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/conversations.c Sun Dec 31 21:56:51 2023 -0600

@@ -21,8 +21,9 @@

#include "conversations.h"

+#include "prefs.h"

#include "purpleprivate.h"

#include "purpleconversationmanager.h"

static PurpleConversationUiOps *default_ops = NULL;

~~--- a/libpurple/group.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/group.h Sun Dec 31 21:56:51 2023 -0600

@@ -38,11 +38,8 @@

typedef struct _PurpleGroup PurpleGroup;

typedef struct _PurpleGroupClass PurpleGroupClass;

~~-#include "blistnode.h"~~

~~-#include "buddyicon.h"~~

#include "purpleaccount.h"

#include "purpleversion.h"

~~-#include "status.h"~~

/**************************************************************************/

/* Data Structures */

~~--- a/libpurple/media.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/media.h Sun Dec 31 21:56:51 2023 -0600

@@ -42,6 +42,7 @@

#define PURPLE_IS_MEDIA_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE((klass), PURPLE_TYPE_MEDIA))

#define PURPLE_MEDIA_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS((obj), PURPLE_TYPE_MEDIA, PurpleMediaClass))

+#include "purpleaccount.h"

#include "purpleversion.h"

#include "signals.h"

#include "util.h"

~~--- a/libpurple/mediamanager.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/mediamanager.c Sun Dec 31 21:56:51 2023 -0600

@@ -25,6 +25,7 @@

#include "glibcompat.h"

#include "media.h"

#include "mediamanager.h"

+#include "prefs.h"

#include "purpleaccount.h"

#include "purplepath.h"

~~--- a/libpurple/plugins.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/plugins.c Sun Dec 31 21:56:51 2023 -0600

@@ -26,7 +26,9 @@

#include "core.h"

#include "debug.h"

+#include "notify.h"

#include "plugins.h"

+#include "prefs.h"

#include "purpleenums.h"

#include "purplenotification.h"

#include "purplenotificationmanager.h"

~~--- a/libpurple/protocols.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/protocols.c Sun Dec 31 21:56:51 2023 -0600

@@ -23,6 +23,9 @@

#include <glib/gi18n-lib.h>

+#include "protocols.h"

+#include "accounts.h"

#include "debug.h"

#include "network.h"

#include "notify.h"

~~--- a/libpurple/proxy.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/proxy.c Sun Dec 31 21:56:51 2023 -0600

@@ -23,6 +23,7 @@

#include <glib/gi18n-lib.h>

#include "debug.h"

+#include "eventloop.h"

#include "notify.h"

#include "prefs.h"

#include "proxy.h"

~~--- a/libpurple/proxy.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/proxy.h Sun Dec 31 21:56:51 2023 -0600

@@ -29,7 +29,6 @@

#include <glib.h>

#include <gio/gio.h>

~~-#include "eventloop.h"~~

#include "purpleaccount.h"

#include "purpleproxyinfo.h"

#include "purpleversion.h"

~~--- a/libpurple/purpleaccount.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purpleaccount.h Sun Dec 31 21:56:51 2023 -0600

@@ -34,7 +34,6 @@

typedef struct _PurpleAccount PurpleAccount;

~~-#include "buddy.h"~~

#include "connection.h"

#include "group.h"

#include "purpleconnectionerrorinfo.h"

~~--- a/libpurple/purpleaccountpresence.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purpleaccountpresence.c Sun Dec 31 21:56:51 2023 -0600

@@ -23,6 +23,7 @@

#include "purpleaccountpresence.h"

+#include "protocols.h"

#include "purpleprotocolserver.h"

struct _PurpleAccountPresence {

~~--- a/libpurple/purplebuddypresence.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purplebuddypresence.c Sun Dec 31 21:56:51 2023 -0600

@@ -23,6 +23,8 @@

#include "purplebuddypresence.h"

+#include "prefs.h"

+#include "protocols.h"

#include "purpleprivate.h"

struct _PurpleBuddyPresence {

~~--- a/libpurple/purplebuddypresence.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purplebuddypresence.h Sun Dec 31 21:56:51 2023 -0600

@@ -26,7 +26,7 @@

#ifndef PURPLE_BUDDY_PRESENCE_H

#define PURPLE_BUDDY_PRESENCE_H

~~-#include "buddylist.h"~~

+#include "buddy.h"

#include "purplepresence.h"

#include "purpleversion.h"

~~--- a/libpurple/purplechatconversation.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purplechatconversation.c Sun Dec 31 21:56:51 2023 -0600

@@ -22,7 +22,9 @@

#include <glib/gi18n-lib.h>

+#include "conversations.h"

#include "debug.h"

+#include "prefs.h"

#include "purplecontactmanager.h"

#include "purpleconversationmanager.h"

#include "purplechatconversation.h"

~~--- a/libpurple/purpleconversation.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purpleconversation.c Sun Dec 31 21:56:51 2023 -0600

@@ -22,6 +22,7 @@

#include "conversations.h"

#include "debug.h"

+#include "notify.h"

#include "purpleconversationmanager.h"

#include "purpleconversationmember.h"

#include "purpleenums.h"

~~--- a/libpurple/purplecredentialmanager.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purplecredentialmanager.c Sun Dec 31 21:56:51 2023 -0600

@@ -22,6 +22,7 @@

#include "core.h"

#include "debug.h"

+#include "notify.h"

#include "prefs.h"

#include "purplenoopcredentialprovider.h"

#include "purpleprivate.h"

~~--- a/libpurple/purplegio.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purplegio.c Sun Dec 31 21:56:51 2023 -0600

@@ -23,6 +23,7 @@

#include "purplegio.h"

#include "debug.h"

+#include "prefs.h"

#include "proxy.h"

typedef struct {

~~--- a/libpurple/purpleimconversation.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purpleimconversation.c Sun Dec 31 21:56:51 2023 -0600

@@ -23,6 +23,7 @@

#include "debug.h"

#include "conversations.h"

+#include "prefs.h"

#include "purpleconversationmanager.h"

#include "purpleenums.h"

#include "purpleprivate.h"

~~--- a/libpurple/purpleprotocol.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purpleprotocol.c Sun Dec 31 21:56:51 2023 -0600

@@ -22,6 +22,8 @@

#include "purpleprotocol.h"

+#include "notify.h"

+#include "prefs.h"

#include "purpleaccountmanager.h"

#include "purpleenums.h"

~~--- a/libpurple/purpleprotocol.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purpleprotocol.h Sun Dec 31 21:56:51 2023 -0600

@@ -48,13 +48,8 @@

#include "buddyicon.h"

#include "connection.h"

~~-#include "image.h"~~

#include "purpleaccount.h"

~~-#include "purpleaccountoption.h"~~

~~-#include "purpleaccountusersplit.h"~~

~~-#include "purplemessage.h"~~

#include "purplewhiteboardops.h"

~~-#include "status.h"~~

/**

* PurpleProtocolOptions:

~~--- a/libpurple/purpleprotocolchat.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purpleprotocolchat.h Sun Dec 31 21:56:51 2023 -0600

@@ -31,6 +31,7 @@

#include <glib-object.h>

#include "connection.h"

+#include "purpleconversation.h"

#include "purplemessage.h"

#include "purpleprotocol.h"

#include "purpleversion.h"

~~--- a/libpurple/purpleprotocolclient.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purpleprotocolclient.c Sun Dec 31 21:56:51 2023 -0600

@@ -22,6 +22,8 @@

#include "purpleprotocolclient.h"

+#include "purpleconversation.h"

/******************************************************************************

* GObject Implementation

*****************************************************************************/

~~--- a/libpurple/purpleprotocolclient.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/purpleprotocolclient.h Sun Dec 31 21:56:51 2023 -0600

@@ -30,8 +30,9 @@

#include <glib.h>

#include <glib-object.h>

+#include "connection.h"

#include "purpleaccount.h"

~~-#include "connection.h"~~

+#include "purpleconversation.h"

#include "purpleprotocol.h"

#include "purpleversion.h"

~~--- a/libpurple/savedstatuses.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/savedstatuses.c Sun Dec 31 21:56:51 2023 -0600

@@ -25,6 +25,7 @@

#include "debug.h"

#include "idle.h"

#include "notify.h"

+#include "prefs.h"

#include "purpleaccountmanager.h"

#include "purplemarkup.h"

#include "savedstatuses.h"

~~--- a/libpurple/server.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/server.c Sun Dec 31 21:56:51 2023 -0600

@@ -26,6 +26,7 @@

#include <glib/gi18n-lib.h>

#include "buddylist.h"

+#include "conversations.h"

#include "debug.h"

#include "notify.h"

#include "prefs.h"

~~--- a/libpurple/server.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/server.h Sun Dec 31 21:56:51 2023 -0600

@@ -27,10 +27,8 @@

#ifndef PURPLE_SERVER_H

#define PURPLE_SERVER_H

~~-#include "accounts.h"~~

~~-#include "conversations.h"~~

+#include "buddy.h"

#include "group.h"

~~-#include "protocols.h"~~

#include "purpleimconversation.h"

#include "purplemessage.h"

#include "purpleversion.h"

~~--- a/libpurple/status.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/status.c Sun Dec 31 21:56:51 2023 -0600

@@ -28,6 +28,7 @@

#include "debug.h"

#include "notify.h"

#include "prefs.h"

+#include "protocols.h"

#include "purpleaccountpresence.h"

#include "purplebuddypresence.h"

#include "status.h"

~~--- a/libpurple/util.h Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/util.h Sun Dec 31 21:56:51 2023 -0600

@@ -29,13 +29,10 @@

#include <stdio.h>

~~-#include "signals.h"~~

~~-#include "xmlnode.h"~~

~~-#include "notify.h"~~

~~-#include "protocols.h"~~

#include "purpleaccount.h"

#include "purpleprotocol.h"

#include "purpleversion.h"

+#include "xmlnode.h"

G_BEGIN_DECLS

~~--- a/libpurple/xfer.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/xfer.c Sun Dec 31 21:56:51 2023 -0600

@@ -27,6 +27,7 @@

#include <glib/gstdio.h>

#include "debug.h"

+#include "eventloop.h"

#include "glibcompat.h"

#include "image-store.h"

#include "network.h"

~~--- a/libpurple/xmlnode.c Sat Dec 30 20:44:40 2023 -0600~~

+++ b/libpurple/xmlnode.c Sun Dec 31 21:56:51 2023 -0600

@@ -32,6 +32,7 @@

#include <string.h>

#include <glib.h>

+#include "notify.h"

#include "purplemarkup.h"

#include "util.h"

#include "xmlnode.h"