qulogic/pidgin

Fix DLL naming in metadata on Windows

7 months ago, Elliott Sales de Andrade
860c2eed1a73
Parents 20a6cf622004
Children 409148c5c5b7
Fix DLL naming in metadata on Windows

Meson does not prefix the shared library names with `lib` on Windows, so these
internal metadata fields should not include it. And the Pidgin executable
wrapper needs to load this DLL via the un-prefixed name as well (via
`LIBPIDGIN_DLL_NAMEW`).

Testing Done:
Compiled on Windows.

Reviewed at https://reviews.imfreedom.org/r/2772/
4 files changed, 8 insertions(+), 9 deletions(-)
  • +3 -3
    libpurple/win32/libpurplerc.rc.in
  • +1 -2
    meson.build
  • +2 -2
    pidgin/win32/pidgin_dll_rc.rc.in
  • +2 -2
    pidgin/win32/pidgin_exe_rc.rc.in
    • --- a/libpurple/win32/libpurplerc.rc.in Thu Nov 02 22:46:31 2023 -0500
    +++ b/libpurple/win32/libpurplerc.rc.in Thu Nov 02 23:27:05 2023 -0500
    @@ -16,10 +16,10 @@
    VALUE "CompanyName", "The Pidgin developer community"
    VALUE "FileDescription", "libpurple library"
    VALUE "FileVersion", "@PURPLE_VERSION@"
    - VALUE "InternalName", "libpurple"
    + VALUE "InternalName", "purple3"
    VALUE "LegalCopyright", "Copyright (C) 1998-2014 The Pidgin developer community (See the COPYRIGHT file in the source distribution)."
    - VALUE "OriginalFilename", "libpurple-@PURPLE_API_VERSION@.dll"
    - VALUE "ProductName", "libpurple"
    + VALUE "OriginalFilename", "purple3-@PURPLE_API_VERSION@.dll"
    + VALUE "ProductName", "purple3"
    VALUE "ProductVersion", "@PURPLE_VERSION@"
    END
    END
    --- a/meson.build Thu Nov 02 22:46:31 2023 -0500
    +++ b/meson.build Thu Nov 02 23:27:05 2023 -0500
    @@ -101,8 +101,7 @@
    dnsapi = compiler.find_library('dnsapi')
    conf.set('WIN32_LEAN_AND_MEAN', true)
    - conf.set('LIBPIDGIN_DLL_NAMEW',
    - f'L"libpidgin3-@purple_soversion@.dll"')
    + conf.set('LIBPIDGIN_DLL_NAMEW', f'L"pidgin3-@purple_soversion@.dll"')
    else
    IS_WIN32 = false
    ws2_32 = []
    --- a/pidgin/win32/pidgin_dll_rc.rc.in Thu Nov 02 22:46:31 2023 -0500
    +++ b/pidgin/win32/pidgin_dll_rc.rc.in Thu Nov 02 23:27:05 2023 -0500
    @@ -17,9 +17,9 @@
    VALUE "CompanyName", "The Pidgin developer community"
    VALUE "FileDescription", "Pidgin UI library"
    VALUE "FileVersion", "@PURPLE_VERSION@"
    - VALUE "InternalName", "libpidgin"
    + VALUE "InternalName", "pidgin3"
    VALUE "LegalCopyright", "Copyright (C) 1998-2014 The Pidgin developer community (See the COPYRIGHT file in the source distribution)."
    - VALUE "OriginalFilename", "libpidgin-@PURPLE_API_VERSION@.dll"
    + VALUE "OriginalFilename", "pidgin3-@PURPLE_API_VERSION@.dll"
    VALUE "ProductName", "Pidgin"
    VALUE "ProductVersion", "@PURPLE_VERSION@"
    END
    --- a/pidgin/win32/pidgin_exe_rc.rc.in Thu Nov 02 22:46:31 2023 -0500
    +++ b/pidgin/win32/pidgin_exe_rc.rc.in Thu Nov 02 23:27:05 2023 -0500
    @@ -17,9 +17,9 @@
    VALUE "CompanyName", "The Pidgin developer community"
    VALUE "FileDescription", "Pidgin instant messenger"
    VALUE "FileVersion", "@PURPLE_VERSION@"
    - VALUE "InternalName", "pidgin"
    + VALUE "InternalName", "pidgin3"
    VALUE "LegalCopyright", "Copyright (C) 1998-2014 The Pidgin developer community (See the COPYRIGHT file in the source distribution)."
    - VALUE "OriginalFilename", "pidgin.exe"
    + VALUE "OriginalFilename", "pidgin3.exe"
    VALUE "ProductName", "Pidgin"
    VALUE "ProductVersion", "@PURPLE_VERSION@"
    END