qulogic/pidgin

Stop using g_uri_escape_string() to escape the URI before launching it.
release-2.x.y
2014-01-13, Mark Doliner
41e1147347a5
Stop using g_uri_escape_string() to escape the URI before launching it.

This was wrong. Take this URL as an example:
https://developer.pidgin.im/search?q=brains&noquickjump=1&wiki=on

When escaped with g_uri_escape_string() it becomes:
https://developer.pidgin.im/search%3Fq%3Dbrains%26noquickjump%3D1%26wiki%3Don

?, = and & are replaced with %3F, %3D and %26 which means they are considered part of the path component rather than query args. I tested and I get 404s when launching that URL with Firefox, Google Chrome, and these manual commands: gnome-open, xdg-open, firefox, google-chrome.

Strangely I DON'T get a 404 when I launch the URL with Konqueror. The original unescaped URL loads. I consider this to be a bug in Konqueror. They would fail to load when launched with a URL that has a question mark as part of the path component because they would convert the remaining path into the query string.

So I ripped out uri_escaped and used uri in its place everywhere.

This bug never got released. We changed the behavior because someone reported
to us that this URL:
http://example.org/$(xterm)
caused xterm to be executed on his system. Obviously that's bad if that
happens, but I don't think it's a bug in Pidgin. We're correctly escaping
all arguments that we pass to the browser command. If a system unescapes those
at some point and execs them, then that system is dangerously broken.

I tested this newest code with Firefox, Google Chrome, Konqueror, and the
manual commands gnome-open and xdg-open and they all work perfectly for me.
/**
* @file eventloop.c Purple Event Loop API
* @ingroup core
*/
/* purple
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#include "internal.h"
#include "eventloop.h"
static PurpleEventLoopUiOps *eventloop_ui_ops = NULL;
guint
purple_timeout_add(guint interval, GSourceFunc function, gpointer data)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
return ops->timeout_add(interval, function, data);
}
guint
purple_timeout_add_seconds(guint interval, GSourceFunc function, gpointer data)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
if (ops->timeout_add_seconds)
return ops->timeout_add_seconds(interval, function, data);
else
return ops->timeout_add(1000 * interval, function, data);
}
gboolean
purple_timeout_remove(guint tag)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
return ops->timeout_remove(tag);
}
guint
purple_input_add(int source, PurpleInputCondition condition, PurpleInputFunction func, gpointer user_data)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
return ops->input_add(source, condition, func, user_data);
}
gboolean
purple_input_remove(guint tag)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
return ops->input_remove(tag);
}
int
purple_input_get_error(int fd, int *error)
{
PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops();
if (ops->input_get_error)
{
int ret = ops->input_get_error(fd, error);
errno = *error;
return ret;
}
else
{
socklen_t len;
len = sizeof(*error);
return getsockopt(fd, SOL_SOCKET, SO_ERROR, error, &len);
}
}
void
purple_eventloop_set_ui_ops(PurpleEventLoopUiOps *ops)
{
eventloop_ui_ops = ops;
}
PurpleEventLoopUiOps *
purple_eventloop_get_ui_ops(void)
{
g_return_val_if_fail(eventloop_ui_ops != NULL, NULL);
return eventloop_ui_ops;
}