qulogic/pidgin

Stop using g_uri_escape_string() to escape the URI before launching it.
release-2.x.y
2014-01-13, Mark Doliner
41e1147347a5
Stop using g_uri_escape_string() to escape the URI before launching it.

This was wrong. Take this URL as an example:
https://developer.pidgin.im/search?q=brains&noquickjump=1&wiki=on

When escaped with g_uri_escape_string() it becomes:
https://developer.pidgin.im/search%3Fq%3Dbrains%26noquickjump%3D1%26wiki%3Don

?, = and & are replaced with %3F, %3D and %26 which means they are considered part of the path component rather than query args. I tested and I get 404s when launching that URL with Firefox, Google Chrome, and these manual commands: gnome-open, xdg-open, firefox, google-chrome.

Strangely I DON'T get a 404 when I launch the URL with Konqueror. The original unescaped URL loads. I consider this to be a bug in Konqueror. They would fail to load when launched with a URL that has a question mark as part of the path component because they would convert the remaining path into the query string.

So I ripped out uri_escaped and used uri in its place everywhere.

This bug never got released. We changed the behavior because someone reported
to us that this URL:
http://example.org/$(xterm)
caused xterm to be executed on his system. Obviously that's bad if that
happens, but I don't think it's a bug in Pidgin. We're correctly escaping
all arguments that we pass to the browser command. If a system unescapes those
at some point and execs them, then that system is dangerously broken.

I tested this newest code with Firefox, Google Chrome, Konqueror, and the
manual commands gnome-open and xdg-open and they all work perfectly for me.
/**
* @file debug.h Debug API
* @ingroup core
*/
/* purple
*
* Purple is the legal property of its developers, whose names are too numerous
* to list here. Please refer to the COPYRIGHT file distributed with this
* source distribution.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#ifndef _PURPLE_DEBUG_H_
#define _PURPLE_DEBUG_H_
#include <glib.h>
#include <stdarg.h>
/**
* Debug levels.
*/
typedef enum
{
PURPLE_DEBUG_ALL = 0, /**< All debug levels. */
PURPLE_DEBUG_MISC, /**< General chatter. */
PURPLE_DEBUG_INFO, /**< General operation Information. */
PURPLE_DEBUG_WARNING, /**< Warnings. */
PURPLE_DEBUG_ERROR, /**< Errors. */
PURPLE_DEBUG_FATAL /**< Fatal errors. */
} PurpleDebugLevel;
/**
* Debug UI operations.
*/
typedef struct
{
void (*print)(PurpleDebugLevel level, const char *category,
const char *arg_s);
gboolean (*is_enabled)(PurpleDebugLevel level,
const char *category);
void (*_purple_reserved1)(void);
void (*_purple_reserved2)(void);
void (*_purple_reserved3)(void);
void (*_purple_reserved4)(void);
} PurpleDebugUiOps;
#ifdef __cplusplus
extern "C" {
#endif
/**************************************************************************/
/** @name Debug API */
/**************************************************************************/
/**
* Outputs debug information.
*
* @param level The debug level.
* @param category The category (or @c NULL).
* @param format The format string.
*/
void purple_debug(PurpleDebugLevel level, const char *category,
const char *format, ...) G_GNUC_PRINTF(3, 4);
/**
* Outputs misc. level debug information.
*
* This is a wrapper for purple_debug(), and uses PURPLE_DEBUG_MISC as
* the level.
*
* @param category The category (or @c NULL).
* @param format The format string.
*
* @see purple_debug()
*/
void purple_debug_misc(const char *category, const char *format, ...) G_GNUC_PRINTF(2, 3);
/**
* Outputs info level debug information.
*
* This is a wrapper for purple_debug(), and uses PURPLE_DEBUG_INFO as
* the level.
*
* @param category The category (or @c NULL).
* @param format The format string.
*
* @see purple_debug()
*/
void purple_debug_info(const char *category, const char *format, ...) G_GNUC_PRINTF(2, 3);
/**
* Outputs warning level debug information.
*
* This is a wrapper for purple_debug(), and uses PURPLE_DEBUG_WARNING as
* the level.
*
* @param category The category (or @c NULL).
* @param format The format string.
*
* @see purple_debug()
*/
void purple_debug_warning(const char *category, const char *format, ...) G_GNUC_PRINTF(2, 3);
/**
* Outputs error level debug information.
*
* This is a wrapper for purple_debug(), and uses PURPLE_DEBUG_ERROR as
* the level.
*
* @param category The category (or @c NULL).
* @param format The format string.
*
* @see purple_debug()
*/
void purple_debug_error(const char *category, const char *format, ...) G_GNUC_PRINTF(2, 3);
/**
* Outputs fatal error level debug information.
*
* This is a wrapper for purple_debug(), and uses PURPLE_DEBUG_ERROR as
* the level.
*
* @param category The category (or @c NULL).
* @param format The format string.
*
* @see purple_debug()
*/
void purple_debug_fatal(const char *category, const char *format, ...) G_GNUC_PRINTF(2, 3);
/**
* Enable or disable printing debug output to the console.
*
* @param enabled TRUE to enable debug output or FALSE to disable it.
*/
void purple_debug_set_enabled(gboolean enabled);
/**
* Check if console debug output is enabled.
*
* @return TRUE if debugging is enabled, FALSE if it is not.
*/
gboolean purple_debug_is_enabled(void);
/**
* Enable or disable verbose debugging. This ordinarily should only be called
* by #purple_debug_init, but there are cases where this can be useful for
* plugins.
*
* @param verbose TRUE to enable verbose debugging or FALSE to disable it.
*
* @since 2.6.0
*/
void purple_debug_set_verbose(gboolean verbose);
/**
* Check if verbose logging is enabled.
*
* @return TRUE if verbose debugging is enabled, FALSE if it is not.
*
* @since 2.6.0
*/
gboolean purple_debug_is_verbose(void);
/**
* Enable or disable unsafe debugging. This ordinarily should only be called
* by #purple_debug_init, but there are cases where this can be useful for
* plugins.
*
* @param unsafe TRUE to enable debug logging of messages that could
* potentially contain passwords and other sensitive information.
* FALSE to disable it.
*
* @since 2.6.0
*/
void purple_debug_set_unsafe(gboolean unsafe);
/**
* Check if unsafe debugging is enabled. Defaults to FALSE.
*
* @return TRUE if the debug logging of all messages is enabled, FALSE
* if messages that could potentially contain passwords and other
* sensitive information are not logged.
*
* @since 2.6.0
*/
gboolean purple_debug_is_unsafe(void);
/*@}*/
/**************************************************************************/
/** @name UI Registration Functions */
/**************************************************************************/
/*@{*/
/**
* Sets the UI operations structure to be used when outputting debug
* information.
*
* @param ops The UI operations structure.
*/
void purple_debug_set_ui_ops(PurpleDebugUiOps *ops);
/**
* Returns the UI operations structure used when outputting debug
* information.
*
* @return The UI operations structure in use.
*/
PurpleDebugUiOps *purple_debug_get_ui_ops(void);
/*@}*/
/**************************************************************************/
/** @name Debug Subsystem */
/**************************************************************************/
/*@{*/
/**
* Initializes the debug subsystem.
*/
void purple_debug_init(void);
/*@}*/
#ifdef __cplusplus
}
#endif
#endif /* _PURPLE_DEBUG_H_ */