qulogic/libgnt

Don't leak strings in multiwin test.

2019-05-20, Elliott Sales de Andrade
99622fd01fd2
Parents 508138ca5113
Children 4e6d829dcbc5
Don't leak strings in multiwin test.
1 files changed, 12 insertions(+), 6 deletions(-)
  • +12 -6
    test/multiwin.c
    • --- a/test/multiwin.c Sun May 19 22:47:23 2019 -0400
    +++ b/test/multiwin.c Mon May 20 01:19:46 2019 -0400
    @@ -21,6 +21,8 @@
    #endif
    GntWidget *hbox, *tree, *box2;
    + gchar buf[(430 - 110) * 4]; /* 3 digits + NUL each */
    + gint i;
    hbox = gnt_box_new(FALSE, TRUE);
    box2 = gnt_box_new(FALSE, TRUE);
    @@ -65,12 +67,16 @@
    gnt_tree_add_row_after(GNT_TREE(tree), "6", gnt_tree_create_row(GNT_TREE(tree), "6", " long text", "a2"), "4", NULL);
    - int i;
    - for (i = 110; i < 430; i++)
    - {
    - char *s;
    - s = g_strdup_printf("%d", i); /* XXX: yes, leaking */
    - gnt_tree_add_row_after(GNT_TREE(tree), s, gnt_tree_create_row(GNT_TREE(tree), s, " long text", "a2"), "4", NULL);
    + for (i = 110; i < 430; i++) {
    + gchar *s = buf + (i - 110) * 4;
    + gint n = sizeof(buf) - (i - 110) * 4;
    + if (g_snprintf(s, n, "%d", i) > n) {
    + g_assert_not_reached();
    + }
    + gnt_tree_add_row_after(GNT_TREE(tree), s,
    + gnt_tree_create_row(GNT_TREE(tree), s,
    + " long text", "a2"),
    + "4", NULL);
    }
    gnt_tree_set_row_flags(GNT_TREE(tree), "e", GNT_TEXT_FLAG_DIM);