qulogic/gplugin

Fix some issues found in review, including clearing an error.
feature/dependency-cleanup
2020-02-18, Gary Kramlich
82e7038e37cf
Parents c22c12ab0630
Children dd9e65044ecf
Fix some issues found in review, including clearing an error.
1 files changed, 8 insertions(+), 5 deletions(-)
  • +8 -5
    gplugin/gplugin-manager.c
    • --- a/gplugin/gplugin-manager.c Mon Feb 10 05:14:14 2020 -0600
    +++ b/gplugin/gplugin-manager.c Tue Feb 18 22:08:46 2020 -0600
    @@ -1281,15 +1281,15 @@
    * @op: one of <, <=, =, ==, >=, >.
    * @version: The version to compare against.
    *
    - * Similar to #gplugin_manager_find_plugins but only returns plugins whose
    + * Similar to gplugin_manager_find_plugins() but only returns plugins whose
    * versions match @op and @version. This is primarily used for dependency
    * loading where a plugin may depend on a specific range of versions of another
    * plugin.
    *
    - * Return value: (element-type GPlugin.Plugin) (transfer full): A #GSList of
    - * referenced #GPluginPlugin's matching @id. Call
    - * #gplugin_manager_free_plugin_list on the returned value
    - * when you're done with it.
    + * Returns: (element-type GPlugin.Plugin) (transfer full): A #GSList of
    + * referenced #GPluginPlugin's matching @id. Call
    + * gplugin_manager_free_plugin_list() on the returned value when
    + * you're done with it.
    */
    GSList *
    gplugin_manager_find_plugins_with_version(const gchar *id, const gchar *op,
    @@ -1331,6 +1331,9 @@
    g_warning("failed to compare versions for %s: %s",
    id,
    error->message ? error->message : _("unknown error"));
    +
    + g_clear_error(&error);
    +
    continue;
    }