pidgin/pidgin

Fix coverity 1255961

2016-12-10, Gary Kramlich
fc165e1fd761
Parents ca1489360439
Children 5a226afe38c9
Fix coverity 1255961
1 files changed, 7 insertions(+), 2 deletions(-)
  • +7 -2
    libpurple/protocols/oscar/family_chat.c
    • --- a/libpurple/protocols/oscar/family_chat.c Sat Dec 10 16:59:21 2016 -0600
    +++ b/libpurple/protocols/oscar/family_chat.c Sat Dec 10 17:33:46 2016 -0600
    @@ -174,8 +174,13 @@
    * XXX mkcookie should generate the cookie and cache it in one
    * operation to preserve uniqueness.
    */
    - for (i = 0; i < 8; i++)
    - ckstr[i] = (guint8)rand();
    + for (i = 0; i < 8; i += 4) {
    + gint32 rnd = g_random_int();
    + ckstr[i] = (guint8)((rnd & 0xFF000000) >> 24);
    + ckstr[i+1] = (guint8)((rnd & 0xFF0000) >> 16);
    + ckstr[i+2] = (guint8)((rnd & 0xFF00) >> 8);
    + ckstr[i+3] = (guint8)(rnd & 0xFF);
    + }
    cookie = aim_mkcookie(ckstr, AIM_COOKIETYPE_CHAT, NULL);
    cookie->data = NULL; /* XXX store something useful here */