pidgin/pidgin

Fix a crash in the wincred providered when adding a password.

2021-04-19, Gary Kramlich
fad949437ff6
Parents 2bd48c93678a
Children 9b65f18443aa
Fix a crash in the wincred providered when adding a password.

Something about the way the freeing works on Windows causes a segfault if we memset the memory to 0 first.

Testing Done:
Created a new account, stored the password, verified it was in the Credential Manager and that Pidgin didn't crash.

Reviewed at https://reviews.imfreedom.org/r/622/
1 files changed, 0 insertions(+), 1 deletions(-)
  • +0 -1
    libpurple/plugins/keyrings/wincred.c
    • --- a/libpurple/plugins/keyrings/wincred.c Mon Apr 19 20:34:32 2021 -0500
    +++ b/libpurple/plugins/keyrings/wincred.c Mon Apr 19 20:51:00 2021 -0500
    @@ -240,7 +240,6 @@
    g_free(target_name);
    g_free(username_utf16);
    - memset(password_utf16, 0, password_len * sizeof(gunichar));
    g_free(password_utf16);
    if (error != NULL) {