pidgin/pidgin

Don't reuse the n2 variable.
release-2.x.y
2014-03-04, Mark Doliner
f38a5005e8a8
Parents a9504b165b27
Children 68b8eb10977f
Don't reuse the n2 variable.

Use a separate variable, just to avoid confusion. Local variables
are EXTREMELY cheap, since they're just an address on the stack.

Using separate variables for separate uses reduces chances of bugs.
1 files changed, 5 insertions(+), 4 deletions(-)
  • +5 -4
    pidgin/win32/untar.c
    • --- a/pidgin/win32/untar.c Sat Mar 01 17:13:32 2014 -0800
    +++ b/pidgin/win32/untar.c Tue Mar 04 23:01:37 2014 -0800
    @@ -496,18 +496,19 @@
    */
    if (tblk->type == '5')
    {
    + char *tmp;
    if (LISTING)
    - n2 = " directory";
    + tmp = " directory";
    #ifdef _POSIX_SOURCE
    else if (mkdir(nbuf, mode) == 0)
    #else
    else if (g_mkdir(nbuf, 0755) == 0)
    #endif
    - n2 = " created";
    + tmp = " created";
    else
    - n2 = " ignored";
    + tmp = " ignored";
    if (VERBOSE)
    - untar_verbose("%s\n", n2);
    + untar_verbose("%s\n", tmp);
    return 1;
    }