pidgin/pidgin

Yahoo: fix potential NULL pointer dereference
release-2.x.y
2013-07-05, Tomasz Wasilczyk
e111ec8dcb3f
Parents 0f7e07af75fc
Children c9e5aba2dafd
Yahoo: fix potential NULL pointer dereference
1 files changed, 5 insertions(+), 0 deletions(-)
  • +5 -0
    libpurple/protocols/yahoo/libymsg.c
    • --- a/libpurple/protocols/yahoo/libymsg.c Sat Jun 22 19:08:59 2013 +0200
    +++ b/libpurple/protocols/yahoo/libymsg.c Fri Jul 05 12:14:21 2013 +0200
    @@ -1717,6 +1717,8 @@
    purple_debug_info("yahoo","Authentication: In yahoo_auth16_stage3\n");
    + g_return_if_fail(crypt != NULL);
    +
    md5_cipher = purple_ciphers_find_cipher("md5");
    md5_ctx = purple_cipher_context_new(md5_cipher, NULL);
    purple_cipher_context_append(md5_ctx, (guchar *)crypt, strlen(crypt));
    @@ -1858,6 +1860,9 @@
    g_strfreev(splits);
    g_strfreev(split_data);
    + if (crumb == NULL)
    + response_no = -1;
    +
    if(response_no != 0) {
    /* Some error in the login process */
    PurpleConnectionError error;