pidgin/pidgin

fix crash when opening preferences

14 months ago, Markus Fischer
d202e153dd70
Parents f63bd4f70ce9
Children 4c7b2771461a
fix crash when opening preferences

Due to the stun_server preference being removed, pidgin crashed when opening the preferences.
To reproduce this, make sure that there is no old stun_server pref in prefs.xml

Testing Done:
Opened preferences and experienced no crash.

Reviewed at https://reviews.imfreedom.org/r/2347/
1 files changed, 7 insertions(+), 2 deletions(-)
  • +7 -2
    pidgin/prefs/pidginnetworkprefs.c
    • --- a/pidgin/prefs/pidginnetworkprefs.c Mon Mar 13 15:23:16 2023 -0500
    +++ b/pidgin/prefs/pidginnetworkprefs.c Mon Mar 13 15:26:14 2023 -0500
    @@ -143,10 +143,15 @@
    static void
    pidgin_network_prefs_init(PidginNetworkPrefs *prefs)
    {
    + const char *stun_server = NULL;
    +
    gtk_widget_init_template(GTK_WIDGET(prefs));
    - gtk_editable_set_text(GTK_EDITABLE(prefs->stun_server),
    - purple_prefs_get_string("/purple/network/stun_server"));
    + stun_server = purple_prefs_get_string("/purple/network/stun_server");
    + if (stun_server != NULL) {
    + gtk_editable_set_text(GTK_EDITABLE(prefs->stun_server),
    + stun_server);
    + }
    pidgin_prefs_bind_switch("/purple/network/auto_ip", prefs->auto_ip);
    auto_ip_button_clicked_cb(NULL, NULL, prefs); /* Update label */