pidgin/pidgin

Fix some issues scanbuild found in the gadugadu protocol plugin
release-2.x.y
2021-06-02, Gary Kramlich
a0e7e3b8e834
Parents 8924ad9e86c4
Children cfababca6bf1
Fix some issues scanbuild found in the gadugadu protocol plugin

Testing Done:
Verified that scanbuild no longer detected the errors.

Reviewed at https://reviews.imfreedom.org/r/714/
1 files changed, 4 insertions(+), 2 deletions(-)
  • +4 -2
    libpurple/protocols/gg/gg.c
    • --- a/libpurple/protocols/gg/gg.c Wed Jun 02 03:00:13 2021 -0500
    +++ b/libpurple/protocols/gg/gg.c Wed Jun 02 03:00:49 2021 -0500
    @@ -1729,12 +1729,13 @@
    glp->server_addr = server;
    info->session = gg_login(glp);
    + g_free(glp);
    +
    purple_connection_update_progress(gc, _("Connecting"), 0, 2);
    if (info->session == NULL) {
    purple_connection_error_reason (gc,
    PURPLE_CONNECTION_ERROR_NETWORK_ERROR,
    _("Connection failed"));
    - g_free(glp);
    return;
    }
    gc->inpa = purple_input_add(info->session->fd,
    @@ -1922,7 +1923,8 @@
    /* Add text after the images */
    if(last && *last) {
    - pos = pos + g_utf8_strlen(last, -1);
    + /* this is currently not used, but might be useful later? */
    + /* pos = pos + g_utf8_strlen(last, -1); */
    g_string_append(string_buffer, last);
    }