pidgin/pidgin

[gaim-migrate @ 16068]

2006-04-20, Richard Laager
9ebf0007d912
Parents 3fd8677daf94
Children f12cbb047044
[gaim-migrate @ 16068]
Suppress CID 108.

Event assign_zero: Variable "(irc)->roomlist" assigned value 0.
278 irc->roomlist = NULL;

Event var_deref_model: Variable "(irc)->roomlist" tracked as NULL was passed to a function that dereferences it.
288 gaim_roomlist_room_add_field(irc->roomlist, room, args[1]);

nosnilmot noted:
'name can't be both "323" and "322" at the same time, so this will never happen'

In the 323 case, this saves us a strcmp() that we know is useless, and adding the return is consistent with the 321 block above.
--- a/src/protocols/irc/msgs.c Thu Apr 20 04:49:12 2006 +0000
+++ b/src/protocols/irc/msgs.c Thu Apr 20 04:56:44 2006 +0000
@@ -276,6 +276,7 @@
gaim_roomlist_set_in_progress(irc->roomlist, FALSE);
gaim_roomlist_unref(irc->roomlist);
irc->roomlist = NULL;
+ return;
}
if (!strcmp(name, "322")) {