pidgin/pidgin

Clarified the meaning of PURPLE_REASON_NETWORK_ERROR and
cpw.resiak.disconnectreason
2007-09-19, Will Thompson
97e2d532c2ac
Parents 11d00e9f216f
Children 7487bb69ae76
Clarified the meaning of PURPLE_REASON_NETWORK_ERROR and
PURPLE_REASON_AUTHENTICATION_FAILED, and added
PURPLE_REASON_AUTHENTICATION_IMPOSSIBLE. It's not fatal basically because none
of the places in prpl-jabber that need it set wants_to_die --- should it be?
2 files changed, 11 insertions(+), 2 deletions(-)
  • +1 -0
    libpurple/connection.c
  • +10 -2
    libpurple/connection.h
    • --- a/libpurple/connection.c Tue Sep 18 22:04:20 2007 +0000
    +++ b/libpurple/connection.c Wed Sep 19 11:39:42 2007 +0000
    @@ -531,6 +531,7 @@
    switch (reason)
    {
    case PURPLE_REASON_NETWORK_ERROR:
    + case PURPLE_REASON_AUTHENTICATION_IMPOSSIBLE:
    return FALSE;
    case PURPLE_REASON_AUTHENTICATION_FAILED:
    case PURPLE_REASON_ENCRYPTION_ERROR:
    --- a/libpurple/connection.h Tue Sep 18 22:04:20 2007 +0000
    +++ b/libpurple/connection.h Wed Sep 19 11:39:42 2007 +0000
    @@ -58,10 +58,18 @@
    /** Possible errors that can cause a connection to be closed. */
    typedef enum
    {
    - /** There was an error sending or receiving on the network socket. */
    + /** There was an error sending or receiving on the network socket, or
    + * there was some protocol error (such as the server sending malformed
    + * data).
    + */
    PURPLE_REASON_NETWORK_ERROR = 0,
    - /** The username or password was invalid. */
    + /** The username or password (or some other credential) was incorrect.
    + */
    PURPLE_REASON_AUTHENTICATION_FAILED,
    + /** libpurple doesn't speak any of the authentication methods the
    + * server offered.
    + */
    + PURPLE_REASON_AUTHENTICATION_IMPOSSIBLE,
    /** There was an error negotiating SSL on this connection, or encryption
    * was unavailable and an account option was set to require it.
    */