pidgin/pidgin

96340aff0523
Parents 7b1c60353345
Children 4955dfedc1db
Replace the deprecated gconfaudiosink with autoaudiosink

The "gconfaudiosink" element doesn't exist in GStreamer 1.x [1]. The
recommended replacement is "autoaudiosink".

Note that MATE doesn't use GConf - it was ported to GSettings and dconf
in MATE 1.6 [2]; and GNOME's official video player, Totem, uses
"autoaudiosink".

[1] gst-plugins-good commit 728732438bbbe81f
https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/commit/728732438bbbe81f

[2] https://mate-desktop.org/blog/2013-04-02-mate-1-6-released/
https://fedoraproject.org/wiki/Features/MATE-Desktop-1.6
--- a/finch/gntsound.c Fri May 22 01:13:41 2020 +0000
+++ b/finch/gntsound.c Sat Jun 06 02:37:50 2020 -0500
@@ -513,11 +513,7 @@
if (gst_init_failed) /* Perhaps do beep instead? */
return;
if (purple_strequal(method, "automatic")) {
- if (purple_running_gnome()) {
- sink = gst_element_factory_make("gconfaudiosink", "sink");
- }
- if (!sink)
- sink = gst_element_factory_make("autoaudiosink", "sink");
+ sink = gst_element_factory_make("autoaudiosink", "sink");
if (!sink) {
purple_debug_error("sound", "Unable to create GStreamer audiosink.\n");
return;
--- a/pidgin/gtksound.c Fri May 22 01:13:41 2020 +0000
+++ b/pidgin/gtksound.c Sat Jun 06 02:37:50 2020 -0500
@@ -520,7 +520,7 @@
if (sink == NULL)
sink = gst_element_factory_make("waveformsink", "sink");
if (sink == NULL)
- sink = gst_element_factory_make("gconfaudiosink", "sink");
+ sink = gst_element_factory_make("autoaudiosink", "sink");
} else if (purple_strequal(method, "directsound")) {
sink = gst_element_factory_make("directsoundsink", "sink");
} else if (purple_strequal(method, "waveform")) {
@@ -528,7 +528,7 @@
}
#else
if (purple_strequal(method, "automatic")) {
- sink = gst_element_factory_make("gconfaudiosink", "sink");
+ sink = gst_element_factory_make("autoaudiosink", "sink");
} else if (purple_strequal(method, "esd")) {
sink = gst_element_factory_make("esdsink", "sink");
} else if (purple_strequal(method, "alsa")) {