Bump C standard to C99 for Pidgin files and fix warnings
Bump C standard to C99 for Pidgin files only and fix warnings
Testing Done:
Touched all Pidgin files, compiled and saw no new warnings.
Reviewed at https://reviews.imfreedom.org/r/2103/
--- a/pidgin/gtkblist.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkblist.c Mon Nov 28 23:20:24 2022 -0600
@@ -641,10 +641,10 @@
pidgin_blist_refresh(list);
-static void gtk_blist_renderer_editing_started_cb(GtkCellRenderer *renderer,
- GtkCellEditable *editable,
+gtk_blist_renderer_editing_started_cb(G_GNUC_UNUSED GtkCellRenderer *renderer, + GtkCellEditable *editable, + gchar *path_str, gpointer user_data) PidginBuddyList *gtkblist = PIDGIN_BUDDY_LIST(user_data);
@@ -785,8 +785,9 @@
-static void gtk_blist_renderer_edited_cb(GtkCellRendererText *text_rend, char *arg1,
- char *arg2, PurpleBuddyList *list)
+gtk_blist_renderer_edited_cb(G_GNUC_UNUSED GtkCellRendererText *text_rend, + char *arg1, char *arg2, PurpleBuddyList *list) PidginBuddyList *gtkblist = PIDGIN_BUDDY_LIST(list);
@@ -904,7 +905,8 @@
* strings are empty then don't allow the user to click on "OK."
-set_sensitive_if_input_chat_cb(GtkWidget *entry, gpointer user_data)
+set_sensitive_if_input_chat_cb(G_GNUC_UNUSED GtkWidget *entry, PurpleProtocol *protocol;
@@ -984,9 +986,10 @@
make_blist_request_dialog(PidginBlistRequestData *data, PurpleAccount *account,
- const char *title, const char *window_role, const char *label_text,
- GCallback callback_func, GtkCustomFilterFunc filter_func,
+ const char *title, const char *label_text, + GCallback callback_func, + GtkCustomFilterFunc filter_func, @@ -1183,7 +1186,7 @@
data = g_new0(PidginChatData, 1);
make_blist_request_dialog((PidginBlistRequestData *)data, NULL,
- _("Join a Chat"), "join_chat",
_("Please enter the appropriate information about the chat "
"you would like to join.\n"),
G_CALLBACK(chat_select_account_cb),
@@ -1204,7 +1207,9 @@
gtk_widget_show(data->rq_data.window);
-static void gtk_blist_row_expanded_cb(GtkTreeView *tv, GtkTreeIter *iter, GtkTreePath *path, gpointer user_data)
+gtk_blist_row_expanded_cb(G_GNUC_UNUSED GtkTreeView *tv, GtkTreeIter *iter, + G_GNUC_UNUSED GtkTreePath *path, gpointer user_data) PidginBuddyList *gtkblist = PIDGIN_BUDDY_LIST(user_data);
@@ -1227,7 +1232,9 @@
-static void gtk_blist_row_collapsed_cb(GtkTreeView *tv, GtkTreeIter *iter, GtkTreePath *path, gpointer user_data)
+gtk_blist_row_collapsed_cb(G_GNUC_UNUSED GtkTreeView *tv, GtkTreeIter *iter, + G_GNUC_UNUSED GtkTreePath *path, gpointer user_data) PidginBuddyList *gtkblist = PIDGIN_BUDDY_LIST(user_data);
@@ -1264,7 +1271,10 @@
-static void gtk_blist_row_activated_cb(GtkTreeView *tv, GtkTreePath *path, GtkTreeViewColumn *col, gpointer data) {
+gtk_blist_row_activated_cb(G_GNUC_UNUSED GtkTreeView *tv, GtkTreePath *path, + G_GNUC_UNUSED GtkTreeViewColumn *col, gpointer data) PidginBuddyList *gtkblist = PIDGIN_BUDDY_LIST(data);
@@ -1311,7 +1321,8 @@
-pidgin_blist_expand_contact_cb(GtkWidget *w, PurpleBlistNode *node)
+pidgin_blist_expand_contact_cb(G_GNUC_UNUSED GtkWidget *w, PidginBlistNode *gtknode;
GtkTreeIter iter, parent;
@@ -1347,7 +1358,8 @@
-pidgin_blist_collapse_contact_cb(GtkWidget *w, PurpleBlistNode *node)
+pidgin_blist_collapse_contact_cb(G_GNUC_UNUSED GtkWidget *w, PidginBlistNode *gtknode;
@@ -2476,7 +2488,8 @@
static GHashTable *cached_emblems;
-static void _cleanup_cached_emblem(gpointer data, GObject *obj) {
+_cleanup_cached_emblem(gpointer data, G_GNUC_UNUSED GObject *obj) { g_hash_table_remove(cached_emblems, data);
@@ -2778,7 +2791,7 @@
conversation_updated_cb(PurpleConversation *conv, PurpleConversationUpdateType type,
- PidginBuddyList *gtkblist)
+ G_GNUC_UNUSED PidginBuddyList *gtkblist) PurpleAccount *account = purple_conversation_get_account(conv);
@@ -2807,7 +2820,8 @@
-conversation_created_cb(PurpleConversation *conv, PidginBuddyList *gtkblist)
+conversation_created_cb(PurpleConversation *conv, + G_GNUC_UNUSED PidginBuddyList *gtkblist) PurpleAccount *account = purple_conversation_get_account(conv);
@@ -2854,7 +2868,9 @@
-pidgin_blist_new_node(PurpleBuddyList *list, PurpleBlistNode *node) {
+pidgin_blist_new_node(G_GNUC_UNUSED PurpleBuddyList *list, PidginBlistNode *pidgin_node = NULL;
pidgin_node = g_new0(PidginBlistNode, 1);
@@ -2897,8 +2913,10 @@
pidgin_blist_sort_method_set(id);
-static void _prefs_change_sort_method(const char *pref_name, PurplePrefType type,
- gconstpointer val, gpointer data)
+_prefs_change_sort_method(const char *pref_name, + G_GNUC_UNUSED PurplePrefType type, gconstpointer val, + G_GNUC_UNUSED gpointer data) if(purple_strequal(pref_name, PIDGIN_PREFS_ROOT "/blist/sort_type"))
pidgin_blist_sort_method_set(val);
@@ -3285,7 +3303,9 @@
-static void pidgin_blist_selection_changed(GtkTreeSelection *selection, gpointer data)
+pidgin_blist_selection_changed(GtkTreeSelection *selection, + G_GNUC_UNUSED gpointer data) PurpleBlistNode *new_selection = NULL;
@@ -3568,7 +3588,9 @@
-static void pidgin_blist_update_buddy(PurpleBuddyList *list, PurpleBlistNode *node, gboolean status_change)
+pidgin_blist_update_buddy(PurpleBuddyList *list, PurpleBlistNode *node, + G_GNUC_UNUSED gboolean status_change) PidginBlistNode *gtkparentnode;
@@ -3691,7 +3713,8 @@
-static void pidgin_blist_set_visible(PurpleBuddyList *list, gboolean show)
+pidgin_blist_set_visible(G_GNUC_UNUSED PurpleBuddyList *list, gboolean show) if (!(gtkblist && gtkblist->window))
@@ -3706,9 +3729,9 @@
-pidgin_blist_request_add_buddy(PurpleBuddyList *list, PurpleAccount *account,
- const char *username, const char *group,
+pidgin_blist_request_add_buddy(G_GNUC_UNUSED PurpleBuddyList *list, + PurpleAccount *account, const char *username, + const char *group, const char *alias) GtkWidget *dialog = NULL;
@@ -3718,9 +3741,9 @@
-pidgin_blist_request_add_chat(PurpleBuddyList *list, PurpleAccount *account,
- PurpleGroup *group, const char *alias,
+pidgin_blist_request_add_chat(G_GNUC_UNUSED PurpleBuddyList *list, + PurpleAccount *account, PurpleGroup *group, + const char *alias, const char *name) GtkWidget *dialog = NULL;
@@ -3730,7 +3753,8 @@
-add_group_cb(PurpleConnection *gc, const char *group_name)
+add_group_cb(G_GNUC_UNUSED PurpleConnection *connection, + const char *group_name) @@ -3742,7 +3766,7 @@
-pidgin_blist_request_add_group(PurpleBuddyList *list)
+pidgin_blist_request_add_group(G_GNUC_UNUSED PurpleBuddyList *list) purple_request_input(NULL, _("Add Group"), NULL,
_("Please enter the name of the group to be added."),
@@ -3758,7 +3782,8 @@
-static gboolean autojoin_cb(PurpleConnection *gc, gpointer data)
+autojoin_cb(PurpleConnection *gc, G_GNUC_UNUSED gpointer data) PurpleAccount *account = purple_connection_get_account(gc);
PurpleBlistNode *gnode, *cnode;
@@ -3888,7 +3913,7 @@
* GTK Buddy list GObject code
**************************************************************************/
-pidgin_buddy_list_init(PidginBuddyList *self)
+pidgin_buddy_list_init(G_GNUC_UNUSED PidginBuddyList *self) @@ -4000,7 +4025,9 @@
******************************************/
-static void sort_method_none(PurpleBlistNode *node, PurpleBuddyList *blist, GtkTreeIter parent_iter, GtkTreeIter *cur, GtkTreeIter *iter)
+sort_method_none(PurpleBlistNode *node, G_GNUC_UNUSED PurpleBuddyList *blist, + GtkTreeIter parent_iter, GtkTreeIter *cur, GtkTreeIter *iter) PurpleBlistNode *sibling = node->prev;
GtkTreeIter sibling_iter;
--- a/pidgin/gtkconv.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkconv.c Mon Nov 28 23:20:24 2022 -0600
@@ -95,7 +95,7 @@
-close_conv_cb(GtkButton *button, PidginConversation *gtkconv)
+close_conv_cb(G_GNUC_UNUSED GtkButton *button, PidginConversation *gtkconv) /* We are going to destroy the conversations immediately only if the 'close immediately'
* preference is selected. Otherwise, close the conversation after a reasonable timeout
@@ -234,7 +234,7 @@
-send_cb(GtkWidget *widget, PidginConversation *gtkconv)
+send_cb(G_GNUC_UNUSED GtkWidget *widget, PidginConversation *gtkconv) PurpleConversation *conv = gtkconv->active_conv;
@@ -624,7 +624,9 @@
-activate_list_cb(GtkTreeView *list, GtkTreePath *path, GtkTreeViewColumn *column, PidginConversation *gtkconv)
+activate_list_cb(GtkTreeView *list, GtkTreePath *path, + G_GNUC_UNUSED GtkTreeViewColumn *column, + PidginConversation *gtkconv) @@ -1006,7 +1008,8 @@
-add_chat_user_common(PurpleChatConversation *chat, PurpleChatUser *cb, const char *old_name)
+add_chat_user_common(PurpleChatConversation *chat, PurpleChatUser *cb, + G_GNUC_UNUSED const char *old_name) PidginConversation *gtkconv;
PurpleConversation *conv;
@@ -1073,7 +1076,8 @@
-static void topic_callback(GtkWidget *w, PidginConversation *gtkconv)
+topic_callback(G_GNUC_UNUSED GtkWidget *w, PidginConversation *gtkconv) PurpleProtocol *protocol = NULL;
@@ -1111,7 +1115,8 @@
-sort_chat_users(GtkTreeModel *model, GtkTreeIter *a, GtkTreeIter *b, gpointer userdata)
+sort_chat_users(GtkTreeModel *model, GtkTreeIter *a, GtkTreeIter *b, + G_GNUC_UNUSED gpointer userdata) PurpleChatUserFlags f1 = 0, f2 = 0;
char *user1 = NULL, *user2 = NULL;
@@ -1153,7 +1158,9 @@
-update_chat_alias(PurpleBuddy *buddy, PurpleChatConversation *chat, PurpleConnection *gc, PurpleProtocol *protocol)
+update_chat_alias(PurpleBuddy *buddy, PurpleChatConversation *chat, + G_GNUC_UNUSED PurpleConnection *connection, + G_GNUC_UNUSED PurpleProtocol *protocol) PidginConversation *gtkconv = PIDGIN_CONVERSATION(PURPLE_CONVERSATION(chat));
PurpleAccount *account = purple_conversation_get_account(PURPLE_CONVERSATION(chat));
@@ -1635,7 +1642,7 @@
* Conversation UI operations
**************************************************************************/
-private_gtkconv_new(PurpleConversation *conv, gboolean hidden)
+private_gtkconv_new(PurpleConversation *conv, G_GNUC_UNUSED gboolean hidden) PidginConversation *gtkconv;
GtkWidget *tab_cont, *pane;
@@ -1712,8 +1719,10 @@
-received_im_msg_cb(PurpleAccount *account, char *sender, char *message,
- PurpleConversation *conv, PurpleMessageFlags flags)
+received_im_msg_cb(G_GNUC_UNUSED PurpleAccount *account, + G_GNUC_UNUSED char *sender, G_GNUC_UNUSED char *message, + PurpleConversation *conv, + G_GNUC_UNUSED PurpleMessageFlags flags) @@ -1774,7 +1783,8 @@
-writing_msg(PurpleConversation *conv, PurpleMessage *msg, gpointer _unused)
+writing_msg(PurpleConversation *conv, PurpleMessage *msg, + G_GNUC_UNUSED gpointer _unused) PidginConversation *gtkconv;
@@ -1862,7 +1872,8 @@
-pidgin_conv_chat_add_users(PurpleChatConversation *chat, GList *cbuddies, gboolean new_arrivals)
+pidgin_conv_chat_add_users(PurpleChatConversation *chat, GList *cbuddies, + G_GNUC_UNUSED gboolean new_arrivals) PidginConversation *gtkconv;
@@ -2193,8 +2204,10 @@
* Public conversation utility functions
**************************************************************************/
-show_formatting_toolbar_pref_cb(const char *name, PurplePrefType type,
- gconstpointer value, gpointer data)
+show_formatting_toolbar_pref_cb(G_GNUC_UNUSED const char *name, + G_GNUC_UNUSED PurplePrefType type, + G_GNUC_UNUSED gpointer data) PurpleConversation *conv;
@@ -2246,7 +2259,7 @@
-account_signed_off_cb(PurpleConnection *gc, gpointer event)
+account_signed_off_cb(PurpleConnection *gc, G_GNUC_UNUSED gpointer event) PurpleConversationManager *manager;
@@ -2357,7 +2370,8 @@
-update_buddy_idle_changed(PurpleBuddy *buddy, gboolean old, gboolean newidle)
+update_buddy_idle_changed(PurpleBuddy *buddy, G_GNUC_UNUSED gboolean old, + G_GNUC_UNUSED gboolean newidle) PurpleConversationManager *manager;
@@ -2440,7 +2454,8 @@
-update_chat_topic(PurpleChatConversation *chat, const char *old, const char *new)
+update_chat_topic(PurpleChatConversation *chat, G_GNUC_UNUSED const char *old, + G_GNUC_UNUSED const char *new) pidgin_conv_update_fields(PURPLE_CONVERSATION(chat), PIDGIN_CONV_TOPIC);
--- a/pidgin/gtkdialogs.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkdialogs.c Mon Nov 28 23:20:24 2022 -0600
@@ -47,7 +47,7 @@
-pidgin_dialogs_im_cb(gpointer data, PurpleRequestFields *fields)
+pidgin_dialogs_im_cb(G_GNUC_UNUSED gpointer data, PurpleRequestFields *fields) @@ -59,8 +59,8 @@
-pidgin_dialogs_im_name_validator(PurpleRequestField *field, gchar **errmsg,
+pidgin_dialogs_im_name_validator(G_GNUC_UNUSED PurpleRequestField *field, + char **errmsg, gpointer _fields) PurpleRequestFields *fields = _fields;
@@ -137,7 +137,8 @@
-pidgin_dialogs_info_cb(gpointer data, PurpleRequestFields *fields)
+pidgin_dialogs_info_cb(G_GNUC_UNUSED gpointer data, + PurpleRequestFields *fields) --- a/pidgin/gtkidle.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkidle.c Mon Nov 28 23:20:24 2022 -0600
@@ -109,7 +109,7 @@
-pidgin_idle_get_idle_time(PurpleIdleUi *ui) {
+pidgin_idle_get_idle_time(G_GNUC_UNUSED PurpleIdleUi *ui) { @@ -204,11 +204,11 @@
-pidgin_idle_init(PidginIdle *idle) {
+pidgin_idle_init(G_GNUC_UNUSED PidginIdle *idle) { -pidgin_idle_class_init(PidginIdleClass *klass) {
+pidgin_idle_class_init(G_GNUC_UNUSED PidginIdleClass *klass) { /******************************************************************************
--- a/pidgin/gtkmedia.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkmedia.c Mon Nov 28 23:20:24 2022 -0600
@@ -116,7 +116,7 @@
-pidgin_media_close_request_cb(GtkWindow *window, gpointer data) {
+pidgin_media_close_request_cb(G_GNUC_UNUSED GtkWindow *window, gpointer data) { PidginMedia *media = data;
@@ -167,8 +167,9 @@
-pidgin_media_hangup_activate_cb(GSimpleAction *action, GVariant *parameter,
+pidgin_media_hangup_activate_cb(G_GNUC_UNUSED GSimpleAction *action, + G_GNUC_UNUSED GVariant *parameter, PidginMedia *media = PIDGIN_MEDIA(user_data);
@@ -219,10 +220,25 @@
static const GActionEntry media_action_entries[] = {
- { "Hangup", pidgin_media_hangup_activate_cb },
- { "Hold", NULL, NULL, "false", pidgin_media_hold_change_state_cb },
- { "Mute", NULL, NULL, "false", pidgin_media_mute_change_state_cb },
- { "Pause", NULL, NULL, "false", pidgin_media_pause_change_state_cb },
+ .activate = pidgin_media_hangup_activate_cb, + .change_state = pidgin_media_hold_change_state_cb, + .change_state = pidgin_media_mute_change_state_cb, + .change_state = pidgin_media_pause_change_state_cb, @@ -327,8 +343,8 @@
-level_message_cb(PurpleMedia *media, gchar *session_id, gchar *participant,
- double level, PidginMedia *gtkmedia)
+level_message_cb(G_GNUC_UNUSED PurpleMedia *media, char *session_id, + char *participant, double level, PidginMedia *gtkmedia) GtkWidget *progress = NULL;
@@ -412,7 +428,7 @@
-pidgin_media_error_cb(PidginMedia *media, const gchar *error,
+pidgin_media_error_cb(G_GNUC_UNUSED PidginMedia *media, const char *error, PurpleConversation *conv;
@@ -439,14 +455,14 @@
-pidgin_media_accept_cb(PurpleMedia *media, int index)
+pidgin_media_accept_cb(PurpleMedia *media, G_GNUC_UNUSED int index) purple_media_stream_info(media, PURPLE_MEDIA_INFO_ACCEPT,
-pidgin_media_reject_cb(PurpleMedia *media, int index)
+pidgin_media_reject_cb(PurpleMedia *media, G_GNUC_UNUSED int index) GList *iter = purple_media_get_session_ids(media);
for (; iter; iter = g_list_delete_link(iter, iter)) {
@@ -503,23 +519,23 @@
-pidgin_media_input_volume_changed(GtkScaleButton *range, double value,
+pidgin_media_input_volume_changed(G_GNUC_UNUSED GtkScaleButton *range, + double value, PurpleMedia *media) double val = (double)value * 100.0;
purple_media_set_input_volume(media, NULL, val);
-pidgin_media_output_volume_changed(GtkScaleButton *range, double value,
+pidgin_media_output_volume_changed(G_GNUC_UNUSED GtkScaleButton *range, + double value, PurpleMedia *media) double val = (double)value * 100.0;
purple_media_set_output_volume(media, NULL, NULL, val);
-destroy_parent_widget_cb(GtkWidget *widget, GtkWidget *parent)
+destroy_parent_widget_cb(G_GNUC_UNUSED GtkWidget *widget, GtkWidget *parent) g_return_if_fail(GTK_IS_WIDGET(parent));
@@ -590,7 +606,8 @@
-pidgin_media_keypad_pressed_cb(PidginKeypad *keypad, guint key, gpointer data)
+pidgin_media_keypad_pressed_cb(G_GNUC_UNUSED PidginKeypad *keypad, guint key, PidginMedia *gtkmedia = data;
@@ -602,7 +619,8 @@
pidgin_media_add_dtmf_widget(PidginMedia *gtkmedia,
- PurpleMediaSessionType type, const gchar *_sid)
+ G_GNUC_UNUSED PurpleMediaSessionType type, GtkApplicationWindow *win = GTK_APPLICATION_WINDOW(gtkmedia);
GtkWidget *keypad = NULL;
@@ -787,9 +805,11 @@
-pidgin_media_stream_info_cb(PurpleMedia *media, PurpleMediaInfoType type,
- gchar *sid, gchar *name, gboolean local,
+pidgin_media_stream_info_cb(G_GNUC_UNUSED PurpleMedia *media, + PurpleMediaInfoType type, + G_GNUC_UNUSED gchar *sid, + G_GNUC_UNUSED gchar *name, gboolean local, if (type == PURPLE_MEDIA_INFO_REJECT) {
pidgin_media_emit_message(gtkmedia,
@@ -876,8 +896,9 @@
-pidgin_media_new_cb(PurpleMediaManager *manager, PurpleMedia *media,
- PurpleAccount *account, gchar *screenname, gpointer nul)
+pidgin_media_new_cb(G_GNUC_UNUSED PurpleMediaManager *manager, + PurpleMedia *media, PurpleAccount *account, + char *screenname, G_GNUC_UNUSED gpointer data) PidginMedia *gtkmedia = NULL;
PurpleBuddy *buddy = NULL;
--- a/pidgin/gtknotify.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtknotify.c Mon Nov 28 23:20:24 2022 -0600
@@ -58,27 +58,32 @@
static void pidgin_close_notify(PurpleNotifyType type, void *ui_handle);
-message_response_cb(GtkDialog *dialog, gint id, GtkWidget *widget)
+message_response_cb(G_GNUC_UNUSED GtkDialog *dialog, G_GNUC_UNUSED gint id, purple_notify_close(PURPLE_NOTIFY_MESSAGE, widget);
-formatted_close_cb(GtkWidget *win, GdkEvent *event, void *user_data)
+formatted_close_cb(GtkWidget *win, G_GNUC_UNUSED GdkEvent *event, + G_GNUC_UNUSED gpointer user_data) purple_notify_close(PURPLE_NOTIFY_FORMATTED, win);
-searchresults_close_cb(PidginNotifySearchResultsData *data, GdkEvent *event, gpointer user_data)
+searchresults_close_cb(PidginNotifySearchResultsData *data, + G_GNUC_UNUSED GdkEvent *event, + G_GNUC_UNUSED gpointer user_data) purple_notify_close(PURPLE_NOTIFY_SEARCHRESULTS, data);
-searchresults_callback_wrapper_cb(GtkWidget *widget, PidginNotifySearchResultsButtonData *bd)
+searchresults_callback_wrapper_cb(G_GNUC_UNUSED GtkWidget *widget, + PidginNotifySearchResultsButtonData *bd) PidginNotifySearchResultsData *data = bd->data;
@@ -225,7 +230,8 @@
formatted_input_cb(GtkWidget *win, guint keyval, G_GNUC_UNUSED guint keycode,
- G_GNUC_UNUSED GdkModifierType state, gpointer data)
+ G_GNUC_UNUSED GdkModifierType state, + G_GNUC_UNUSED gpointer data) if (keyval == GDK_KEY_Escape) {
purple_notify_close(PURPLE_NOTIFY_FORMATTED, win);
--- a/pidgin/gtkpluginpref.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkpluginpref.c Mon Nov 28 23:20:24 2022 -0600
@@ -37,7 +37,7 @@
-multiline_cb(GtkTextBuffer *buffer, gpointer data) {
+multiline_cb(GtkTextBuffer *buffer, G_GNUC_UNUSED gpointer data) { gchar *pref = NULL, *text = NULL;
pref = g_object_get_data(G_OBJECT(buffer), "pref-key");
--- a/pidgin/gtkprivacy.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkprivacy.c Mon Nov 28 23:20:24 2022 -0600
@@ -113,7 +113,8 @@
-user_selected_cb(GtkTreeSelection *sel, PidginPrivacyDialog *dialog)
+user_selected_cb(G_GNUC_UNUSED GtkTreeSelection *sel, + PidginPrivacyDialog *dialog) gtk_widget_set_sensitive(dialog->remove_button, TRUE);
@@ -206,7 +207,7 @@
-add_cb(GtkWidget *button, PidginPrivacyDialog *dialog)
+add_cb(G_GNUC_UNUSED GtkWidget *button, PidginPrivacyDialog *dialog) if (dialog->in_allow_list)
pidgin_request_add_permit(dialog->account, NULL);
@@ -215,7 +216,7 @@
-remove_cb(GtkWidget *button, PidginPrivacyDialog *dialog)
+remove_cb(G_GNUC_UNUSED GtkWidget *button, PidginPrivacyDialog *dialog) @@ -251,7 +252,7 @@
-removeall_cb(GtkWidget *button, PidginPrivacyDialog *dialog)
+removeall_cb(G_GNUC_UNUSED GtkWidget *button, PidginPrivacyDialog *dialog) if (dialog->in_allow_list)
@@ -371,7 +372,8 @@
-confirm_permit_block_cb(PidginPrivacyRequestData *data, int option)
+confirm_permit_block_cb(PidginPrivacyRequestData *data, + G_GNUC_UNUSED int option) purple_account_privacy_deny(data->account, data->name);
@@ -469,14 +471,16 @@
-pidgin_permit_added_removed(PurpleAccount *account, const char *name)
+pidgin_permit_added_removed(G_GNUC_UNUSED PurpleAccount *account, + G_GNUC_UNUSED const char *name) if (privacy_dialog != NULL)
rebuild_allow_list(privacy_dialog);
-pidgin_deny_added_removed(PurpleAccount *account, const char *name)
+pidgin_deny_added_removed(G_GNUC_UNUSED PurpleAccount *account, + G_GNUC_UNUSED const char *name) if (privacy_dialog != NULL)
rebuild_block_list(privacy_dialog);
--- a/pidgin/gtkrequest.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkrequest.c Mon Nov 28 23:20:24 2022 -0600
@@ -120,7 +120,8 @@
-input_response_cb(GtkDialog *dialog, gint id, PidginRequestData *data)
+input_response_cb(G_GNUC_UNUSED GtkDialog *dialog, gint id, + PidginRequestData *data) char *multiline_value = NULL;
@@ -162,7 +163,8 @@
-action_response_cb(GtkDialog *dialog, gint id, PidginRequestData *data)
+action_response_cb(G_GNUC_UNUSED GtkDialog *dialog, gint id, + PidginRequestData *data) generic_response_start(data);
@@ -174,7 +176,7 @@
-choice_response_cb(GtkDialog *dialog, gint id, PidginRequestData *data)
+choice_response_cb(G_GNUC_UNUSED GtkDialog *dialog, G_GNUC_UNUSED gint id, G_GNUC_UNUSED PidginRequestData *data) #warning please rewrite me
@@ -224,7 +226,8 @@
-req_field_changed_common(GtkWidget *widget, PurpleRequestField *field)
+req_field_changed_common(G_GNUC_UNUSED GtkWidget *widget, + PurpleRequestField *field) PurpleRequestFieldGroup *group;
PurpleRequestFields *fields;
@@ -277,7 +280,7 @@
-field_choice_option_cb(GtkCheckButton *button, PurpleRequestField *field)
+field_choice_option_cb(G_GNUC_UNUSED GtkCheckButton *button, G_GNUC_UNUSED PurpleRequestField *field) #warning please rewrite me
@@ -327,7 +330,7 @@
-multifield_cancel_cb(GtkWidget *button, PidginRequestData *data)
+multifield_cancel_cb(G_GNUC_UNUSED GtkWidget *button, PidginRequestData *data) generic_response_start(data);
@@ -354,7 +357,7 @@
-destroy_multifield_cb(GtkWidget *self, PidginRequestData *data)
+destroy_multifield_cb(G_GNUC_UNUSED GtkWidget *self, PidginRequestData *data) multifield_cancel_cb(NULL, data);
@@ -482,7 +485,7 @@
-pidgin_request_help_clicked(GtkButton *button, gpointer _unused)
+pidgin_request_help_clicked(GtkButton *button, G_GNUC_UNUSED gpointer _unused) @@ -932,7 +935,7 @@
-wait_cancel_cb(GtkWidget *button, PidginRequestData *data)
+wait_cancel_cb(G_GNUC_UNUSED GtkWidget *button, PidginRequestData *data) generic_response_start(data);
@@ -1447,7 +1450,7 @@
-select_field_list_item(GtkTreeModel *model, GtkTreePath *path,
+select_field_list_item(GtkTreeModel *model, G_GNUC_UNUSED GtkTreePath *path, GtkTreeIter *iter, gpointer data)
PurpleRequestField *field = (PurpleRequestField *)data;
@@ -1620,6 +1623,7 @@
return purple_request_datasheet_record_find(sheet, key);
datasheet_button_check_sens(GtkWidget *button, gpointer _sheet_widget)
@@ -1636,9 +1640,10 @@
purple_request_datasheet_action_is_sensitive(act,
datasheet_get_selected_row(sheet_widget)));
-datasheet_selection_changed(GtkWidget *sheet_widget)
+datasheet_selection_changed(G_GNUC_UNUSED GtkWidget *sheet_widget) @@ -1773,7 +1778,8 @@
-datasheet_selection_changed_cb(GtkTreeSelection *sel, gpointer sheet_widget)
+datasheet_selection_changed_cb(G_GNUC_UNUSED GtkTreeSelection *sel, datasheet_selection_changed(GTK_WIDGET(sheet_widget));
@@ -2251,7 +2257,8 @@
-file_ok_check_if_exists_cb(GtkWidget *widget, gint response, PidginRequestData *data)
+file_ok_check_if_exists_cb(G_GNUC_UNUSED GtkWidget *widget, gint response, + PidginRequestData *data) @@ -2283,8 +2290,9 @@
pidgin_request_file(const char *title, const char *filename,
- gboolean savedialog, GCallback ok_cb, GCallback cancel_cb,
- PurpleRequestCommonParameters *cpar, void *user_data)
+ gboolean savedialog, GCallback ok_cb, GCallback cancel_cb, + G_GNUC_UNUSED PurpleRequestCommonParameters *cpar, GtkFileChooserNative *filesel;
@@ -2370,8 +2378,9 @@
pidgin_request_folder(const char *title, const char *dirname, GCallback ok_cb,
- GCallback cancel_cb, PurpleRequestCommonParameters *cpar,
+ G_GNUC_UNUSED PurpleRequestCommonParameters *cpar, GtkFileChooserNative *dirsel;
--- a/pidgin/gtkroomlist.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkroomlist.c Mon Nov 28 23:20:24 2022 -0600
@@ -216,7 +216,7 @@
_search_func(GtkTreeModel *model, gint column, const gchar *key,
- GtkTreeIter *iter, gpointer search_data)
+ GtkTreeIter *iter, G_GNUC_UNUSED gpointer search_data) gchar *name, *fold, *fkey;
@@ -251,7 +251,7 @@
*****************************************************************************/
pidgin_roomlist_add_to_blist_cb(G_GNUC_UNUSED GSimpleAction *action,
- G_GNUC_UNUSED GVariant *parameter,
+ G_GNUC_UNUSED GVariant *parameter, pidgin_roomlist_add_to_blist(data);
@@ -259,7 +259,8 @@
-pidgin_roomlist_join_cb(GSimpleAction *action, GVariant *parameter,
+pidgin_roomlist_join_cb(G_GNUC_UNUSED GSimpleAction *action, + G_GNUC_UNUSED GVariant *parameter, pidgin_roomlist_join(data);
@@ -280,7 +281,7 @@
*****************************************************************************/
pidgin_roomlist_response_cb(GtkDialog *gtk_dialog, gint response_id,
+ G_GNUC_UNUSED gpointer data) PidginRoomlistDialog *dialog = PIDGIN_ROOMLIST_DIALOG(gtk_dialog);
@@ -349,8 +350,8 @@
-row_activated_cb(GtkTreeView *tv, GtkTreePath *path, GtkTreeViewColumn *arg2,
+row_activated_cb(G_GNUC_UNUSED GtkTreeView *tv, GtkTreePath *path, + G_GNUC_UNUSED GtkTreeViewColumn *arg2, gpointer data) PidginRoomlistDialog *dialog = data;
PidginRoomlist *grl = NULL;
--- a/pidgin/gtksavedstatuses.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtksavedstatuses.c Mon Nov 28 23:20:24 2022 -0600
@@ -104,8 +104,11 @@
purple_savedstatus_get_title(saved_status_b));
-static gboolean pidgin_status_menu_add_primitive(GtkListStore *model, GtkWidget *w, PurpleStatusPrimitive primitive,
- PurpleSavedStatus *current_status)
+pidgin_status_menu_add_primitive(GtkListStore *model, + G_GNUC_UNUSED GtkWidget *w, + PurpleStatusPrimitive primitive, + PurpleSavedStatus *current_status) gboolean currently_selected = FALSE;
--- a/pidgin/gtkutils.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkutils.c Mon Nov 28 23:20:24 2022 -0600
@@ -193,8 +193,10 @@
-static gboolean buddyname_completion_match_func(GtkEntryCompletion *completion,
- const gchar *key, GtkTreeIter *iter, gpointer user_data)
+buddyname_completion_match_func(GtkEntryCompletion *completion, + const char *key, GtkTreeIter *iter, + G_GNUC_UNUSED gpointer user_data) @@ -224,8 +226,10 @@
-static gboolean buddyname_completion_match_selected_cb(GtkEntryCompletion *completion,
- GtkTreeModel *model, GtkTreeIter *iter, PidginCompletionData *data)
+buddyname_completion_match_selected_cb(G_GNUC_UNUSED GtkEntryCompletion *completion, + GtkTreeModel *model, GtkTreeIter *iter, + PidginCompletionData *data) GtkWidget *optmenu = data->accountopt;
@@ -369,7 +373,7 @@
-repopulate_autocomplete(gpointer something, gpointer data)
+repopulate_autocomplete(G_GNUC_UNUSED gpointer something, gpointer data) add_completion_list(data);
@@ -495,8 +499,10 @@
* is to add an extra column to the GtkTreeModel. And this function is
* used rarely, so it shouldn't matter TOO much.
-gboolean pidgin_tree_view_search_equal_func(GtkTreeModel *model, gint column,
- const gchar *key, GtkTreeIter *iter, gpointer data)
+pidgin_tree_view_search_equal_func(GtkTreeModel *model, gint column, + const char *key, GtkTreeIter *iter, + G_GNUC_UNUSED gpointer data) --- a/pidgin/gtkwhiteboard.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkwhiteboard.c Mon Nov 28 23:20:24 2022 -0600
@@ -26,6 +26,9 @@
+#define M_PI (3.14159265358979323846264338327950288) @@ -91,7 +94,7 @@
-whiteboard_close_cb(GtkWidget *widget, GdkEvent *event,
+whiteboard_close_cb(GtkWidget *widget, G_GNUC_UNUSED GdkEvent *event, G_GNUC_UNUSED gpointer data)
PidginWhiteboard *gtkwb = PIDGIN_WHITEBOARD(widget);
@@ -102,8 +105,8 @@
-pidgin_whiteboard_resize(GtkDrawingArea *self, gint width, gint height,
+pidgin_whiteboard_resize(G_GNUC_UNUSED GtkDrawingArea *self, gint width, + gint height, gpointer data) PidginWhiteboard *gtkwb = (PidginWhiteboard*)data;
GdkRGBA white = {1.0f, 1.0f, 1.0f, 1.0f};
@@ -122,8 +125,8 @@
-pidgin_whiteboard_draw_event(GtkWidget *widget, cairo_t *cr,
+pidgin_whiteboard_draw_event(G_GNUC_UNUSED GtkWidget *widget, cairo_t *cr, PidginWhiteboard *gtkwb = _gtkwb;
@@ -230,8 +233,8 @@
-pidgin_whiteboard_brush_down(GtkGestureDrag* self, gdouble x, gdouble y,
+pidgin_whiteboard_brush_down(G_GNUC_UNUSED GtkGestureDrag* self, gdouble x, + gdouble y, gpointer data) PidginWhiteboard *gtkwb = (PidginWhiteboard*)data;
PurpleWhiteboard *wb = gtkwb->wb;
@@ -263,8 +266,8 @@
-pidgin_whiteboard_brush_motion(GtkGestureDrag* self, gdouble x, gdouble y,
+pidgin_whiteboard_brush_motion(G_GNUC_UNUSED GtkGestureDrag* self, gdouble x, + gdouble y, gpointer data) PidginWhiteboard *gtkwb = (PidginWhiteboard*)data;
PurpleWhiteboard *wb = gtkwb->wb;
@@ -298,7 +301,8 @@
-pidgin_whiteboard_brush_up(GtkGestureDrag *self, gdouble x, gdouble y,
+pidgin_whiteboard_brush_up(G_GNUC_UNUSED GtkGestureDrag *self, + G_GNUC_UNUSED gdouble x, G_GNUC_UNUSED gdouble y, PidginWhiteboard *gtkwb = (PidginWhiteboard*)data;
@@ -353,8 +357,7 @@
-pidgin_whiteboard_clear_response(GtkDialog *self, guint response,
+pidgin_whiteboard_clear_response(GtkDialog *self, gint response, gpointer data) PidginWhiteboard *gtkwb = (PidginWhiteboard *)data;
@@ -369,7 +372,9 @@
-pidgin_whiteboard_button_clear_press(GtkWidget *widget, gpointer data) {
+pidgin_whiteboard_button_clear_press(G_GNUC_UNUSED GtkWidget *widget, PidginWhiteboard *gtkwb = (PidginWhiteboard*)(data);
/* Confirm whether the user really wants to clear */
@@ -422,7 +427,8 @@
-pidgin_whiteboard_button_save_press(GtkWidget *widget, gpointer _gtkwb)
+pidgin_whiteboard_button_save_press(G_GNUC_UNUSED GtkWidget *widget, PidginWhiteboard *gtkwb = _gtkwb;
GtkFileChooserNative *chooser;
--- a/pidgin/gtkxfer.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/gtkxfer.c Mon Nov 28 23:20:24 2022 -0600
@@ -369,7 +369,7 @@
**************************************************************************/
-close_request_cb(GtkWidget *w, gpointer d) {
+close_request_cb(G_GNUC_UNUSED GtkWidget *w, gpointer d) { PidginXferDialog *dialog = (PidginXferDialog *)d;
pidgin_xfer_dialog_hide(dialog);
@@ -426,7 +426,7 @@
-open_button_cb(GtkButton *button, PidginXferDialog *dialog)
+open_button_cb(G_GNUC_UNUSED GtkButton *button, PidginXferDialog *dialog) @@ -437,19 +437,19 @@
-remove_button_cb(GtkButton *button, PidginXferDialog *dialog)
+remove_button_cb(G_GNUC_UNUSED GtkButton *button, PidginXferDialog *dialog) pidgin_xfer_dialog_remove_xfer(dialog, dialog->selected_xfer);
-stop_button_cb(GtkButton *button, PidginXferDialog *dialog)
+stop_button_cb(G_GNUC_UNUSED GtkButton *button, PidginXferDialog *dialog) purple_xfer_cancel_local(dialog->selected_xfer);
-close_button_cb(GtkButton *button, PidginXferDialog *dialog)
+close_button_cb(G_GNUC_UNUSED GtkButton *button, PidginXferDialog *dialog) pidgin_xfer_dialog_hide(dialog);
--- a/pidgin/libpidgin.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/libpidgin.c Mon Nov 28 23:20:24 2022 -0600
@@ -104,7 +104,8 @@
-mainloop_sighandler(GIOChannel *source, GIOCondition cond, gpointer data)
+mainloop_sighandler(GIOChannel *source, G_GNUC_UNUSED GIOCondition cond, + G_GNUC_UNUSED gpointer data) --- a/pidgin/meson.build Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/meson.build Mon Nov 28 23:20:24 2022 -0600
@@ -235,7 +235,8 @@
include_directories : [toplevel_inc, include_directories('prefs')],
version : PURPLE_LIB_VERSION,
dependencies : _libpidgin_dependencies,
+ override_options : ['c_std=c99', 'warning_level=2']) libpidgin_dep = declare_dependency(
include_directories : [toplevel_inc, libpidgin_inc],
@@ -248,7 +249,8 @@
include_directories : toplevel_inc,
dependencies : IS_WIN32 ? [] : [libpurple_dep, libpidgin_dep],
win_subsystem : 'windows',
+ override_options : ['c_std=c99', 'warning_level=2']) meson.override_dependency(pidgin_filebase, libpidgin_dep)
--- a/pidgin/pidginaccountsdisabledmenu.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginaccountsdisabledmenu.c Mon Nov 28 23:20:24 2022 -0600
@@ -76,7 +76,7 @@
* GMenuModel Implementation
*****************************************************************************/
-pidgin_accounts_disabled_menu_is_mutable(GMenuModel *model) {
+pidgin_accounts_disabled_menu_is_mutable(G_GNUC_UNUSED GMenuModel *model) { @@ -158,7 +158,8 @@
-pidgin_accounts_disabled_menu_get_item_links(GMenuModel *model, gint index,
+pidgin_accounts_disabled_menu_get_item_links(G_GNUC_UNUSED GMenuModel *model, + G_GNUC_UNUSED gint index, *links = g_hash_table_new_full(g_str_hash, g_str_equal, g_free,
--- a/pidgin/pidginaccountsenabledmenu.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginaccountsenabledmenu.c Mon Nov 28 23:20:24 2022 -0600
@@ -156,7 +156,7 @@
* GMenuModel Implementation
*****************************************************************************/
-pidgin_accounts_enabled_menu_is_mutable(GMenuModel *model) {
+pidgin_accounts_enabled_menu_is_mutable(G_GNUC_UNUSED GMenuModel *model) { --- a/pidgin/pidginactiongroup.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginactiongroup.c Mon Nov 28 23:20:24 2022 -0600
@@ -100,8 +100,8 @@
*****************************************************************************/
-pidgin_action_group_sort_method_callback(const gchar *name,
+pidgin_action_group_sort_method_callback(G_GNUC_UNUSED const gchar *name, + G_GNUC_UNUSED PurplePrefType type, @@ -116,8 +116,8 @@
*****************************************************************************/
-pidgin_action_group_sort_method(GSimpleAction *action, GVariant *value,
+pidgin_action_group_sort_method(G_GNUC_UNUSED GSimpleAction *action, + GVariant *value, G_GNUC_UNUSED gpointer data) purple_prefs_set_string(PIDGIN_PREFS_ROOT "/blist/sort_type",
g_variant_get_string(value, NULL));
--- a/pidgin/pidginapplication.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginapplication.c Mon Nov 28 23:20:24 2022 -0600
@@ -258,8 +258,8 @@
-pidgin_application_about(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_about(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, gpointer data) PidginApplication *application = data;
static GtkWidget *about = NULL;
@@ -273,8 +273,8 @@
-pidgin_application_accounts(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_accounts(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, gpointer data) PidginApplication *application = data;
static GtkWidget *manager = NULL;
@@ -289,29 +289,33 @@
-pidgin_application_add_buddy(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_add_buddy(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) purple_blist_request_add_buddy(NULL, NULL, NULL, NULL);
-pidgin_application_add_chat(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_add_chat(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) purple_blist_request_add_chat(NULL, NULL, NULL, NULL);
-pidgin_application_add_group(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_add_group(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) purple_blist_request_add_group();
-pidgin_application_connect_account(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_connect_account(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED gpointer data) PurpleAccount *account = NULL;
PurpleAccountManager *manager = NULL;
@@ -328,8 +332,9 @@
-pidgin_application_debug(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_debug(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) gboolean old = purple_prefs_get_bool(PIDGIN_PREFS_ROOT "/debug/enabled");
purple_prefs_set_bool(PIDGIN_PREFS_ROOT "/debug/enabled", !old);
@@ -337,8 +342,9 @@
-pidgin_application_disable_account(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_disable_account(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED gpointer data) PurpleAccount *account = NULL;
PurpleAccountManager *manager = NULL;
@@ -365,8 +371,8 @@
-pidgin_application_edit_account(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_edit_account(G_GNUC_UNUSED GSimpleAction *simple, + GVariant *parameter, gpointer data) PidginApplication *application = data;
PurpleAccount *account = NULL;
@@ -387,8 +393,9 @@
-pidgin_application_enable_account(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_enable_account(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED gpointer data) PurpleAccount *account = NULL;
PurpleAccountManager *manager = NULL;
@@ -407,29 +414,33 @@
-pidgin_application_file_transfers(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_file_transfers(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) pidgin_xfer_dialog_show(NULL);
-pidgin_application_get_user_info(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_get_user_info(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) -pidgin_application_join_chat(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_join_chat(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) pidgin_blist_joinchat_show();
-pidgin_application_new_message(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_new_message(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) @@ -444,15 +455,16 @@
-pidgin_application_online_help(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_online_help(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) purple_notify_uri(NULL, PURPLE_WEBSITE "help");
-pidgin_application_plugins(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_plugins(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, gpointer data) PidginApplication *application = data;
static GtkWidget *dialog = NULL;
@@ -467,22 +479,25 @@
-pidgin_application_preferences(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_preferences(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) -pidgin_application_privacy(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_privacy(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) pidgin_privacy_dialog_show();
-pidgin_application_quit(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_quit(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) GPluginManager *manager = NULL;
@@ -498,22 +513,25 @@
-pidgin_application_room_list(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_room_list(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) pidgin_roomlist_dialog_show();
-pidgin_application_set_mood(GSimpleAction *simple, GVariant *parameter,
+pidgin_application_set_mood(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, + G_GNUC_UNUSED gpointer data) pidgin_mood_dialog_show(NULL);
-pidgin_application_show_status_manager(GSimpleAction *simple,
- GVariant *parameter, gpointer data)
+pidgin_application_show_status_manager(G_GNUC_UNUSED GSimpleAction *simple, + G_GNUC_UNUSED GVariant *parameter, PidginApplication *application = data;
static GtkWidget *manager = NULL;
@@ -667,7 +685,9 @@
-pidgin_application_signed_off_cb(PurpleAccount *account, gpointer data) {
+pidgin_application_signed_off_cb(G_GNUC_UNUSED PurpleAccount *account, PidginApplication *application = PIDGIN_APPLICATION(data);
gboolean should_disable_chat = TRUE, should_disable_room_list = TRUE;
GList *connections = NULL, *l = NULL;
@@ -914,7 +934,7 @@
-pidgin_application_activate(GApplication *application) {
+pidgin_application_activate(G_GNUC_UNUSED GApplication *application) { GtkWidget *convwin = pidgin_display_window_get_default();
if(GTK_IS_WINDOW(convwin)) {
@@ -947,7 +967,7 @@
-pidgin_application_handle_local_options(GApplication *application,
+pidgin_application_handle_local_options(G_GNUC_UNUSED GApplication *application, if (g_variant_dict_contains(options, "version")) {
--- a/pidgin/pidginattachment.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginattachment.c Mon Nov 28 23:20:24 2022 -0600
@@ -141,7 +141,7 @@
-pidgin_attachment_init(PidginAttachment *attachment) {
+pidgin_attachment_init(G_GNUC_UNUSED PidginAttachment *attachment) { --- a/pidgin/pidginavatar.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginavatar.c Mon Nov 28 23:20:24 2022 -0600
@@ -198,8 +198,8 @@
-pidgin_avatar_save_cb(GSimpleAction *action, GVariant *parameter,
+pidgin_avatar_save_cb(G_GNUC_UNUSED GSimpleAction *action, + G_GNUC_UNUSED GVariant *parameter, gpointer data) PidginAvatar *avatar = PIDGIN_AVATAR(data);
PurpleBuddy *buddy = NULL;
@@ -279,8 +279,8 @@
-pidgin_avatar_set_custom_cb(GSimpleAction *action, GVariant *parameter,
+pidgin_avatar_set_custom_cb(G_GNUC_UNUSED GSimpleAction *action, + G_GNUC_UNUSED GVariant *parameter, gpointer data) PidginAvatar *avatar = PIDGIN_AVATAR(data);
GtkFileChooserNative *native = NULL;
@@ -300,8 +300,8 @@
-pidgin_avatar_clear_custom_cb(GSimpleAction *action, GVariant *parameter,
+pidgin_avatar_clear_custom_cb(G_GNUC_UNUSED GSimpleAction *action, + G_GNUC_UNUSED GVariant *parameter, gpointer data) PidginAvatar *avatar = PIDGIN_AVATAR(data);
PurpleBuddy *buddy = NULL;
@@ -367,7 +367,9 @@
* cause issues if a buddy is changed but a conversation is not and vice versa.
-pidgin_avatar_buddy_icon_updated(GObject *obj, GParamSpec *pspec, gpointer d) {
+pidgin_avatar_buddy_icon_updated(G_GNUC_UNUSED GObject *obj, + G_GNUC_UNUSED GParamSpec *pspec, gpointer d) PidginAvatar *avatar = PIDGIN_AVATAR(d);
pidgin_avatar_update(avatar);
@@ -380,7 +382,8 @@
* cause issues if a buddy is changed but a conversation is not and vice versa.
-pidgin_avatar_conversation_updated(GObject *obj, GParamSpec *pspec, gpointer d)
+pidgin_avatar_conversation_updated(G_GNUC_UNUSED GObject *obj, + G_GNUC_UNUSED GParamSpec *pspec, gpointer d) PidginAvatar *avatar = PIDGIN_AVATAR(d);
--- a/pidgin/pidgincommands.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidgincommands.c Mon Nov 28 23:20:24 2022 -0600
@@ -28,8 +28,9 @@
* Command Implementations
*****************************************************************************/
-say_command_cb(PurpleConversation *conv,
- const char *cmd, char **args, char **error, void *data)
+say_command_cb(PurpleConversation *conv, G_GNUC_UNUSED const char *cmd, + char **args, G_GNUC_UNUSED char **error, + G_GNUC_UNUSED gpointer data) purple_conversation_send(conv, args[0]);
@@ -37,8 +38,9 @@
-me_command_cb(PurpleConversation *conv,
- const char *cmd, char **args, char **error, void *data)
+me_command_cb(PurpleConversation *conv, G_GNUC_UNUSED const char *cmd, + char **args, G_GNUC_UNUSED char **error, + G_GNUC_UNUSED gpointer data) @@ -50,8 +52,9 @@
-debug_command_cb(PurpleConversation *conv,
- const char *cmd, char **args, char **error, void *data)
+debug_command_cb(PurpleConversation *conv, G_GNUC_UNUSED const char *cmd, + char **args, G_GNUC_UNUSED char **error, + G_GNUC_UNUSED gpointer data) @@ -126,16 +129,18 @@
-clear_command_cb(PurpleConversation *conv,
- const char *cmd, char **args, char **error, void *data)
+clear_command_cb(PurpleConversation *conv, G_GNUC_UNUSED const char *cmd, + G_GNUC_UNUSED char **args, G_GNUC_UNUSED char **error, + G_GNUC_UNUSED gpointer data) purple_conversation_clear_message_history(conv);
return PURPLE_CMD_RET_OK;
-clearall_command_cb(PurpleConversation *conv,
- const char *cmd, char **args, char **error, void *data)
+clearall_command_cb(G_GNUC_UNUSED PurpleConversation *conv, + G_GNUC_UNUSED const char *cmd, G_GNUC_UNUSED char **args, + G_GNUC_UNUSED char **error, G_GNUC_UNUSED gpointer data) PurpleConversationManager *manager;
@@ -155,8 +160,9 @@
-help_command_cb(PurpleConversation *conv,
- const char *cmd, char **args, char **error, void *data)
+help_command_cb(PurpleConversation *conv, G_GNUC_UNUSED const char *cmd, + char **args, G_GNUC_UNUSED char **error, + G_GNUC_UNUSED gpointer data) --- a/pidgin/pidgindebug.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidgindebug.c Mon Nov 28 23:20:24 2022 -0600
@@ -173,7 +173,7 @@
-save_cb(GtkWidget *w, PidginDebugWindow *win)
+save_cb(G_GNUC_UNUSED GtkWidget *w, PidginDebugWindow *win) GtkFileChooserNative *filesel;
@@ -191,7 +191,7 @@
-clear_cb(GtkWidget *w, PidginDebugWindow *win)
+clear_cb(G_GNUC_UNUSED GtkWidget *w, PidginDebugWindow *win) gtk_text_buffer_set_text(win->buffer, "", 0);
@@ -320,7 +320,8 @@
-regex_pref_filter_cb(const gchar *name, PurplePrefType type,
+regex_pref_filter_cb(G_GNUC_UNUSED const gchar *name, + G_GNUC_UNUSED PurplePrefType type, gconstpointer val, gpointer data)
PidginDebugWindow *win = (PidginDebugWindow *)data;
@@ -337,7 +338,8 @@
-regex_pref_invert_cb(const gchar *name, PurplePrefType type,
+regex_pref_invert_cb(G_GNUC_UNUSED const gchar *name, + G_GNUC_UNUSED PurplePrefType type, gconstpointer val, gpointer data)
PidginDebugWindow *win = (PidginDebugWindow *)data;
@@ -351,7 +353,8 @@
-regex_pref_highlight_cb(const gchar *name, PurplePrefType type,
+regex_pref_highlight_cb(G_GNUC_UNUSED const gchar *name, + G_GNUC_UNUSED PurplePrefType type, gconstpointer val, gpointer data)
PidginDebugWindow *win = (PidginDebugWindow *)data;
@@ -365,7 +368,7 @@
-regex_changed_cb(GtkWidget *w, PidginDebugWindow *win) {
+regex_changed_cb(G_GNUC_UNUSED GtkWidget *w, PidginDebugWindow *win) { if (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(win->filter))) {
@@ -459,7 +462,7 @@
- if (level != gtk_drop_down_get_selected(GTK_DROP_DOWN(win->filterlevel))) {
+ if (level != (int)gtk_drop_down_get_selected(GTK_DROP_DOWN(win->filterlevel))) { gtk_drop_down_set_selected(GTK_DROP_DOWN(win->filterlevel), level);
@@ -476,7 +479,9 @@
-filter_level_pref_changed(const char *name, PurplePrefType type, gconstpointer value, gpointer data)
+filter_level_pref_changed(G_GNUC_UNUSED const char *name, + G_GNUC_UNUSED PurplePrefType type, + gconstpointer value, gpointer data) PidginDebugWindow *win = data;
int level = GPOINTER_TO_INT(value);
@@ -681,7 +686,7 @@
debug_enabled_cb(G_GNUC_UNUSED const gchar *name,
G_GNUC_UNUSED PurplePrefType type,
+ G_GNUC_UNUSED gpointer data) debug_enabled_timer = g_timeout_add(0, debug_enabled_timeout_cb,
--- a/pidgin/pidgindisplaywindow.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidgindisplaywindow.c Mon Nov 28 23:20:24 2022 -0600
@@ -348,7 +348,7 @@
-pidgin_display_window_key_pressed_cb(GtkEventControllerKey *controller,
+pidgin_display_window_key_pressed_cb(G_GNUC_UNUSED GtkEventControllerKey *controller, G_GNUC_UNUSED guint keycode,
--- a/pidgin/pidginmessage.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginmessage.c Mon Nov 28 23:20:24 2022 -0600
@@ -268,7 +268,7 @@
-pidgin_message_init(PidginMessage *message) {
+pidgin_message_init(G_GNUC_UNUSED PidginMessage *message) { --- a/pidgin/pidginnotificationlist.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginnotificationlist.c Mon Nov 28 23:20:24 2022 -0600
@@ -65,7 +65,9 @@
-pidgin_notification_list_create_widget_func(gpointer item, gpointer data) {
+pidgin_notification_list_create_widget_func(gpointer item, + G_GNUC_UNUSED gpointer data) PurpleNotification *notification = item;
GtkWidget *widget = NULL;
--- a/pidgin/pidginplugininfo.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginplugininfo.c Mon Nov 28 23:20:24 2022 -0600
@@ -73,7 +73,7 @@
-pidgin_plugin_info_init(PidginPluginInfo *info) {
+pidgin_plugin_info_init(G_GNUC_UNUSED PidginPluginInfo *info) { --- a/pidgin/pidginpluginsmenu.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginpluginsmenu.c Mon Nov 28 23:20:24 2022 -0600
@@ -128,7 +128,7 @@
* GMenuModel Implementation
*****************************************************************************/
-pidgin_plugins_menu_is_mutable(GMenuModel *model) {
+pidgin_plugins_menu_is_mutable(G_GNUC_UNUSED GMenuModel *model) { --- a/pidgin/pidginpresenceicon.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginpresenceicon.c Mon Nov 28 23:20:24 2022 -0600
@@ -57,7 +57,8 @@
-pidgin_presence_icon_active_status_changed_cb(GObject *obj, GParamSpec *pspec,
+pidgin_presence_icon_active_status_changed_cb(G_GNUC_UNUSED GObject *obj, + G_GNUC_UNUSED GParamSpec *pspec, pidgin_presence_icon_update(PIDGIN_PRESENCE_ICON(data));
--- a/pidgin/pidginstatuseditor.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/pidginstatuseditor.c Mon Nov 28 23:20:24 2022 -0600
@@ -151,7 +151,9 @@
-pidgin_status_editor_title_changed_cb(GtkEditable *editable, gpointer data) {
+pidgin_status_editor_title_changed_cb(G_GNUC_UNUSED GtkEditable *editable, PidginStatusEditor *editor = data;
gboolean title_changed = FALSE, sensitive = FALSE;
const gchar *title = NULL;
--- a/pidgin/prefs/pidgincredentialprefs.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/prefs/pidgincredentialprefs.c Mon Nov 28 23:20:24 2022 -0600
@@ -85,7 +85,7 @@
-pidgin_credential_prefs_list_row_activated_cb(GtkListBox *box,
+pidgin_credential_prefs_list_row_activated_cb(G_GNUC_UNUSED GtkListBox *box, G_GNUC_UNUSED gpointer data)
@@ -131,8 +131,8 @@
-pidgin_credential_prefs_active_provider_changed_cb(PurpleCredentialManager *manager,
- PurpleCredentialProvider *previous,
+pidgin_credential_prefs_active_provider_changed_cb(G_GNUC_UNUSED PurpleCredentialManager *manager, + G_GNUC_UNUSED PurpleCredentialProvider *previous, PurpleCredentialProvider *current,
--- a/pidgin/prefs/pidginnetworkprefs.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/prefs/pidginnetworkprefs.c Mon Nov 28 23:20:24 2022 -0600
@@ -54,7 +54,7 @@
*****************************************************************************/
-network_ip_changed(GtkEditable *editable, gpointer data)
+network_ip_changed(GtkEditable *editable, G_GNUC_UNUSED gpointer data) const gchar *text = gtk_editable_get_text(editable);
GtkWidget *widget = GTK_WIDGET(editable);
--- a/pidgin/prefs/pidginprefs.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/prefs/pidginprefs.c Mon Nov 28 23:20:24 2022 -0600
@@ -51,7 +51,7 @@
*****************************************************************************/
-update_spin_value(GtkWidget *w, GtkWidget *spin)
+update_spin_value(G_GNUC_UNUSED GtkWidget *w, GtkWidget *spin) const char *key = g_object_get_data(G_OBJECT(spin), "val");
@@ -475,7 +475,7 @@
-delete_prefs(GtkWidget *asdf, void *gdsa)
+delete_prefs(G_GNUC_UNUSED GtkWidget *asdf, G_GNUC_UNUSED void *gdsa) /* Close any request dialogs */
purple_request_close_with_handle(prefs);
--- a/pidgin/prefs/pidginvvprefs.c Mon Nov 28 21:05:22 2022 -0600
+++ b/pidgin/prefs/pidginvvprefs.c Mon Nov 28 23:20:24 2022 -0600
@@ -141,7 +141,7 @@
-on_volume_change_cb(GtkWidget *w, gdouble value, gpointer data)
+on_volume_change_cb(GtkWidget *w, G_GNUC_UNUSED gdouble value, gpointer data) PidginVVPrefs *prefs = PIDGIN_VV_PREFS(data);
@@ -173,7 +173,7 @@
-gst_bus_cb(GstBus *bus, GstMessage *msg, gpointer data)
+gst_bus_cb(G_GNUC_UNUSED GstBus *bus, GstMessage *msg, gpointer data) PidginVVPrefs *prefs = PIDGIN_VV_PREFS(data);
@@ -212,7 +212,7 @@
-voice_test_destroy_cb(GtkWidget *w, gpointer data)
+voice_test_destroy_cb(G_GNUC_UNUSED GtkWidget *w, gpointer data) PidginVVPrefs *prefs = PIDGIN_VV_PREFS(data);
@@ -262,7 +262,8 @@
-volume_changed_cb(GtkScaleButton *button, gdouble value, gpointer data)
+volume_changed_cb(G_GNUC_UNUSED GtkScaleButton *button, gdouble value, + G_GNUC_UNUSED gpointer data) purple_prefs_set_int("/purple/media/audio/volume/input", value * 100);
@@ -338,7 +339,7 @@
-video_test_destroy_cb(GtkWidget *w, gpointer data)
+video_test_destroy_cb(G_GNUC_UNUSED GtkWidget *w, gpointer data) PidginVVPrefs *prefs = PIDGIN_VV_PREFS(data);
@@ -389,7 +390,7 @@
-vv_device_changed_cb(const gchar *name, PurplePrefType type,
+vv_device_changed_cb(const gchar *name, G_GNUC_UNUSED PurplePrefType type, gconstpointer value, gpointer data)
PidginVVPrefs *prefs = PIDGIN_VV_PREFS(data);
@@ -465,7 +466,8 @@
-device_list_changed_cb(PurpleMediaManager *manager, GtkWidget *widget)
+device_list_changed_cb(G_GNUC_UNUSED PurpleMediaManager *manager, PurpleMediaElementType media_type;