pidgin/pidgin

pass QString arguments by const reference to avoid unnecessary copying

14 months ago, Markus Fischer
7b233c733ea9
Parents 59ceb87dc43c
Children c053558f1236
pass QString arguments by const reference to avoid unnecessary copying

Testing Done:
compiled and ran pidgin with XMPP accounts that autoconnected

Reviewed at https://reviews.imfreedom.org/r/2341/
2 files changed, 15 insertions(+), 15 deletions(-)
  • +7 -7
    libpurple/plugins/kwallet/purplekwallet.cpp
  • +8 -8
    libpurple/plugins/kwallet/purplekwallet.h
    • --- a/libpurple/plugins/kwallet/purplekwallet.cpp Fri Mar 10 01:42:06 2023 -0600
    +++ b/libpurple/plugins/kwallet/purplekwallet.cpp Fri Mar 10 16:36:55 2023 -0600
    @@ -79,7 +79,7 @@
    /******************************************************************************
    * Request Implementation
    *****************************************************************************/
    -PurpleKWalletPlugin::Request::Request(QString key, GTask *task) {
    +PurpleKWalletPlugin::Request::Request(const QString &key, GTask *task) {
    this->key = key;
    this->task = G_TASK(g_object_ref(G_OBJECT(task)));
    }
    @@ -91,7 +91,7 @@
    /******************************************************************************
    * ReadRequest Implementation
    *****************************************************************************/
    -PurpleKWalletPlugin::ReadRequest::ReadRequest(QString key, GTask *task) : PurpleKWalletPlugin::Request(key, task) {
    +PurpleKWalletPlugin::ReadRequest::ReadRequest(const QString &key, GTask *task) : PurpleKWalletPlugin::Request(key, task) {
    }
    void
    @@ -128,7 +128,7 @@
    }
    void
    -PurpleKWalletPlugin::ReadRequest::cancel(QString reason) {
    +PurpleKWalletPlugin::ReadRequest::cancel(const QString &reason) {
    g_task_return_new_error(this->task, PURPLE_KWALLET_DOMAIN, 0,
    _("failed to read password: %s"),
    reason.toUtf8().constData());
    @@ -139,7 +139,7 @@
    /******************************************************************************
    * WriteRequest Implementation
    *****************************************************************************/
    -PurpleKWalletPlugin::WriteRequest::WriteRequest(QString key, GTask *task, QString password) : PurpleKWalletPlugin::Request(key, task) {
    +PurpleKWalletPlugin::WriteRequest::WriteRequest(const QString &key, GTask *task, const QString &password) : PurpleKWalletPlugin::Request(key, task) {
    this->password = password;
    }
    @@ -161,7 +161,7 @@
    }
    void
    -PurpleKWalletPlugin::WriteRequest::cancel(QString reason) {
    +PurpleKWalletPlugin::WriteRequest::cancel(const QString &reason) {
    g_task_return_new_error(this->task, PURPLE_KWALLET_DOMAIN, 0,
    _("failed to write password: %s"),
    reason.toUtf8().constData());
    @@ -172,7 +172,7 @@
    /******************************************************************************
    * ClearRequest Implementation
    *****************************************************************************/
    -PurpleKWalletPlugin::ClearRequest::ClearRequest(QString key, GTask *task) : PurpleKWalletPlugin::Request(key, task) {
    +PurpleKWalletPlugin::ClearRequest::ClearRequest(const QString &key, GTask *task) : PurpleKWalletPlugin::Request(key, task) {
    }
    void
    @@ -193,7 +193,7 @@
    }
    void
    -PurpleKWalletPlugin::ClearRequest::cancel(QString reason) {
    +PurpleKWalletPlugin::ClearRequest::cancel(const QString &reason) {
    g_task_return_new_error(this->task, PURPLE_KWALLET_DOMAIN, 0,
    _("failed to clear password: %s"),
    reason.toUtf8().constData());
    --- a/libpurple/plugins/kwallet/purplekwallet.h Fri Mar 10 01:42:06 2023 -0600
    +++ b/libpurple/plugins/kwallet/purplekwallet.h Fri Mar 10 16:36:55 2023 -0600
    @@ -34,10 +34,10 @@
    class Request {
    public:
    - Request(QString key, GTask *task);
    + Request(const QString &key, GTask *task);
    virtual ~Request(void);
    virtual void execute(KWallet::Wallet *wallet) = 0;
    - virtual void cancel(QString reason) = 0;
    + virtual void cancel(const QString &reason) = 0;
    protected:
    QString key;
    GTask *task;
    @@ -45,25 +45,25 @@
    class ReadRequest : public Request {
    public:
    - ReadRequest(QString key, GTask *task);
    + ReadRequest(const QString &key, GTask *task);
    void execute(KWallet::Wallet *wallet);
    - void cancel(QString reason);
    + void cancel(const QString &reason);
    };
    class WriteRequest : public Request {
    public:
    - WriteRequest(QString key, GTask *task, QString password);
    + WriteRequest(const QString &key, GTask *task, const QString &password);
    void execute(KWallet::Wallet *wallet);
    - void cancel(QString reason);
    + void cancel(const QString &reason);
    private:
    QString password;
    };
    class ClearRequest : public Request {
    public:
    - ClearRequest(QString key, GTask *task);
    + ClearRequest(const QString &key, GTask *task);
    void execute(KWallet::Wallet *wallet);
    - void cancel(QString reason);
    + void cancel(const QString &reason);
    };
    class Engine : public QObject {