pidgin/pidgin

Make sure a protocol implements PurpleProtocolClient before calling those methods

16 months ago, Gary Kramlich
63635ba9f117
Parents 0b26ebc842db
Children 1f9db98e1e6c
Make sure a protocol implements PurpleProtocolClient before calling those methods

Testing Done:
Connected an ircv3 account to libera and verified the crash was gone.

Reviewed at https://reviews.imfreedom.org/r/2176/
1 files changed, 4 insertions(+), 2 deletions(-)
  • +4 -2
    libpurple/purpleimconversation.c
    • --- a/libpurple/purpleimconversation.c Tue Jan 03 02:05:24 2023 -0600
    +++ b/libpurple/purpleimconversation.c Thu Jan 05 21:10:24 2023 -0600
    @@ -165,8 +165,10 @@
    purple_serv_send_typing(pc, name, PURPLE_IM_NOT_TYPING);
    }
    - purple_protocol_client_convo_closed(PURPLE_PROTOCOL_CLIENT(protocol),
    - pc, name);
    + if(PURPLE_IS_PROTOCOL_CLIENT(protocol)) {
    + purple_protocol_client_convo_closed(PURPLE_PROTOCOL_CLIENT(protocol),
    + pc, name);
    + }
    }
    purple_im_conversation_stop_typing_timeout(im);