pidgin/pidgin

jabber: Remove unnecessary a1len variable

2017-06-02, Mike Ruprecht
5aff241c29e5
Parents 4b8cc47d05da
Children 9c9277601d98
jabber: Remove unnecessary a1len variable

The way a1len was used is redundant with g_checksum_update() able to
internally strlen() the buffer. This patch removes it.
1 files changed, 1 insertions(+), 3 deletions(-)
  • +1 -3
    libpurple/protocols/jabber/auth_digest_md5.c
    • --- a/libpurple/protocols/jabber/auth_digest_md5.c Fri Jun 02 15:14:32 2017 -0500
    +++ b/libpurple/protocols/jabber/auth_digest_md5.c Fri Jun 02 15:17:12 2017 -0500
    @@ -106,7 +106,6 @@
    const char *cnonce, const char *a2, const char *realm)
    {
    GChecksum *hash;
    - size_t a1len;
    gsize digest_len = 16;
    gchar *a1, *convnode=NULL, *convpasswd = NULL, *ha1, *ha2, *kd, *x, *z;
    @@ -126,12 +125,11 @@
    g_checksum_update(hash, (const guchar *)x, -1);
    a1 = g_strdup_printf("xxxxxxxxxxxxxxxx:%s:%s", nonce, cnonce);
    - a1len = strlen(a1);
    g_checksum_get_digest(hash, (guint8 *)a1, &digest_len);
    g_checksum_free(hash);
    - ha1 = g_compute_checksum_for_string(G_CHECKSUM_MD5, a1, a1len);
    + ha1 = g_compute_checksum_for_string(G_CHECKSUM_MD5, a1, -1);
    ha2 = g_compute_checksum_for_string(G_CHECKSUM_MD5, a2, -1);
    kd = g_strdup_printf("%s:%s:00000001:%s:auth:%s", ha1, nonce, cnonce, ha2);