pidgin/pidgin

Fix a use after free that scanbuild detected
release-2.x.y
2021-06-01, Gary Kramlich
53938c5a6e15
Parents 8b3be4e34e27
Children 85104fd731b5
Fix a use after free that scanbuild detected

Testing Done:
Verified that scanbuild no longer detects the error.

Reviewed at https://reviews.imfreedom.org/r/701/
1 files changed, 1 insertions(+), 1 deletions(-)
  • +1 -1
    libpurple/protocols/bonjour/mdns_common.c
    • --- a/libpurple/protocols/bonjour/mdns_common.c Tue Jun 01 20:15:16 2021 -0500
    +++ b/libpurple/protocols/bonjour/mdns_common.c Tue Jun 01 20:16:06 2021 -0500
    @@ -141,8 +141,8 @@
    kvp = lst->data;
    g_free(kvp->key);
    g_free(kvp->value);
    + lst = g_slist_remove(lst, lst->data);
    g_free(kvp);
    - lst = g_slist_remove(lst, lst->data);
    }
    }