pidgin/pidgin

Fix leak in PidginPrefCombo

24 months ago, Elliott Sales de Andrade
4df8fa04b777
Parents 146db40a9f24
Children c7ca6a49977a
Fix leak in PidginPrefCombo
1 files changed, 7 insertions(+), 3 deletions(-)
  • +7 -3
    pidgin/prefs/pidginprefs.c
    • --- a/pidgin/prefs/pidginprefs.c Tue May 17 01:58:54 2022 -0500
    +++ b/pidgin/prefs/pidginprefs.c Tue May 17 01:58:55 2022 -0500
    @@ -223,9 +223,10 @@
    gtk_tree_model_get(tree_model, &iter, PREF_DROPDOWN_VALUE, &value, -1);
    purple_prefs_set_int(key, value);
    } else if (type == PURPLE_PREF_STRING) {
    - const char *value;
    + gchar *value;
    gtk_tree_model_get(tree_model, &iter, PREF_DROPDOWN_VALUE, &value, -1);
    purple_prefs_set_string(key, value);
    + g_free(value);
    } else if (type == PURPLE_PREF_BOOLEAN) {
    gboolean value;
    gtk_tree_model_get(tree_model, &iter, PREF_DROPDOWN_VALUE, &value, -1);
    @@ -372,9 +373,10 @@
    gtk_tree_model_get(tree_model, &iter, PREF_DROPDOWN_VALUE, &value, -1);
    purple_prefs_set_int(combo->key, value);
    } else if (combo->type == PURPLE_PREF_STRING) {
    - const gchar *value;
    + gchar *value;
    gtk_tree_model_get(tree_model, &iter, PREF_DROPDOWN_VALUE, &value, -1);
    purple_prefs_set_string(combo->key, value);
    + g_free(value);
    } else if (combo->type == PURPLE_PREF_BOOLEAN) {
    gboolean value;
    gtk_tree_model_get(tree_model, &iter, PREF_DROPDOWN_VALUE, &value, -1);
    @@ -420,12 +422,14 @@
    }
    } else if (combo->type == PURPLE_PREF_STRING) {
    - const gchar *value = NULL;
    + gchar *value = NULL;
    gtk_tree_model_get(store, &iter, PREF_DROPDOWN_VALUE, &value, -1);
    if (purple_strequal(pref_str_value, value)) {
    active = iter;
    + g_free(value);
    break;
    }
    + g_free(value);
    } else if (combo->type == PURPLE_PREF_BOOLEAN) {
    gboolean value = FALSE;