pidgin/pidgin

Remove Finch logging preferences but add Credential Provider preference.

20 months ago, Gary Kramlich
4666203609e6
Parents 01b94846bb60
Children 00159335ff65
Remove Finch logging preferences but add Credential Provider preference.

The logging preferences were removed because they were removed when the History API was merged, but their Finch UI remained. Also there's currently no preference for the history adapter so no reason to put it in now.

Testing Done:
Opened the preference window in finch and made sure the settings saved.

Reviewed at https://reviews.imfreedom.org/r/1595/
1 files changed, 34 insertions(+), 9 deletions(-)
  • +34 -9
    finch/gntprefs.c
    • --- a/finch/gntprefs.c Mon Aug 15 20:29:12 2022 -0500
    +++ b/finch/gntprefs.c Mon Aug 15 20:47:21 2022 -0500
    @@ -97,6 +97,33 @@
    return list;
    }
    +static void
    +get_credential_provider_options_helper(PurpleCredentialProvider *provider,
    + gpointer data)
    +{
    + GList **list = data;
    + const gchar *value = NULL;
    +
    + value = purple_credential_provider_get_name(provider);
    + *list = g_list_append(*list, (gpointer)value);
    +
    + value = purple_credential_provider_get_id(provider);
    + *list = g_list_append(*list, (gpointer)value);
    +}
    +
    +static GList *
    +get_credential_provider_options(void) {
    + PurpleCredentialManager *manager = NULL;
    + GList *list = NULL;
    +
    + manager = purple_credential_manager_get_default();
    + purple_credential_manager_foreach(manager,
    + get_credential_provider_options_helper,
    + &list);
    +
    + return list;
    +}
    +
    static PurpleRequestField *
    get_pref_field(Prefs *prefs)
    {
    @@ -177,14 +204,6 @@
    {PURPLE_PREF_NONE, NULL, NULL, NULL}
    };
    -static Prefs logging[] =
    -{
    - {PURPLE_PREF_BOOLEAN, "/purple/logging/log_ims", N_("Log IMs"), NULL},
    - {PURPLE_PREF_BOOLEAN, "/purple/logging/log_chats", N_("Log chats"), NULL},
    - {PURPLE_PREF_BOOLEAN, "/purple/logging/log_system", N_("Log status change events"), NULL},
    - {PURPLE_PREF_NONE, NULL, NULL, NULL},
    -};
    -
    static Prefs idle[] =
    {
    {PURPLE_PREF_STRING, "/purple/away/idle_reporting", N_("Report Idle time"), get_idle_options},
    @@ -194,6 +213,12 @@
    {PURPLE_PREF_NONE, NULL, NULL, NULL},
    };
    +static Prefs credentials[] =
    +{
    + {PURPLE_PREF_STRING, "/purple/credentials/active-provider", N_("Provider"), get_credential_provider_options},
    + {PURPLE_PREF_NONE, NULL, NULL, NULL},
    +};
    +
    static void
    free_strings(void)
    {
    @@ -239,8 +264,8 @@
    add_pref_group(fields, _("Buddy List"), blist);
    add_pref_group(fields, _("Conversations"), convs);
    - add_pref_group(fields, _("Logging"), logging);
    add_pref_group(fields, _("Idle"), idle);
    + add_pref_group(fields, _("Credentials"), credentials);
    pref_request.showing = TRUE;
    pref_request.window = purple_request_fields(NULL, _("Preferences"), NULL, NULL, fields,