pidgin/pidgin

jabber: Fix some review comments.

2019-11-03, Elliott Sales de Andrade
3acd6bb854c4
Parents bc2b94f2595a
Children 52c9656e40ed
jabber: Fix some review comments.

* Remove a static buffer.
* Remove a redundant condition check.
--- a/libpurple/protocols/jabber/jabber.c Sun Nov 03 16:26:09 2019 -0500
+++ b/libpurple/protocols/jabber/jabber.c Sun Nov 03 16:35:44 2019 -0500
@@ -601,7 +601,7 @@
PurpleConnection *gc = data;
JabberStream *js = purple_connection_get_protocol_data(gc);
gssize len;
- static char buf[4096];
+ gchar buf[4096];
GError *error = NULL;
PURPLE_ASSERT_CONNECTION_IS_VALID(gc);
@@ -1598,9 +1598,7 @@
js->bosh = NULL;
} else if (js->output != NULL) {
jabber_send_raw(js, "</stream:stream>", -1);
- }
-
- if (js->output != NULL) {
+
if(js->inpa) {
g_source_remove(js->inpa);
js->inpa = 0;