pidgin/pidgin

Remove unused conversation-timestamp signal.

2020-10-29, Elliott Sales de Andrade
2b0b603bd39a
Parents 0f0215662de5
Children bf0c2b76782a
Remove unused conversation-timestamp signal.

It is registered, but never emitted.

Testing Done:
Built docs.

Reviewed at https://reviews.imfreedom.org/r/180/
3 files changed, 1 insertions(+), 53 deletions(-)
  • +1 -0
    ChangeLog.API
  • +0 -35
    doc/reference/pidgin/signals_gtkconv.xml
  • +0 -18
    pidgin/gtkconv.c
    • --- a/ChangeLog.API Thu Oct 29 23:23:18 2020 -0500
    +++ b/ChangeLog.API Thu Oct 29 23:26:02 2020 -0500
    @@ -616,6 +616,7 @@
    * PidginWindow renamed to PidginConvWindow
    Removed:
    + * conversation-timestamp (gtkconv signal)
    * GtkIMHtml.clipboard_html_string
    * GtkIMHtml.clipboard_text_string
    * GtkIMHtmlFontDetail
    --- a/doc/reference/pidgin/signals_gtkconv.xml Thu Oct 29 23:23:18 2020 -0500
    +++ b/doc/reference/pidgin/signals_gtkconv.xml Thu Oct 29 23:26:02 2020 -0500
    @@ -9,7 +9,6 @@
    <title role="signal_proto.title">List of signals</title>
    <synopsis>
    &quot;<link linkend="gtkconvs-conversation-dragging">conversation-dragging</link>&quot;
    - &quot;<link linkend="gtkconvs-conversation-timestamp">conversation-timestamp</link>&quot;
    &quot;<link linkend="gtkconvs-displaying-im-msg">displaying-im-msg</link>&quot;
    &quot;<link linkend="gtkconvs-displayed-im-msg">displayed-im-msg</link>&quot;
    &quot;<link linkend="gtkconvs-displaying-chat-msg">displaying-chat-msg</link>&quot;
    @@ -49,40 +48,6 @@
    </variablelist>
    </refsect2>
    -<refsect2 id="gtkconvs-conversation-timestamp" role="signal">
    - <title>The <literal>&quot;conversation-timestamp&quot;</literal> signal</title>
    -<programlisting>
    -char * user_function (PurpleConversation *conv,
    - time_t when,
    - gboolean show_date,
    - gpointer user_data)
    -</programlisting>
    - <para>
    -Emitted to allow plugins to customize the timestamp on a message.
    - </para>
    - <variablelist role="params">
    - <varlistentry>
    - <term><parameter>conv</parameter>&#160;:</term>
    - <listitem><simpara>The conversation the message belongs to.</simpara></listitem>
    - </varlistentry>
    - <varlistentry>
    - <term><parameter>when</parameter>&#160;:</term>
    - <listitem><simpara>The time to be converted to a string.</simpara></listitem>
    - </varlistentry>
    - <varlistentry>
    - <term><parameter>show_date</parameter>&#160;:</term>
    - <listitem><simpara>Whether the date should be displayed.</simpara></listitem>
    - </varlistentry>
    - <varlistentry>
    - <term><parameter>user_data</parameter>&#160;:</term>
    - <listitem><simpara>user data set when the signal handler was connected.</simpara></listitem>
    - </varlistentry>
    - <varlistentry>
    - <term><emphasis>Returns</emphasis>&#160;:</term>
    - <listitem><simpara>A textual representation of the time, or <literal>NULL</literal> to use a default format.</simpara></listitem>
    - </varlistentry>
    - </variablelist>
    -</refsect2>
    <refsect2 id="gtkconvs-displaying-im-msg" role="signal">
    <title>The <literal>&quot;displaying-im-msg&quot;</literal> signal</title>
    --- a/pidgin/gtkconv.c Thu Oct 29 23:23:18 2020 -0500
    +++ b/pidgin/gtkconv.c Thu Oct 29 23:26:02 2020 -0500
    @@ -6254,24 +6254,6 @@
    G_TYPE_POINTER, /* pointer to a (PidginConvWindow *) */
    G_TYPE_POINTER); /* pointer to a (PidginConvWindow *) */
    - purple_signal_register(handle, "conversation-timestamp",
    -#if SIZEOF_TIME_T == 4
    - purple_marshal_POINTER__POINTER_INT_BOOLEAN,
    -#elif SIZEOF_TIME_T == 8
    - purple_marshal_POINTER__POINTER_INT64_BOOLEAN,
    -#else
    -#error Unkown size of time_t
    -#endif
    - G_TYPE_STRING, 3, PURPLE_TYPE_CONVERSATION,
    -#if SIZEOF_TIME_T == 4
    - G_TYPE_INT,
    -#elif SIZEOF_TIME_T == 8
    - G_TYPE_INT64,
    -#else
    -# error Unknown size of time_t
    -#endif
    - G_TYPE_BOOLEAN);
    -
    purple_signal_register(handle, "displaying-im-msg",
    purple_marshal_BOOLEAN__POINTER_POINTER,
    G_TYPE_BOOLEAN, 2, PURPLE_TYPE_CONVERSATION, PURPLE_TYPE_MESSAGE);