pidgin/pidgin

Remove buddy icons from Pidgin

2 weeks ago, Gary Kramlich
2794bb8587d3
Parents 3761ba966eed
Children ceb13f1de2d2
Remove buddy icons from Pidgin

There were a few facets of BuddyIcons that slipped through the review request
removing buddies from Pidgin. This Takes care of them.

Testing Done:
Called in the turtles and checked out the account editor.

Reviewed at https://reviews.imfreedom.org/r/3122/
2 files changed, 2 insertions(+), 31 deletions(-)
  • +1 -10
    pidgin/pidginaccounteditor.c
  • +1 -21
    pidgin/pidginaccountmanagerrow.c
    • --- a/pidgin/pidginaccounteditor.c Sat Apr 13 23:52:51 2024 -0500
    +++ b/pidgin/pidginaccounteditor.c Sun Apr 14 01:08:37 2024 -0500
    @@ -260,7 +260,6 @@
    PurpleContactInfo *info = PURPLE_CONTACT_INFO(editor->account);
    svalue = purple_contact_info_get_alias(info);
    - image = purple_buddy_icons_find_account_icon(editor->account);
    use_global = purple_account_get_bool(editor->account,
    "use-global-buddyicon", TRUE);
    }
    @@ -813,15 +812,7 @@
    bvalue = gtk_switch_get_active(GTK_SWITCH(editor->use_custom_avatar));
    purple_account_set_bool(editor->account, "use-global-buddyicon", !bvalue);
    - if(bvalue) {
    - if(GDK_IS_PIXBUF(editor->avatar_pixbuf)) {
    - #pragma message("implement this when buddy icons do not suck so bad.")
    - } else {
    - purple_buddy_icons_set_account_icon(editor->account, NULL, 0);
    - }
    - } else {
    - #pragma message("set the global buddy icon when buddy icons do not suck so bad.")
    - }
    + #pragma message("implement this when buddy icons do not suck so bad.")
    purple_account_thaw_notify_settings(editor->account);
    }
    --- a/pidgin/pidginaccountmanagerrow.c Sat Apr 13 23:52:51 2024 -0500
    +++ b/pidgin/pidginaccountmanagerrow.c Sun Apr 14 01:08:37 2024 -0500
    @@ -48,28 +48,8 @@
    * Helpers
    *****************************************************************************/
    static void
    -pidgin_account_manager_row_refresh_buddy_icon(PidginAccountManagerRow *row) {
    - PurpleImage *image = NULL;
    -
    +pidgin_account_manager_row_refresh_buddy_icon(G_GNUC_UNUSED PidginAccountManagerRow *row) {
    #pragma message("FIX call this in the right place when buddy icons are better and can autorefresh")
    - if(!PURPLE_IS_ACCOUNT(row->account)) {
    - return;
    - }
    -
    - image = purple_buddy_icons_find_account_icon(row->account);
    - if(PURPLE_IS_IMAGE(image)) {
    - GdkTexture *texture = NULL;
    - GBytes *bytes = NULL;
    -
    - bytes = purple_image_get_contents(image);
    - texture = gdk_texture_new_from_bytes(bytes, NULL);
    - g_bytes_unref(bytes);
    -
    - if(GDK_IS_TEXTURE(texture)) {
    - adw_avatar_set_custom_image(row->avatar, GDK_PAINTABLE(texture));
    - g_object_unref(texture);
    - }
    - }
    }
    static void