pidgin/pidgin

Remove some unused and underused functions from gtkutils.[ch]

2022-03-11, Gary Kramlich
1b6374960c08
Parents 03f98ece6b26
Children be1969333ad1
Remove some unused and underused functions from gtkutils.[ch]

Testing Done:
Compiled

Reviewed at https://reviews.imfreedom.org/r/1324/
4 files changed, 5 insertions(+), 122 deletions(-)
  • +5 -0
    ChangeLog.API
  • +0 -3
    pidgin/gtkrequest.c
  • +0 -69
    pidgin/gtkutils.c
  • +0 -50
    pidgin/gtkutils.h
    • --- a/ChangeLog.API Fri Mar 11 01:23:12 2022 -0600
    +++ b/ChangeLog.API Fri Mar 11 01:27:50 2022 -0600
    @@ -830,6 +830,7 @@
    * PidginBuddyList.connection_errors
    * PidginButtonStyle
    * pidgin_check_if_dir
    + * pidgin_clear_cursor
    * PidginConversation.sg
    * PidginConvPlacementFunc
    * pidgin_conv_get_tab_at_xy
    @@ -900,6 +901,7 @@
    * PidginIconThemeLoader
    * PidginIconThemeLoaderClass
    * pidgin_idle_get_ui_ops
    + * pidgin_load_accels
    * pidgin_make_mini_dialog_with_custom_icon; use
    pidgin_mini_dialog_new_with_custom_icon instead.
    * pidgin_make_pretty_arrows
    @@ -916,6 +918,9 @@
    * pidgin_pounces_manager_hide
    * pidgin_pounces_manager_show
    * pidgin_protocol_option_menu_get_selected
    + * pidgin_save_accels
    + * pidgin_save_accels_cb
    + * pidgin_set_cursor
    * pidgin_set_custom_buddy_icon
    * pidgin_set_sensitive_if_input
    * pidgin_set_urgent, use gtk_window_set_urgency_hint instead.
    --- a/pidgin/gtkrequest.c Fri Mar 11 01:23:12 2022 -0600
    +++ b/pidgin/gtkrequest.c Fri Mar 11 01:27:50 2022 -0600
    @@ -120,9 +120,6 @@
    {
    g_return_if_fail(data != NULL);
    - /* Tell the user we're doing something. */
    - pidgin_set_cursor(GTK_WIDGET(data->dialog), GDK_WATCH);
    -
    g_object_set_data(G_OBJECT(data->dialog),
    "pidgin-window-is-closing", GINT_TO_POINTER(TRUE));
    gtk_widget_set_visible(GTK_WIDGET(data->dialog), FALSE);
    --- a/pidgin/gtkutils.c Fri Mar 11 01:23:12 2022 -0600
    +++ b/pidgin/gtkutils.c Fri Mar 11 01:27:50 2022 -0600
    @@ -99,12 +99,6 @@
    };
    /******************************************************************************
    - * Globals
    - *****************************************************************************/
    -
    -static guint accels_save_timer = 0;
    -
    -/******************************************************************************
    * Code
    *****************************************************************************/
    @@ -280,42 +274,6 @@
    }
    }
    -void
    -pidgin_save_accels_cb(GtkAccelGroup *accel_group, guint arg1,
    - GdkModifierType arg2, GClosure *arg3,
    - gpointer data)
    -{
    - purple_debug_misc("accels", "accel changed, scheduling save.");
    -
    - if (!accels_save_timer)
    - accels_save_timer = g_timeout_add_seconds(5, pidgin_save_accels,
    - NULL);
    -}
    -
    -gboolean
    -pidgin_save_accels(gpointer data)
    -{
    - char *filename = NULL;
    -
    - filename = g_build_filename(purple_config_dir(), "accels", NULL);
    - purple_debug_misc("accels", "saving accels to %s", filename);
    - gtk_accel_map_save(filename);
    - g_free(filename);
    -
    - accels_save_timer = 0;
    - return FALSE;
    -}
    -
    -void
    -pidgin_load_accels()
    -{
    - char *filename = NULL;
    -
    - filename = g_build_filename(purple_config_dir(), "accels", NULL);
    - gtk_accel_map_load(filename);
    - g_free(filename);
    -}
    -
    static void
    show_retrieveing_info(PurpleConnection *conn, const char *name)
    {
    @@ -940,33 +898,6 @@
    return all || purple_account_is_connected(purple_buddy_get_account(completion_entry->buddy));
    }
    -void pidgin_set_cursor(GtkWidget *widget, GdkCursorType cursor_type)
    -{
    - GdkDisplay *display;
    - GdkCursor *cursor;
    -
    - g_return_if_fail(widget != NULL);
    - if (gtk_widget_get_window(widget) == NULL)
    - return;
    -
    - display = gtk_widget_get_display(widget);
    - cursor = gdk_cursor_new_for_display(display, cursor_type);
    - gdk_window_set_cursor(gtk_widget_get_window(widget), cursor);
    -
    - g_object_unref(cursor);
    -
    - gdk_display_flush(gdk_window_get_display(gtk_widget_get_window(widget)));
    -}
    -
    -void pidgin_clear_cursor(GtkWidget *widget)
    -{
    - g_return_if_fail(widget != NULL);
    - if (gtk_widget_get_window(widget) == NULL)
    - return;
    -
    - gdk_window_set_cursor(gtk_widget_get_window(widget), NULL);
    -}
    -
    static void
    icon_filesel_choose_cb(GtkWidget *widget, gint response, struct _icon_chooser *dialog)
    {
    --- a/pidgin/gtkutils.h Fri Mar 11 01:23:12 2022 -0600
    +++ b/pidgin/gtkutils.h Fri Mar 11 01:27:50 2022 -0600
    @@ -136,29 +136,6 @@
    gboolean pidgin_screenname_autocomplete_default_filter(const PidginBuddyCompletionEntry *completion_entry, gpointer all_accounts);
    /**
    - * pidgin_save_accels_cb:
    - *
    - * Save menu accelerators callback
    - */
    -void pidgin_save_accels_cb(GtkAccelGroup *accel_group, guint arg1,
    - GdkModifierType arg2, GClosure *arg3,
    - gpointer data);
    -
    -/**
    - * pidgin_save_accels:
    - *
    - * Save menu accelerators
    - */
    -gboolean pidgin_save_accels(gpointer data);
    -
    -/**
    - * pidgin_load_accels:
    - *
    - * Load menu accelerators
    - */
    -void pidgin_load_accels(void);
    -
    -/**
    * pidgin_retrieve_user_info:
    * @conn: The connection to get information from.
    * @name: The user to get information about.
    @@ -288,33 +265,6 @@
    gpointer gobject);
    /**
    - * pidgin_set_cursor:
    - * @widget: The widget for which to set the mouse pointer
    - * @cursor_type: The type of cursor to set
    - *
    - * Sets the mouse pointer for a GtkWidget.
    - *
    - * After setting the cursor, the display is flushed, so the change will
    - * take effect immediately.
    - *
    - * If the window for @widget is %NULL, this function simply returns.
    - */
    -void pidgin_set_cursor(GtkWidget *widget, GdkCursorType cursor_type);
    -
    -/**
    - * pidgin_clear_cursor:
    - *
    - * Sets the mouse point for a GtkWidget back to that of its parent window.
    - *
    - * If @widget is %NULL, this function simply returns.
    - *
    - * If the window for @widget is %NULL, this function simply returns.
    - *
    - * Note: The display is not flushed from this function.
    - */
    -void pidgin_clear_cursor(GtkWidget *widget);
    -
    -/**
    * pidgin_buddy_icon_chooser_new:
    * @parent: The parent window
    * @callback: The callback to call when the window is closed. If the user chose an icon, the char* argument will point to its path