pidgin/pidgin

Remove a pango deprecation that was actually really messing up a tooltip in RTL languages

2021-01-11, Gary Kramlich
1a0041a6cd6c
Parents c75a82bd0957
Children 4d91fb883f4b
Remove a pango deprecation that was actually really messing up a tooltip in RTL languages

Testing Done:
Ran locally.

Reviewed at https://reviews.imfreedom.org/r/416/
1 files changed, 0 insertions(+), 19 deletions(-)
  • +0 -19
    pidgin/gtkblist.c
    • --- a/pidgin/gtkblist.c Mon Jan 11 00:03:41 2021 -0600
    +++ b/pidgin/gtkblist.c Mon Jan 11 00:04:14 2021 -0600
    @@ -3015,22 +3015,6 @@
    pidgin_tooltip_destroy();
    }
    -static void
    -pidgin_blist_align_tooltip(struct tooltip_data *td, GtkWidget *widget)
    -{
    - GtkTextDirection dir = gtk_widget_get_direction(widget);
    -
    - if (dir == GTK_TEXT_DIR_RTL)
    - {
    - char* layout_name = purple_markup_strip_html(pango_layout_get_text(td->name_layout));
    - PangoDirection dir = pango_find_base_dir(layout_name, -1);
    - if (dir == PANGO_DIRECTION_RTL || dir == PANGO_DIRECTION_NEUTRAL)
    - pango_layout_set_alignment(td->name_layout, PANGO_ALIGN_RIGHT);
    - g_free(layout_name);
    - pango_layout_set_alignment(td->layout, PANGO_ALIGN_RIGHT);
    - }
    -}
    -
    static gboolean
    pidgin_blist_create_tooltip_for_node(GtkWidget *widget, gpointer data, int *w, int *h)
    {
    @@ -3050,13 +3034,11 @@
    if (PURPLE_IS_CHAT(node) ||
    PURPLE_IS_BUDDY(node)) {
    struct tooltip_data *td = create_tip_for_node(node, TRUE);
    - pidgin_blist_align_tooltip(td, gtkblist->tipwindow);
    gtkblist->tooltipdata = g_list_append(gtkblist->tooltipdata, td);
    } else if (PURPLE_IS_GROUP(node)) {
    PurpleGroup *group = (PurpleGroup*)node;
    GSList *accounts;
    struct tooltip_data *td = create_tip_for_node(node, TRUE);
    - pidgin_blist_align_tooltip(td, gtkblist->tipwindow);
    gtkblist->tooltipdata = g_list_append(gtkblist->tooltipdata, td);
    /* Accounts with buddies in group */
    @@ -3075,7 +3057,6 @@
    {
    if(PURPLE_IS_BUDDY(child) && buddy_is_displayable((PurpleBuddy*)child)) {
    struct tooltip_data *td = create_tip_for_node(child, (b == (PurpleBuddy*)child));
    - pidgin_blist_align_tooltip(td, gtkblist->tipwindow);
    if (b == (PurpleBuddy *)child) {
    gtkblist->tooltipdata = g_list_prepend(gtkblist->tooltipdata, td);
    } else {