pidgin/pidgin

An old update from Eion to return a clearer error message.
release-2.x.y
2021-02-13, Gary Kramlich
12ea3e05a3cd
Parents fe331f8fcbc2
Children cfb55052d83a
An old update from Eion to return a clearer error message.

The original error message was "Not Authorized" but many users would say they
have the correct password, however in this particular check we know that the
server didn't like their credentials so we return "Invalid username or
password" instead.

Testing Done:
Compiled locally.

Bugs closed: PIDGIN-16437

Reviewed at https://reviews.imfreedom.org/r/502/
1 files changed, 1 insertions(+), 1 deletions(-)
  • +1 -1
    libpurple/protocols/jabber/jabber.c
    • --- a/libpurple/protocols/jabber/jabber.c Fri Feb 12 18:49:00 2021 -0600
    +++ b/libpurple/protocols/jabber/jabber.c Sat Feb 13 01:11:27 2021 -0600
    @@ -2782,7 +2782,7 @@
    /* Clear the pasword if it isn't being saved */
    if (!purple_account_get_remember_password(js->gc->account))
    purple_account_set_password(js->gc->account, NULL);
    - text = _("Not Authorized");
    + text = _("Incorrect username or password");
    } else if(xmlnode_get_child(packet, "temporary-auth-failure")) {
    text = _("Temporary Authentication Failure");
    } else {