pidgin/pidgin

Patch from itsnotabigtruck to fix jabber Attention messages being sent to incorrect ID
release-2.x.y
2022-04-18, Belgin Știrbu
056267447549
Parents 82f6b5267eac
Children 1eb2029a50c1
Patch from itsnotabigtruck to fix jabber Attention messages being sent to incorrect ID

Testing Done:
Sent some attention messages, noticed the issue was occuring consistently. Applied the patch, issue did not occur anymore.

Bugs closed: PIDGIN-14714

Reviewed at https://reviews.imfreedom.org/r/1387/
1 files changed, 6 insertions(+), 1 deletions(-)
  • +6 -1
    libpurple/protocols/jabber/jabber.c
    • --- a/libpurple/protocols/jabber/jabber.c Fri Apr 15 13:21:50 2022 -0500
    +++ b/libpurple/protocols/jabber/jabber.c Mon Apr 18 21:03:40 2022 -0500
    @@ -3179,7 +3179,12 @@
    xmlnode *buzz, *msg = xmlnode_new("message");
    gchar *to;
    - to = g_strdup_printf("%s/%s", username, jbr->name);
    + if((strchr(username, '/') == NULL) && jbr && (jbr->name != NULL)) {
    + to = g_strdup_printf("%s/%s", username, jbr->name);
    + } else {
    + to = g_strdup(username);
    + }
    +
    xmlnode_set_attrib(msg, "to", to);
    g_free(to);